Google Git
Sign in
qemu / skiboot / refs/heads/gh-pages / . / doc / release-notes / skiboot-6.2.html
blob: ef58cfbddb533f235a206c0bd021ef23b3f5d7ea [file] [log] [blame]
<!DOCTYPE html>
<html lang="en" data-content_root="../">
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" /><meta name="viewport" content="width=device-width, initial-scale=1" />
<title>skiboot-6.2 &#8212; skiboot d365a01
documentation</title>
<link rel="stylesheet" type="text/css" href="../_static/pygments.css?v=fa44fd50" />
<link rel="stylesheet" type="text/css" href="../_static/classic.css?v=514cf933" />
<script src="../_static/documentation_options.js?v=e1fecbe9"></script>
<script src="../_static/doctools.js?v=888ff710"></script>
<script src="../_static/sphinx_highlight.js?v=dc90522c"></script>
<link rel="index" title="Index" href="../genindex.html" />
<link rel="search" title="Search" href="../search.html" />
<link rel="next" title="skiboot-6.2-rc1" href="skiboot-6.2-rc1.html" />
<link rel="prev" title="skiboot-6.1-rc1" href="skiboot-6.1-rc1.html" />
</head><body>
<div class="related" role="navigation" aria-label="related navigation">
<h3>Navigation</h3>
<ul>
<li class="right" style="margin-right: 10px">
<a href="../genindex.html" title="General Index"
accesskey="I">index</a></li>
<li class="right" >
<a href="skiboot-6.2-rc1.html" title="skiboot-6.2-rc1"
accesskey="N">next</a> |</li>
<li class="right" >
<a href="skiboot-6.1-rc1.html" title="skiboot-6.1-rc1"
accesskey="P">previous</a> |</li>
<li class="nav-item nav-item-0"><a href="../index.html">skiboot d365a01
documentation</a> &#187;</li>
<li class="nav-item nav-item-1"><a href="index.html" accesskey="U">Release Notes</a> &#187;</li>
<li class="nav-item nav-item-this"><a href="">skiboot-6.2</a></li>
</ul>
</div>
<div class="document">
<div class="documentwrapper">
<div class="bodywrapper">
<div class="body" role="main">
<section id="skiboot-6-2">
<span id="id1"></span><h1>skiboot-6.2<a class="headerlink" href="#skiboot-6-2" title="Link to this heading"></a></h1>
<p>skiboot v6.2 was released on Friday December 14th 2018. It is the first
release of skiboot 6.2, which becomes the new stable release
of skiboot following the 6.1 release, first released July 11th 2018.</p>
<p>Skiboot 6.2 will mark the basis for op-build v2.2.</p>
<p>skiboot v6.2 contains all bug fixes as of <a class="reference internal" href="skiboot-6.0.14.html#skiboot-6-0-14"><span class="std std-ref">skiboot-6.0.14</span></a>,
and <a class="reference internal" href="skiboot-5.4.10.html#skiboot-5-4-10"><span class="std std-ref">skiboot-5.4.10</span></a> (the currently maintained
stable releases).</p>
<p>For how the skiboot stable releases work, see <a class="reference internal" href="../process/stable-skiboot-rules.html#stable-rules"><span class="std std-ref">Skiboot stable tree rules and releases</span></a> for details.</p>
<p>This release has been a longer cycle than typical for a variety of reasons. It
also contains a lot of cleanup work and minor bug fixes (much like skiboot 6.1
did).</p>
<p>Over skiboot 6.1, we have the following changes:</p>
<section id="general">
<h2>General<a class="headerlink" href="#general" title="Link to this heading"></a></h2>
<p>Since v6.2-rc2:</p>
<ul>
<li><p>i2c: Fix i2c request hang during opal init if timers are not checked</p>
<p>If an i2c request cannot go through the first time, because the bus is
found in error and need a reset or it’s locked by the OCC for example,
the underlying i2c implementation is using timers to manage the
request. However during opal init, opal pollers may not be called, it
depends in the context in which the i2c request is made. If the
pollers are not called, the timers are not checked and we can end up
with an i2c request which will not move foward and skiboot hangs.</p>
<p>Fix it by explicitly checking the timers if we are waiting for an i2c
request to complete and it seems to be taking a while.</p>
</li>
</ul>
<p>Since v6.1:</p>
<ul>
<li><p>cpu: Quieten OS endian switch messages</p>
<p>Users see these when loading an OS from Petitboot:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="p">[</span> <span class="mf">119.486794100</span><span class="p">,</span><span class="mi">5</span><span class="p">]</span> <span class="n">OPAL</span><span class="p">:</span> <span class="n">Switch</span> <span class="n">to</span> <span class="n">big</span><span class="o">-</span><span class="n">endian</span> <span class="n">OS</span>
<span class="p">[</span> <span class="mf">120.022302604</span><span class="p">,</span><span class="mi">5</span><span class="p">]</span> <span class="n">OPAL</span><span class="p">:</span> <span class="n">Switch</span> <span class="n">to</span> <span class="n">little</span><span class="o">-</span><span class="n">endian</span> <span class="n">OS</span>
</pre></div>
</div>
<p>Which is expected and doesn’t provide any information the user can act
on. Switch them to PR_INFO so they still appear in the log, but not on
the serial console.</p>
</li>
<li><p>Recognise signed VERSION partition</p>
<p>A few things need to change to support a signed VERSION partition:</p>
<ul class="simple">
<li><p>A signed VERSION partition will be 4K + SECURE_BOOT_HEADERS_SIZE (4K).</p></li>
<li><p>The VERSION partition needs to be loaded after secure/trusted boot is
set up, and therefore after nvram_init().</p></li>
<li><p>Added to the trustedboot resources array.</p></li>
</ul>
<p>This also moves the ipmi_dt_add_bmc_info() call to after
flash_dt_add_fw_version() since it adds info to ibm,firmware-versions.</p>
</li>
<li><p>Run pollers in time_wait() when not booting</p>
<p>This only bit us hard with hiomap in one scenario.</p>
<p>Our OPAL API has been OPAL_POLL_EVENTS may be needed to make forward
progress on ongoing operations, and the internal to skiboot API has been
that time_wait() of a suitable time will run pollers (on at least one
CPU) to help ensure forward progress can be made.</p>
<p>In a perfect world, interrupts are used but they may: a) be disabled, or
b) the thing we’re doing can’t use interrupts because computers are
generally terrible.</p>
<p>Back in 3db397ea5892a (circa 2015), we changed skiboot so that we’d run
pollers only on the boot CPU, and not if we held any locks. This was to
reduce the chance of programming code that could deadlock, as well as to
ensure that we didn’t just thrash all the cachelines for running pollers
all over a large system during boot, or hard spin on the same locks on
all secondary CPUs.</p>
<p>The problem arises if the OS we’re booting makes an OPAL call early on,
with interrupts disabled, that requires a poller to run to make forward
progress. An example of this would be OPAL_WRITE_NVRAM early in Linux
boot (where Linux sets up the partitions it wants) - something that
occurs iff we’ve had to reformat NVRAM this boot (i.e. first boot or
corrupted NVRAM).</p>
<p>The hiomap implementation should arguably <em>not</em> rely on synchronous IPMI
messages, but this is a future improvement (as was for mbox before it).
The mbox-flash code solved this problem by spinning on check_timers().</p>
<p>More generically though, the approach of running the pollers when no
longer booting means we behave more in line with what the API is meant
to be, rather than have this odd case of “time_wait() for a condition
that could also be tripped by an interrupt works fine unless the OS is
up and running but hasn’t set interrupts up yet”.</p>
</li>
<li><p>ipmi: Reduce ipmi_queue_msg_sync() polling loop time to 10ms</p>
<p>On a plain boot, this reduces the time spent in OPAL by ~170ms on
p9dsu. This is due to hiomap (currently) using synchronous IPMI
messages.</p>
<p>It will also <em>significantly</em> reduce latency on runtime flash
operations for hiomap, as we’ll spend typically 10-20ms in OPAL
rather than 100-200ms. It’s not an ideal solution to that, but
it’s a quick and obvious win for jitter.</p>
</li>
<li><p>core/device: NULL pointer dereference fix</p></li>
<li><p>core/flash: NULL pointer dereference fixes</p></li>
<li><p>core/cpu: Call memset with proper cpu_thread offset</p></li>
<li><p>libflash: Add ipmi-hiomap, and prefer it for PNOR access</p>
<p>ipmi-hiomap implements the PNOR access control protocol formerly known
as “the mbox protocol” but uses IPMI instead of the AST LPC mailbox as a
transport. As there is no-longer any mailbox involved in this alternate
implementation the old protocol name is quite misleading, and so it has
been renamed to “the hiomap protoocol” (Host I/O Mapping protocol). The
same commands and events are used though this client-side implementation
assumes v2 of the protocol is supported by the BMC.</p>
<p>The code is a heavily-reworked copy of the mbox-flash source and is
introduced this way to allow for the mbox implementation’s eventual
removal.</p>
<p>mbox-flash should in theory be renamed to mbox-hiomap for consistency,
but as it is on life-support effective immediately we may as well just
remove it entirely when the time is right.</p>
</li>
<li><p>opal/hmi: Handle early HMIs on thread0 when secondaries are still in OPAL.</p>
<p>When primary thread receives a CORE level HMI for timer facility errors
while secondaries are still in OPAL, thread 0 ends up in rendez-vous
waiting for secondaries to get into hmi handling. This is because OPAL
runs with MSR(EE=0) and hence HMIs are delayed on secondary threads until
they are given to Linux OS. Fix this by adding a check for secondary
state and force them in hmi handling by queuing job on secondary threads.</p>
<p>I have tested this by injecting HDEC parity error very early during Linux
kernel boot. Recovery works fine for non-TB errors. But if TB is bad at
this very eary stage we already doomed.</p>
<p>Without this patch we see:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="p">[</span> <span class="mf">285.046347408</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">OPAL</span><span class="p">:</span> <span class="n">Start</span> <span class="n">CPU</span> <span class="mh">0x0843</span> <span class="p">(</span><span class="n">PIR</span> <span class="mh">0x0843</span><span class="p">)</span> <span class="o">-&gt;</span> <span class="mh">0x000000000000a83c</span>
<span class="p">[</span> <span class="mf">285.051160609</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">OPAL</span><span class="p">:</span> <span class="n">Start</span> <span class="n">CPU</span> <span class="mh">0x0844</span> <span class="p">(</span><span class="n">PIR</span> <span class="mh">0x0844</span><span class="p">)</span> <span class="o">-&gt;</span> <span class="mh">0x000000000000a83c</span>
<span class="p">[</span> <span class="mf">285.055359021</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Received</span> <span class="n">HMI</span> <span class="n">interrupt</span><span class="p">:</span> <span class="n">HMER</span> <span class="o">=</span> <span class="mh">0x0840000000000000</span>
<span class="p">[</span> <span class="mf">285.055361439</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="p">[</span><span class="n">Loc</span><span class="p">:</span> <span class="n">U78D3</span><span class="o">.</span><span class="n">ND1</span><span class="o">.</span><span class="n">WZS004A</span><span class="o">-</span><span class="n">P1</span><span class="o">-</span><span class="n">C48</span><span class="p">]:</span> <span class="n">P</span><span class="p">:</span><span class="mi">8</span> <span class="n">C</span><span class="p">:</span><span class="mi">17</span> <span class="n">T</span><span class="p">:</span><span class="mi">0</span><span class="p">:</span> <span class="n">TFMR</span><span class="p">(</span><span class="mf">2e12002870</span><span class="n">e14000</span><span class="p">)</span> <span class="n">Timer</span> <span class="n">Facility</span> <span class="n">Error</span>
<span class="p">[</span> <span class="mf">286.232183823</span><span class="p">,</span><span class="mi">3</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Rendez</span><span class="o">-</span><span class="n">vous</span> <span class="n">stage</span> <span class="mi">1</span> <span class="n">timeout</span><span class="p">,</span> <span class="n">CPU</span> <span class="mh">0x844</span> <span class="n">waiting</span> <span class="k">for</span> <span class="n">thread</span> <span class="mi">1</span> <span class="p">(</span><span class="n">sptr</span><span class="o">=</span><span class="mi">0000</span><span class="n">ccc1</span><span class="p">)</span>
<span class="p">[</span> <span class="mf">287.409002056</span><span class="p">,</span><span class="mi">3</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Rendez</span><span class="o">-</span><span class="n">vous</span> <span class="n">stage</span> <span class="mi">1</span> <span class="n">timeout</span><span class="p">,</span> <span class="n">CPU</span> <span class="mh">0x844</span> <span class="n">waiting</span> <span class="k">for</span> <span class="n">thread</span> <span class="mi">2</span> <span class="p">(</span><span class="n">sptr</span><span class="o">=</span><span class="mi">0000</span><span class="n">ccc1</span><span class="p">)</span>
<span class="p">[</span> <span class="mf">289.073820164</span><span class="p">,</span><span class="mi">3</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Rendez</span><span class="o">-</span><span class="n">vous</span> <span class="n">stage</span> <span class="mi">1</span> <span class="n">timeout</span><span class="p">,</span> <span class="n">CPU</span> <span class="mh">0x844</span> <span class="n">waiting</span> <span class="k">for</span> <span class="n">thread</span> <span class="mi">3</span> <span class="p">(</span><span class="n">sptr</span><span class="o">=</span><span class="mi">0000</span><span class="n">ccc1</span><span class="p">)</span>
<span class="p">[</span> <span class="mf">290.250638683</span><span class="p">,</span><span class="mi">3</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Rendez</span><span class="o">-</span><span class="n">vous</span> <span class="n">stage</span> <span class="mi">1</span> <span class="n">timeout</span><span class="p">,</span> <span class="n">CPU</span> <span class="mh">0x844</span> <span class="n">waiting</span> <span class="k">for</span> <span class="n">thread</span> <span class="mi">1</span> <span class="p">(</span><span class="n">sptr</span><span class="o">=</span><span class="mi">0000</span><span class="n">ccc2</span><span class="p">)</span>
<span class="p">[</span> <span class="mf">291.427456821</span><span class="p">,</span><span class="mi">3</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Rendez</span><span class="o">-</span><span class="n">vous</span> <span class="n">stage</span> <span class="mi">1</span> <span class="n">timeout</span><span class="p">,</span> <span class="n">CPU</span> <span class="mh">0x844</span> <span class="n">waiting</span> <span class="k">for</span> <span class="n">thread</span> <span class="mi">2</span> <span class="p">(</span><span class="n">sptr</span><span class="o">=</span><span class="mi">0000</span><span class="n">ccc2</span><span class="p">)</span>
<span class="p">[</span> <span class="mf">293.092274807</span><span class="p">,</span><span class="mi">3</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Rendez</span><span class="o">-</span><span class="n">vous</span> <span class="n">stage</span> <span class="mi">1</span> <span class="n">timeout</span><span class="p">,</span> <span class="n">CPU</span> <span class="mh">0x844</span> <span class="n">waiting</span> <span class="k">for</span> <span class="n">thread</span> <span class="mi">3</span> <span class="p">(</span><span class="n">sptr</span><span class="o">=</span><span class="mi">0000</span><span class="n">ccc2</span><span class="p">)</span>
<span class="p">[</span> <span class="mf">294.269092904</span><span class="p">,</span><span class="mi">3</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Rendez</span><span class="o">-</span><span class="n">vous</span> <span class="n">stage</span> <span class="mi">1</span> <span class="n">timeout</span><span class="p">,</span> <span class="n">CPU</span> <span class="mh">0x844</span> <span class="n">waiting</span> <span class="k">for</span> <span class="n">thread</span> <span class="mi">1</span> <span class="p">(</span><span class="n">sptr</span><span class="o">=</span><span class="mi">0000</span><span class="n">ccc3</span><span class="p">)</span>
<span class="p">[</span> <span class="mf">295.445910944</span><span class="p">,</span><span class="mi">3</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Rendez</span><span class="o">-</span><span class="n">vous</span> <span class="n">stage</span> <span class="mi">1</span> <span class="n">timeout</span><span class="p">,</span> <span class="n">CPU</span> <span class="mh">0x844</span> <span class="n">waiting</span> <span class="k">for</span> <span class="n">thread</span> <span class="mi">2</span> <span class="p">(</span><span class="n">sptr</span><span class="o">=</span><span class="mi">0000</span><span class="n">ccc3</span><span class="p">)</span>
<span class="p">[</span> <span class="mf">297.110728970</span><span class="p">,</span><span class="mi">3</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Rendez</span><span class="o">-</span><span class="n">vous</span> <span class="n">stage</span> <span class="mi">1</span> <span class="n">timeout</span><span class="p">,</span> <span class="n">CPU</span> <span class="mh">0x844</span> <span class="n">waiting</span> <span class="k">for</span> <span class="n">thread</span> <span class="mi">3</span> <span class="p">(</span><span class="n">sptr</span><span class="o">=</span><span class="mi">0000</span><span class="n">ccc3</span><span class="p">)</span>
</pre></div>
</div>
<p>After this patch:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="p">[</span> <span class="mf">259.401719351</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">OPAL</span><span class="p">:</span> <span class="n">Start</span> <span class="n">CPU</span> <span class="mh">0x0841</span> <span class="p">(</span><span class="n">PIR</span> <span class="mh">0x0841</span><span class="p">)</span> <span class="o">-&gt;</span> <span class="mh">0x000000000000a83c</span>
<span class="p">[</span> <span class="mf">259.406259572</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">OPAL</span><span class="p">:</span> <span class="n">Start</span> <span class="n">CPU</span> <span class="mh">0x0842</span> <span class="p">(</span><span class="n">PIR</span> <span class="mh">0x0842</span><span class="p">)</span> <span class="o">-&gt;</span> <span class="mh">0x000000000000a83c</span>
<span class="p">[</span> <span class="mf">259.410615534</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">OPAL</span><span class="p">:</span> <span class="n">Start</span> <span class="n">CPU</span> <span class="mh">0x0843</span> <span class="p">(</span><span class="n">PIR</span> <span class="mh">0x0843</span><span class="p">)</span> <span class="o">-&gt;</span> <span class="mh">0x000000000000a83c</span>
<span class="p">[</span> <span class="mf">259.415444519</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">OPAL</span><span class="p">:</span> <span class="n">Start</span> <span class="n">CPU</span> <span class="mh">0x0844</span> <span class="p">(</span><span class="n">PIR</span> <span class="mh">0x0844</span><span class="p">)</span> <span class="o">-&gt;</span> <span class="mh">0x000000000000a83c</span>
<span class="p">[</span> <span class="mf">259.419641401</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Received</span> <span class="n">HMI</span> <span class="n">interrupt</span><span class="p">:</span> <span class="n">HMER</span> <span class="o">=</span> <span class="mh">0x0840000000000000</span>
<span class="p">[</span> <span class="mf">259.419644124</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="p">[</span><span class="n">Loc</span><span class="p">:</span> <span class="n">U78D3</span><span class="o">.</span><span class="n">ND1</span><span class="o">.</span><span class="n">WZS004A</span><span class="o">-</span><span class="n">P1</span><span class="o">-</span><span class="n">C48</span><span class="p">]:</span> <span class="n">P</span><span class="p">:</span><span class="mi">8</span> <span class="n">C</span><span class="p">:</span><span class="mi">17</span> <span class="n">T</span><span class="p">:</span><span class="mi">0</span><span class="p">:</span> <span class="n">TFMR</span><span class="p">(</span><span class="mf">2e12002870</span><span class="n">e04000</span><span class="p">)</span> <span class="n">Timer</span> <span class="n">Facility</span> <span class="n">Error</span>
<span class="p">[</span> <span class="mf">259.419650678</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Sending</span> <span class="n">hmi</span> <span class="n">job</span> <span class="n">to</span> <span class="n">thread</span> <span class="mi">1</span>
<span class="p">[</span> <span class="mf">259.419652744</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Sending</span> <span class="n">hmi</span> <span class="n">job</span> <span class="n">to</span> <span class="n">thread</span> <span class="mi">2</span>
<span class="p">[</span> <span class="mf">259.419653051</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Received</span> <span class="n">HMI</span> <span class="n">interrupt</span><span class="p">:</span> <span class="n">HMER</span> <span class="o">=</span> <span class="mh">0x0840000000000000</span>
<span class="p">[</span> <span class="mf">259.419654725</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Sending</span> <span class="n">hmi</span> <span class="n">job</span> <span class="n">to</span> <span class="n">thread</span> <span class="mi">3</span>
<span class="p">[</span> <span class="mf">259.419654916</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Received</span> <span class="n">HMI</span> <span class="n">interrupt</span><span class="p">:</span> <span class="n">HMER</span> <span class="o">=</span> <span class="mh">0x0840000000000000</span>
<span class="p">[</span> <span class="mf">259.419658025</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="n">Received</span> <span class="n">HMI</span> <span class="n">interrupt</span><span class="p">:</span> <span class="n">HMER</span> <span class="o">=</span> <span class="mh">0x0840000000000000</span>
<span class="p">[</span> <span class="mf">259.419658406</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="p">[</span><span class="n">Loc</span><span class="p">:</span> <span class="n">U78D3</span><span class="o">.</span><span class="n">ND1</span><span class="o">.</span><span class="n">WZS004A</span><span class="o">-</span><span class="n">P1</span><span class="o">-</span><span class="n">C48</span><span class="p">]:</span> <span class="n">P</span><span class="p">:</span><span class="mi">8</span> <span class="n">C</span><span class="p">:</span><span class="mi">17</span> <span class="n">T</span><span class="p">:</span><span class="mi">2</span><span class="p">:</span> <span class="n">TFMR</span><span class="p">(</span><span class="mf">2e12002870</span><span class="n">e04000</span><span class="p">)</span> <span class="n">Timer</span> <span class="n">Facility</span> <span class="n">Error</span>
<span class="p">[</span> <span class="mf">259.419663095</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="p">[</span><span class="n">Loc</span><span class="p">:</span> <span class="n">U78D3</span><span class="o">.</span><span class="n">ND1</span><span class="o">.</span><span class="n">WZS004A</span><span class="o">-</span><span class="n">P1</span><span class="o">-</span><span class="n">C48</span><span class="p">]:</span> <span class="n">P</span><span class="p">:</span><span class="mi">8</span> <span class="n">C</span><span class="p">:</span><span class="mi">17</span> <span class="n">T</span><span class="p">:</span><span class="mi">3</span><span class="p">:</span> <span class="n">TFMR</span><span class="p">(</span><span class="mf">2e12002870</span><span class="n">e04000</span><span class="p">)</span> <span class="n">Timer</span> <span class="n">Facility</span> <span class="n">Error</span>
<span class="p">[</span> <span class="mf">259.419655234</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">HMI</span><span class="p">:</span> <span class="p">[</span><span class="n">Loc</span><span class="p">:</span> <span class="n">U78D3</span><span class="o">.</span><span class="n">ND1</span><span class="o">.</span><span class="n">WZS004A</span><span class="o">-</span><span class="n">P1</span><span class="o">-</span><span class="n">C48</span><span class="p">]:</span> <span class="n">P</span><span class="p">:</span><span class="mi">8</span> <span class="n">C</span><span class="p">:</span><span class="mi">17</span> <span class="n">T</span><span class="p">:</span><span class="mi">1</span><span class="p">:</span> <span class="n">TFMR</span><span class="p">(</span><span class="mf">2e12002870</span><span class="n">e04000</span><span class="p">)</span> <span class="n">Timer</span> <span class="n">Facility</span> <span class="n">Error</span>
<span class="p">[</span> <span class="mf">259.425109779</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">OPAL</span><span class="p">:</span> <span class="n">Start</span> <span class="n">CPU</span> <span class="mh">0x0845</span> <span class="p">(</span><span class="n">PIR</span> <span class="mh">0x0845</span><span class="p">)</span> <span class="o">-&gt;</span> <span class="mh">0x000000000000a83c</span>
<span class="p">[</span> <span class="mf">259.429870681</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">OPAL</span><span class="p">:</span> <span class="n">Start</span> <span class="n">CPU</span> <span class="mh">0x0846</span> <span class="p">(</span><span class="n">PIR</span> <span class="mh">0x0846</span><span class="p">)</span> <span class="o">-&gt;</span> <span class="mh">0x000000000000a83c</span>
<span class="p">[</span> <span class="mf">259.434549250</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">OPAL</span><span class="p">:</span> <span class="n">Start</span> <span class="n">CPU</span> <span class="mh">0x0847</span> <span class="p">(</span><span class="n">PIR</span> <span class="mh">0x0847</span><span class="p">)</span> <span class="o">-&gt;</span> <span class="mh">0x000000000000a83c</span>
</pre></div>
</div>
</li>
<li><p>core/cpu: Fix memory allocation for job array</p>
<p>fixes: 7a3f307e core/cpu: parallelise global CPU register setting jobs</p>
<p>This bug would result in boot-hang on some configurations due to
cpu_wait_job() endlessly waiting for the last bogus jobs[cpu-&gt;pir] pointer.</p>
</li>
<li><p>i2c: Fix multiple-enqueue of the same request on NACK</p>
<p>i2c_request_send() will retry the request if the error is a NAK,
however it forgets to clear the “ud.done” flag. It will thus
loop again and try to re-enqueue the same request causing internal
request list corruption.</p>
</li>
<li><p>i2c: Ensure ordering between i2c_request_send() and completion</p>
<p>i2c_request_send loops waiting for a flag “uc.done” set by
the completion routine, and then look for a result code
also set by that same completion.</p>
<p>There is no synchronization, the completion can happen on another
processor, so we need to order the stores to uc and the reads
from uc so that uc.done is stored last and tested first using
memory barriers.</p>
</li>
<li><p>pci: Clarify power down logic</p>
<p>Currently pci_scan_bus() unconditionally calls pci_slot_set_power_state()
when it’s finished scanning a bus. This is one of those things that
makes you go “WHAT?” when you first see it and frankly the skiboot PCI
code could do with less of that.</p>
</li>
</ul>
<section id="fast-reboot">
<h3>Fast Reboot<a class="headerlink" href="#fast-reboot" title="Link to this heading"></a></h3>
<ul>
<li><p>fast-reboot: parallel memory clearing</p>
<p>Arbitrarily pick 16GB as the unit of parallelism, and
split up clearing memory into jobs and schedule them
node-local to the memory (or on node 0 if we can’t
work that out because it’s the memory up to SKIBOOT_BASE)</p>
<p>This seems to cut at least ~40% time from memory zeroing on
fast-reboot on a 256GB Boston system.</p>
<p>For many systems, scanning PCI takes about as much time as
zeroing all of RAM, so we may as well do them at the same time
and cut a few seconds off the total fast reboot time.</p>
</li>
<li><p>fast-reboot: verify firmware “romem” checksum</p>
<p>This takes a checksum of skiboot memory after boot that should be
unchanged during OS operation, and verifies it before allowing a
fast reboot.</p>
<p>This is not read-only memory from skiboot’s point of view, beause
it includes things like the opal branch table that gets populated
during boot.</p>
<p>This helps to improve the integrity of firmware against host and
runtime firmware memory scribble bugs.</p>
</li>
<li><p>core/fast-reboot: print the fast reboot disable reason</p>
<p>Once things start to go wrong, disable_fast_reboot can be called a
number of times, so make the first reason sticky, and also print it
to the console at disable time. This helps with making sense of
fast reboot disables.</p>
</li>
<li><p>Add fast-reboot property to /ibm,opal DT node</p>
<p>this means that if it’s permanently disabled on boot, the test suite can
pick that up and not try a fast reboot test.</p>
</li>
</ul>
</section>
</section>
<section id="utilities">
<h2>Utilities<a class="headerlink" href="#utilities" title="Link to this heading"></a></h2>
<p>Since v6.2-rc2:</p>
<ul>
<li><p>opal-prd: hservice: Enable hservice-&gt;wakeup() in BMC</p>
<p>This patch enables HBRT to use HYP special wakeup register in openBMC
which until now was only used in FSP based machines.</p>
<p>This patch also adds a capability check for opal-prd so that HBRT can
decide if the host special wakeup register can be used.</p>
</li>
<li><p>ffspart: Support flashing already ECC protected images</p>
<p>We do this by assuming filenames with ‘.ecc’ in them are already ECC
protected.</p>
<p>This solves a practical problem in transitioning op-build to use ffspart
for pnor assembly rather than three perl scripts and a lot of XML.</p>
<p>We also update the ffspart tests to take into account ECC requirements.</p>
</li>
<li><p>ffspart: Increase MAX_LINE to above PATH_MAX</p>
<p>Otherwise we saw failures in CI and the ~221 character paths Jankins
likes to have.</p>
</li>
<li><p>libflash/file: greatly increase perf of file_erase()</p>
<p>Do 4096 byte chunks not 8 byte chunks. A ffspart invocation constructing
a 64MB PNOR goes from a couple of seconds to ~0.1seconds with this
patch.</p>
</li>
</ul>
<p>Since v6.2-rc1:
- libflash: Don’t merge ECC-protected ranges</p>
<blockquote>
<div><p>Libflash currently merges contiguous ECC-protected ranges, but doesn’t
check that the ECC bytes at the end of the first and start of the second
range actually match sanely. More importantly, if blocklevel_read() is
called with a position at the start of a partition that is contained
somewhere within a region that has been merged it will update the
position assuming ECC wasn’t being accounted for. This results in the
position being somewhere well after the actual start of the partition
which is incorrect.</p>
<p>For now, remove the code merging ranges. This means more ranges must be
held and checked however it prevents incorrectly reading ECC-correct
regions like below:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="p">[</span> <span class="mf">174.334119453</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">FLASH</span><span class="p">:</span> <span class="n">CAPP</span> <span class="n">partition</span> <span class="n">has</span> <span class="n">ECC</span>
<span class="p">[</span> <span class="mf">174.437349574</span><span class="p">,</span><span class="mi">3</span><span class="p">]</span> <span class="n">ECC</span><span class="p">:</span> <span class="n">uncorrectable</span> <span class="n">error</span><span class="p">:</span> <span class="n">ffffffffffffffff</span> <span class="n">ff</span>
<span class="p">[</span> <span class="mf">174.437426306</span><span class="p">,</span><span class="mi">3</span><span class="p">]</span> <span class="n">FLASH</span><span class="p">:</span> <span class="n">failed</span> <span class="n">to</span> <span class="n">read</span> <span class="n">the</span> <span class="n">first</span> <span class="mh">0x1000</span> <span class="kn">from</span> <span class="nn">CAPP</span> <span class="n">partition</span><span class="p">,</span> <span class="n">rc</span> <span class="mi">14</span>
<span class="p">[</span> <span class="mf">174.439919343</span><span class="p">,</span><span class="mi">3</span><span class="p">]</span> <span class="n">CAPP</span><span class="p">:</span> <span class="n">Error</span> <span class="n">loading</span> <span class="n">ucode</span> <span class="n">lid</span><span class="o">.</span> <span class="n">index</span><span class="o">=</span><span class="mi">201</span><span class="n">d1</span>
</pre></div>
</div>
</div></blockquote>
<ul>
<li><p>libflash: Restore blocklevel tests</p>
<p>This fell out in f58be46 “libflash/test: Rewrite Makefile.check to
improve scalability”. Add it back in as test-blocklevel.</p>
</li>
</ul>
<p>Since v6.1:</p>
<ul>
<li><p>pflash: Add –skip option for reading</p>
<p>Add a –skip=N option to pflash to skip N number of bytes when reading.
This would allow users to print the VERSION partition without the STB
header by specifying the –skip=4096 argument, and it’s a more generic
solution rather than making pflash depend on secure/trusted boot code.</p>
</li>
<li><p>xscom-utils: Rework getsram</p>
<p>Allow specifying a file on the command line to read OCC SRAM data into.
If no file is specified then we print it to stdout as text. This is a
bit inconsistent, but it retains compatibility with the existing tool.</p>
</li>
<li><p>xscom-utils/getsram: Make it work on P9</p>
<p>The XSCOM base address of the OCC control registers changed slightly
between P8 and P9. Fix this up and add a bit of PVR checking so we look
in the right place.</p>
</li>
<li><p>opal-prd: Fix opal-prd crash</p>
<p>Presently callback function from HBRT uses r11 to point to target function
pointer. r12 is garbage. This works fine when we compile with “-no-pie” option
(as we don’t use r12 to calculate TOC).</p>
<p>As per ABIv2 : “r12 : Function entry address at global entry point”</p>
<p>With “-pie” compilation option, we have to set r12 to point to global function
entry point. So that we can calculate TOC properly.</p>
<p>Crash log without this patch:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">opal</span><span class="o">-</span><span class="n">prd</span><span class="p">[</span><span class="mi">2864</span><span class="p">]:</span> <span class="n">unhandled</span> <span class="n">signal</span> <span class="mi">11</span> <span class="n">at</span> <span class="mi">0000000000029320</span> <span class="n">nip</span> <span class="mi">00000</span> <span class="mi">00102012830</span> <span class="n">lr</span> <span class="mi">0000000102016890</span> <span class="n">code</span> <span class="mi">1</span>
</pre></div>
</div>
</li>
</ul>
</section>
<section id="development-and-debugging">
<h2>Development and Debugging<a class="headerlink" href="#development-and-debugging" title="Link to this heading"></a></h2>
<p>Since v6.1-rc1:
- Warn on long OPAL calls</p>
<blockquote>
<div><p>Measure entry/exit time for OPAL calls and warn appropriately if the
calls take too long (&gt;100ms gets us a DEBUG log, &gt; 1000ms gets us a
warning).</p>
</div></blockquote>
<p>Since v6.1:</p>
<ul>
<li><p>core/lock: Use try_lock_caller() in lock_caller() to capture owner</p>
<p>Otherwise we can get reports of core/lock.c owning the lock, which is
not helpful when tracking down ownership issues.</p>
</li>
<li><p>core/flash: Emit a warning if Skiboot version doesn’t match</p>
<p>This means you’ll get a warning that you’ve modified skiboot separately
to the rest of the PNOR image, which can be useful in determining what
firmware is actually running on a machine.</p>
</li>
<li><p>gcov: link in ctors* as newer GCC doesn’t group them all</p>
<p>It seems that newer toolchains get us multiple ctors sections to link in
rather than just one. If we discard them (as we were doing), then we
don’t have a working gcov build (and we get the “doesn’t look sane”
warning on boot).</p>
</li>
<li><p>core/flash: Log return code when ffs_init() fails</p>
<p>Knowing the return code is at least better than not knowing the return
code.</p>
</li>
<li><p>gcov: Fix building with GCC8</p></li>
<li><p>travis/ci: rework Dockerfiles to produce build artifacts</p>
<p>ubuntu-latest was also missing clang, as ubuntu-latest is closer to
ubuntu 18.04 than 16.04</p>
</li>
<li><p>cpu: add cpu_queue_job_on_node()</p>
<p>Add a job scheduling API which will run the job on the requested
chip_id (or return failure).</p>
</li>
<li><p>opal-ci: Build old dtc version for fedora 28</p>
<p>There are patches that will go into dtc to fix the issues we hit, but
for the moment let’s just build and use a slightly older version.</p>
</li>
<li><p>mem_region: Merge similar allocations when dumping</p>
<p>Currently we print one line for each allocation done at runtime when
dumping the memory allocations. We do a few thousand allocations at
boot so this can result in a huge amount of text being printed which
is a) slow to print, and b) Can result in the log buffer overflowing
which destroys otherwise useful information.</p>
<p>This patch adds a de-duplication to this memory allocation dump by
merging “similar” allocations (same location, same size) into one.</p>
<p>Unfortunately, the algorithm used to do the de-duplication is quadratic,
but considering we only dump the allocations in the event of a fatal
error I think this is acceptable. I also did some benchmarking and found
that on a ZZ it takes ~3ms to do a dump with 12k allocations. On a Zaius
it’s slightly longer at about ~10ms for 10k allocs. However, the
difference there was due to the output being written to the UART.</p>
<p>This patch also bumps the log level to PR_NOTICE. PR_INFO messages are
suppressed at the default log level, which probably isn’t something you
want considering we only dump the allocations when we run out of skiboot
heap space.</p>
</li>
<li><p>core/lock: fix timeout warning causing a deadlock false positive</p>
<p>If a lock waiter exceeds the warning timeout, it prints a message
while still registered as requesting the lock. Printing the message
can take locks, so if one is held when the owner of the original
lock tries to print a message, it will get a false positive deadlock
detection, which brings down the system.</p>
<p>This can easily be hit when there is a lot of HMI activity from a
KVM guest, where the timebase was not returned to host timebase
before calling the HMI handler.</p>
</li>
<li><p>hw/p8-i2c: Print the set error bits</p>
<p>This is purely to save me from having to look it up every time someone
gets an I2C error.</p>
</li>
<li><p>init: Fix starting stripped kernel</p>
<p>Currently if we try to run a raw/stripped binary kernel (ie. without
the elf header) we crash with:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span>[ 0.008757768,5] INIT: Waiting for kernel...
[ 0.008762937,5] INIT: platform wait for kernel load failed
[ 0.008768171,5] INIT: Assuming kernel at 0x20000000
[ 0.008779241,3] INIT: ELF header not found. Assuming raw binary.
[ 0.017047348,5] INIT: Starting kernel at 0x0, fdt at 0x3044b230 14339 bytes
[ 0.017054251,0] FATAL: Kernel is zeros, can&#39;t execute!
[ 0.017059054,0] Assert fail: core/init.c:590:0
[ 0.017065371,0] Aborting!
</pre></div>
</div>
<p>This is because we haven’t set kernel_entry correctly in this path.
This fixes it.</p>
</li>
<li><p>cpu: Better output when waiting for a very long job</p>
<p>Instead of printing at the end if the job took more than 1s,
print in the loop every 30s along with a backtrace. This will
give us some output if the job is deadlocked.</p>
</li>
<li><p>lock: Fix interactions between lock dependency checker and stack checker</p>
<p>The lock dependency checker does a few nasty things that can cause
re-entrancy deadlocks in conjunction with the stack checker or
in fact other debug tests.</p>
<p>A lot of it revolves around taking a new lock (dl_lock) as part
of the locking process.</p>
<p>This tries to fix it by making sure we do not hit the stack
checker while holding dl_lock.</p>
<p>We achieve that in part by directly using the low-level __try_lock
and manually unlocking on the dl_lock, and making some functions
“nomcount”.</p>
<p>In addition, we mark the dl_lock as being in the console path to
avoid deadlocks with the UART driver.</p>
<p>We move the enabling of the deadlock checker to a separate config
option from DEBUG_LOCKS as well, in case we chose to disable it
by default later on.</p>
</li>
<li><p>xscom-utils/adu_scoms.py: run 2to3 over it</p></li>
<li><p>clang: -Wno-error=ignored-attributes</p></li>
</ul>
</section>
<section id="ci-testing-and-utilities">
<h2>CI, testing, and utilities<a class="headerlink" href="#ci-testing-and-utilities" title="Link to this heading"></a></h2>
<p>Since v6.1-rc2:</p>
<ul>
<li><p>opal-ci: Drop fedora27, add fedora29</p></li>
<li><p>ci: Bump Qemu version</p>
<p>This moves the qemu version to qemu-powernv-for-skiboot-7 which is based
on upstream’s 3.1.0, and supports a Power9 machine.</p>
<p>It also includes a fix for the skiboot XSCOM errors:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">XSCOM</span><span class="p">:</span> <span class="n">read</span> <span class="n">error</span> <span class="n">gcid</span><span class="o">=</span><span class="mh">0x0</span> <span class="n">pcb_addr</span><span class="o">=</span><span class="mh">0x1020013</span> <span class="n">stat</span><span class="o">=</span><span class="mh">0x0</span>
</pre></div>
</div>
<p>There is no modelling of the xscom behaviour but the reads/writes
now succeed which is enough for skiboot to not error out.</p>
</li>
<li><p>test: Update qemu arguments to use bmc simulator</p>
<p>THe qemu skiboot platform as of 8340a9642bba (“plat/qemu: use the common
OpenPOWER routines to initialize”) uses the common aspeed BMC setup
routines. This means a BT interface is always set up, and if the
corresponding Qemu model is not present the timeout is 30 seconds.</p>
<p>It looks like this every time an IPMI message is sent:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">BT</span><span class="p">:</span> <span class="n">seq</span> <span class="mh">0x9e</span> <span class="n">netfn</span> <span class="mh">0x06</span> <span class="n">cmd</span> <span class="mh">0x31</span><span class="p">:</span> <span class="n">Maximum</span> <span class="n">queue</span> <span class="n">length</span> <span class="n">exceeded</span>
<span class="n">BT</span><span class="p">:</span> <span class="n">seq</span> <span class="mh">0x9d</span> <span class="n">netfn</span> <span class="mh">0x06</span> <span class="n">cmd</span> <span class="mh">0x31</span><span class="p">:</span> <span class="n">Removed</span> <span class="kn">from</span> <span class="nn">queue</span>
<span class="n">BT</span><span class="p">:</span> <span class="n">seq</span> <span class="mh">0x9f</span> <span class="n">netfn</span> <span class="mh">0x06</span> <span class="n">cmd</span> <span class="mh">0x31</span><span class="p">:</span> <span class="n">Maximum</span> <span class="n">queue</span> <span class="n">length</span> <span class="n">exceeded</span>
<span class="n">BT</span><span class="p">:</span> <span class="n">seq</span> <span class="mh">0x9e</span> <span class="n">netfn</span> <span class="mh">0x06</span> <span class="n">cmd</span> <span class="mh">0x31</span><span class="p">:</span> <span class="n">Removed</span> <span class="kn">from</span> <span class="nn">queue</span>
<span class="n">BT</span><span class="p">:</span> <span class="n">seq</span> <span class="mh">0xa0</span> <span class="n">netfn</span> <span class="mh">0x06</span> <span class="n">cmd</span> <span class="mh">0x31</span><span class="p">:</span> <span class="n">Maximum</span> <span class="n">queue</span> <span class="n">length</span> <span class="n">exceeded</span>
<span class="n">BT</span><span class="p">:</span> <span class="n">seq</span> <span class="mh">0x9f</span> <span class="n">netfn</span> <span class="mh">0x06</span> <span class="n">cmd</span> <span class="mh">0x31</span><span class="p">:</span> <span class="n">Removed</span> <span class="kn">from</span> <span class="nn">queue</span>
</pre></div>
</div>
<p>Avoid this by adding the bmc simulator model to the Qemu powernv
machine.</p>
</li>
<li><p>ci: Add opal-utils to Debian unstable</p>
<p>This puts a ‘pflash’ in the users PATH, allowing more test coverage of
ffspart.</p>
</li>
<li><p>ci: Drop P8 mambo from Debian unstable</p>
<p>Debian Unstable has removed OpenSSL 1.0.0 from the repository so mambo
no longer runs:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="o">/</span><span class="n">opt</span><span class="o">/</span><span class="n">ibm</span><span class="o">/</span><span class="n">systemsim</span><span class="o">-</span><span class="n">p8</span><span class="o">/</span><span class="nb">bin</span><span class="o">/</span><span class="n">systemsim</span><span class="o">-</span><span class="n">pegasus</span><span class="p">:</span> <span class="n">error</span> <span class="k">while</span> <span class="n">loading</span> <span class="n">shared</span>
<span class="n">libraries</span><span class="p">:</span> <span class="n">libcrypto</span><span class="o">.</span><span class="n">so</span><span class="mf">.1.0.0</span><span class="p">:</span> <span class="n">cannot</span> <span class="nb">open</span> <span class="n">shared</span> <span class="nb">object</span> <span class="n">file</span><span class="p">:</span> <span class="n">No</span> <span class="n">such</span>
<span class="n">file</span> <span class="ow">or</span> <span class="n">directory</span>
</pre></div>
</div>
<p>By removing it from the container these tests will be automatically
skipped.</p>
<p>Tracked in <a class="reference external" href="https://github.com/open-power/op-build/issues/2519">https://github.com/open-power/op-build/issues/2519</a></p>
</li>
<li><p>ci: Add dtc dependencies for rawhide</p>
<p>Both F28 and Rawhide build their own dtc version. Rawhide was missing
the required build deps.</p>
</li>
<li><p>ci: Update Debian unstable packages</p>
<p>This syncs Debian unstable with Ubuntu 18.04 in order to get the clang
package. It also adds qemu to the Debian install, which makes sense
Debian also has 2.12.</p>
</li>
<li><p>ci: Use Ubuntu latest config for Debian unstable</p>
<p>Debian unstable has the same GCOV issue with 8.2 as Ubuntu latest so it
makes sense to share configurations there.</p>
</li>
<li><p>ci: Disable GCOV builds in ubuntu-latest</p>
<p>They are known to be broken with GCC 8.2:
<a class="reference external" href="https://github.com/open-power/skiboot/issues/206">https://github.com/open-power/skiboot/issues/206</a></p>
</li>
<li><p>ci: Update gcov comment in Fedora 28</p></li>
<li><p>plat/qemu: fix platform initialization when the BT device is not present</p>
<p>A QEMU PowerNV machine does not necessarily have a BT device. It needs
to be defined on the command line with :</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="o">-</span><span class="n">device</span> <span class="n">ipmi</span><span class="o">-</span><span class="n">bmc</span><span class="o">-</span><span class="n">sim</span><span class="p">,</span><span class="nb">id</span><span class="o">=</span><span class="n">bmc0</span> <span class="o">-</span><span class="n">device</span> <span class="n">isa</span><span class="o">-</span><span class="n">ipmi</span><span class="o">-</span><span class="n">bt</span><span class="p">,</span><span class="n">bmc</span><span class="o">=</span><span class="n">bmc0</span><span class="p">,</span><span class="n">irq</span><span class="o">=</span><span class="mi">10</span>
</pre></div>
</div>
<p>When the QEMU platform is initialized by skiboot, we need to check
that such a device is present and if not, skip the AST initialization.</p>
</li>
</ul>
<p>Since v6.1-rc1:</p>
<ul>
<li><p>travis: Coverity fixed their SSL cert</p></li>
<li><p>opal-ci: Use ubuntu:rolling for Ubuntu latest image</p></li>
<li><p>ffspart: Add test for eraseblock size</p></li>
<li><p>ffspart: Add toc test</p></li>
<li><p>hdata/test: workaround dtc bugs</p>
<p>In dtc v1.4.5 to at least v1.4.7 there have been a few bugs introduced
that change the layout of what’s produced in the dts. In order to be
immune from them, we should use the (provided) dtdiff utility, but we
also need to run the dts we’re diffing against through a dtb cycle in
order to ensure we get the same format as what the hdat_to_dt to dts
conversion will.</p>
<p>This fixes a bunch of unit test failures on the version of dtc shipped
with recent Linux distros such as Fedora 29.</p>
</li>
</ul>
<section id="mambo-platform">
<h3>Mambo Platform<a class="headerlink" href="#mambo-platform" title="Link to this heading"></a></h3>
<ul>
<li><p>mambo: Merge PMEM_DISK and PMEM_VOLATILE code</p>
<p>PMEM_VOLATILE and PMEM_DISK can’t be used together and are basically
copies of the same code.</p>
<p>This merges the two and allows them used together. Same API is kept.</p>
</li>
<li><p>hw/chiptod: test QUIRK_NO_CHIPTOD in opal_resync_timebase</p>
<p>This allows some test coverage of deep stop states in Linux with
Mambo.</p>
</li>
<li><p>core/mem_region: mambo reserve kernel payload areas</p>
<p>Mambo image payloads get overwritten by the OS and by
fast reboot memory clearing because they have no region
defined. Add them, which allows fast reboot to work.</p>
</li>
</ul>
</section>
<section id="qemu-platform">
<h3>Qemu platform<a class="headerlink" href="#qemu-platform" title="Link to this heading"></a></h3>
<p>Since v6.2-rc2:
- plat/qemu: use the common OpenPOWER routines to initialize</p>
<blockquote>
<div><p>Back in 2016, we did not have a large support of the PowerNV devices
under QEMU and we were using our own custom ones. This has changed and
we can now use all the common init routines of the OpenPOWER
platforms.</p>
</div></blockquote>
<p>Since v6.1:</p>
<ul>
<li><p>nx: Don’t abort on missing NX when using a QEMU machine</p>
<p>These don’t have an NX node (and probably never will) as they
don’t provide any coprocessor. However, the DARN instruction
works so this abort is unnecessary.</p>
</li>
</ul>
</section>
</section>
<section id="power8-platforms">
<h2>POWER8 Platforms<a class="headerlink" href="#power8-platforms" title="Link to this heading"></a></h2>
<ul>
<li><p>SBE-p8: Do all sbe timer update with xscom lock held</p>
<p>Without this, on some P8 platforms, we could (falsely) think the SBE timer
had stalled getting the dreaded “timer stuck” message.</p>
<p>The code was doing the mftb() to set the start of the timeout period while
<em>not</em> holding the lock, so the 1ms timeout started sometime when somebody
else had the xscom lock.</p>
<p>The simple solution is to just do the whole routine holding the xscom lock,
so do it that way.</p>
</li>
</ul>
<section id="vesnin-platform">
<h3>Vesnin Platform<a class="headerlink" href="#vesnin-platform" title="Link to this heading"></a></h3>
<ul>
<li><p>platforms/astbmc/vesnin: Send list of PCI devices to BMC through IPMI</p>
<p>Implements sending a list of installed PCI devices through IPMI protocol.
Each PCI device description is sent as a standalone IPMI message.
A list of devices can be gathered from separate messages using the
session identifier. The session Id is an incremental counter that is
updated at the start of synchronization session.</p>
</li>
</ul>
</section>
</section>
<section id="power9-platforms">
<h2>POWER9 Platforms<a class="headerlink" href="#power9-platforms" title="Link to this heading"></a></h2>
<ul>
<li><p>STOP API: API conditionally supports 255 SCOM restore entries for each quad.</p></li>
<li><p>hdata/i2c: Skip unknown device type</p>
<p>Do not add unknown I2C devices to device tree.</p>
</li>
<li><p>hdata/i2c: Add whitelisting for Host I2C devices</p>
<p>Many of the devices that we get information about through HDAT are for
use by firmware rather than the host operating system. This patch adds
a boolean flag to hdat_i2c_info structure that indicates whether devices
with a given purpose should be reserved for use inside of OPAL (or some
other firmware component, such as the OCC).</p>
</li>
<li><p>hdata/iohub: Fix Cumulus Hub ID number</p></li>
<li><p>opal/hmi: Wakeup the cpu before reading core_fir</p>
<p>When stop state 5 is enabled, reading the core_fir during an HMI can
result in a xscom read error with xscom_read() returning an
OPAL_XSCOM_PARTIAL_GOOD error code and core_fir value of all FFs. At
present this return error code is not handled in decode_core_fir()
hence the invalid core_fir value is sent to the kernel where it
interprets it as a FATAL hmi causing a system check-stop.</p>
<p>This can be prevented by forcing the core to wake-up using before
reading the core_fir. Hence this patch wraps the call to
read_core_fir() within calls to dctl_set_special_wakeup() and
dctl_clear_special_wakeup().</p>
</li>
<li><p>xive: Disable block tracker</p>
<p>Due to some HW errata, the block tracking facility (performance optimisation
for large systems) should be disabled on Nimbus chips. Disable it unconditionally
for now.</p>
</li>
<li><p>opal/hmi: Ignore debug trigger inject core FIR.</p>
<p>Core FIR[60] is a side effect of the work around for the CI Vector Load
issue in DD2.1. Usually this gets delivered as HMI with HMER[17] where
Linux already ignores it. But it looks like in some cases we may happen
to see CORE_FIR[60] while we are already in Malfunction Alert HMI
(HMER[0]) due to other reasons e.g. CAPI recovery or NPU xstop. If that
happens then just ignore it instead of crashing kernel as not recoverable.</p>
</li>
<li><p>hdata: Make sure reserved node name starts with “ibm, “</p>
<p>HDAT does not provide consistent label format for reserved memory label.
Few starts with “ibm,” while few other starts with component name.</p>
</li>
<li><p>hdata: Fix dtc warnings</p>
<p>Fix dtc warnings related to mcbist node.</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="ne">Warning</span> <span class="p">(</span><span class="n">reg_format</span><span class="p">):</span> <span class="s2">&quot;reg&quot;</span> <span class="nb">property</span> <span class="ow">in</span> <span class="o">/</span><span class="n">xscom</span><span class="o">@</span><span class="mi">623</span><span class="n">fc00000000</span><span class="o">/</span><span class="n">mcbist</span><span class="o">@</span><span class="mi">1</span> <span class="n">has</span> <span class="n">invalid</span> <span class="n">length</span> <span class="p">(</span><span class="mi">4</span> <span class="nb">bytes</span><span class="p">)</span> <span class="p">(</span><span class="c1">#address-cells == 1, #size-cells == 1)</span>
<span class="ne">Warning</span> <span class="p">(</span><span class="n">reg_format</span><span class="p">):</span> <span class="s2">&quot;reg&quot;</span> <span class="nb">property</span> <span class="ow">in</span> <span class="o">/</span><span class="n">xscom</span><span class="o">@</span><span class="mi">623</span><span class="n">fc00000000</span><span class="o">/</span><span class="n">mcbist</span><span class="o">@</span><span class="mi">2</span> <span class="n">has</span> <span class="n">invalid</span> <span class="n">length</span> <span class="p">(</span><span class="mi">4</span> <span class="nb">bytes</span><span class="p">)</span> <span class="p">(</span><span class="c1">#address-cells == 1, #size-cells == 1)</span>
<span class="ne">Warning</span> <span class="p">(</span><span class="n">reg_format</span><span class="p">):</span> <span class="s2">&quot;reg&quot;</span> <span class="nb">property</span> <span class="ow">in</span> <span class="o">/</span><span class="n">xscom</span><span class="o">@</span><span class="mi">603</span><span class="n">fc00000000</span><span class="o">/</span><span class="n">mcbist</span><span class="o">@</span><span class="mi">1</span> <span class="n">has</span> <span class="n">invalid</span> <span class="n">length</span> <span class="p">(</span><span class="mi">4</span> <span class="nb">bytes</span><span class="p">)</span> <span class="p">(</span><span class="c1">#address-cells == 1, #size-cells == 1)</span>
<span class="ne">Warning</span> <span class="p">(</span><span class="n">reg_format</span><span class="p">):</span> <span class="s2">&quot;reg&quot;</span> <span class="nb">property</span> <span class="ow">in</span> <span class="o">/</span><span class="n">xscom</span><span class="o">@</span><span class="mi">603</span><span class="n">fc00000000</span><span class="o">/</span><span class="n">mcbist</span><span class="o">@</span><span class="mi">2</span> <span class="n">has</span> <span class="n">invalid</span> <span class="n">length</span> <span class="p">(</span><span class="mi">4</span> <span class="nb">bytes</span><span class="p">)</span> <span class="p">(</span><span class="c1">#address-cells == 1, #size-cells == 1)</span>
</pre></div>
</div>
<p>Ideally we should add proper xscom range here… but we are not getting that
information in HDAT today. Lets fix warning until we get proper data in HDAT.</p>
</li>
</ul>
<section id="phb4">
<h3>PHB4<a class="headerlink" href="#phb4" title="Link to this heading"></a></h3>
<ul>
<li><p>phb4: Generate checkstop on AIB ECC corr/uncorr for DD2.0 parts</p>
<p>On DD2.0 parts, PCIe ECC protection is not warranted in the response
data path. Thus, for these parts, we need to flag any ECC errors
detected from the adjacent AIB RX Data path so the part can be
replaced.</p>
<p>This patch configures the FIRs so that we escalate these AIB ECC
errors to a checkstop so the parts can be replaced.</p>
</li>
<li><p>phb4: Reset pfir and nfir if new errors reported during ETU reset</p>
<p>During fast-reboot new PEC errors can be latched even after ETU-Reset
is asserted. This will result in values of variables nfir_cache and
pfir_cache to be out of sync.</p>
<p>During step-2 of CRESET nfir_cache and pfir_cache values are used to
bring the PHB out of reset state. However if these variables are out
as noted above of date the nfir/pfir registers are never reset
completely and ETU still remains frozen.</p>
<p>Hence this patch updates step-2 of phb4_creset to re-read the values of
nfir/pfir registers to check if any new errors were reported after
ETU-reset was asserted, report these new errors and reset the
nfir/pfir registers. This should bring the ETU out of reset
successfully.</p>
</li>
<li><p>phb4: Disable nodal scoped DMA accesses when PB pump mode is enabled</p>
<p>By default when a PCIe device issues a read request via the PHB it is first
issued with nodal scope. When accessing GPU memory the NPU does not know at the
time of response if the requested memory page is off node or not. Therefore
every read of GPU memory by a PHB is retried with larger scope which introduces
bandwidth and latency issues.</p>
<p>On smaller boxes which have pump mode enabled nodal and group scoped reads are
treated the same and both types of request are broadcast to one chip. Therefore
we can avoid the retry by disabling nodal scope on the PHB for these boxes. On
larger boxes nodal (single chip) and group (multiple chip) scoped reads are
treated differently. Therefore we avoid disabling nodal scope on large boxes
which have pump mode disabled to avoid all PHB requests being broadcast to
multiple chips.</p>
</li>
<li><p>phb4/capp: Only reset FIR bits that cause capp machine check</p>
<p>During CAPP recovery do_capp_recovery_scoms() will reset the CAPP Fir
register just after CAPP recovery is completed. This has an
unintentional side effect of preventing PRD from analyzing and
reporting this error. If PRD tries to read the CAPP FIR after opal has
already reset it, then it logs a critical error complaining “No active
error bits found”.</p>
<p>To prevent this from happening we update do_capp_recovery_scoms() to
only reset fir bits that cause CAPP machine check (local xstop). This
is done by reading the CAPP Fir Action0/1 &amp; Mask registers and
generating a mask which is then written on CAPP_FIR_CLEAR register.</p>
</li>
<li><p>phb4: Check for RX errors after link training</p>
<p>Some PHB4 PHYs can get stuck in a bad state where they are constantly
retraining the link. This happens transparently to skiboot and Linux
but will causes PCIe to be slow. Resetting the PHB4 clears the
problem.</p>
<p>We can detect this case by looking at the RX errors count where we
check for link stability. This patch does this by modifying the link
optimal code to check for RX errors. If errors are occurring we
retrain the link irrespective of the chip rev or card.</p>
<p>Normally when this problem occurs, the RX error count is maxed out at
255. When there is no problem, the count is 0. We chose 8 as the max
rx errors value to give us some margin for a few errors. There is also
a knob that can be used to set the error threshold for when we should
retrain the link. ie</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">nvram</span> <span class="o">-</span><span class="n">p</span> <span class="n">ibm</span><span class="p">,</span><span class="n">skiboot</span> <span class="o">--</span><span class="n">update</span><span class="o">-</span><span class="n">config</span> <span class="n">phb</span><span class="o">-</span><span class="n">rx</span><span class="o">-</span><span class="n">err</span><span class="o">-</span><span class="nb">max</span><span class="o">=</span><span class="mi">8</span>
</pre></div>
</div>
</li>
<li><p>hw/phb4: Add a helper to dump the PELT-V</p>
<p>The “Partitionable Endpoint Lookup Table (Vector)” is used by the PHB
when processing EEH events. The PELT-V defines which PEs should be
additionally frozen in the event of an error being flagged on a
given PE. Knowing the state of the PELT-V is sometimes useful for
debugging PHB issues so this patch adds a helper to dump it.</p>
</li>
<li><p>hw/phb4: Print the PEs in the EEH dump in hex</p>
<p>Linux always displays the PE number in hexidecimal while skiboot
displays the PEST index (PE number) in decimal. This makes correlating
errors between Skiboot and Linux more annoying than it should be so
this patch makes Skiboot print the PEST number in hex.</p>
</li>
<li><p>phb4: Reallocate PEC2 DMA-Read engines to improve GPU-Direct bandwidth</p>
<p>We reallocate additional 16/8 DMA-Read engines allocated to stack0/1
on PEC2 respectively. This is needed to improve bandwidth available to
the Mellanox CX5 adapter when trying to read GPU memory (GPU-Direct).</p>
<p>If kernel cxl driver indicates a request to allocate maximum possible
DMA read engines when calling enable_capi_mode() and card is attached
to PEC2/stack0 slot then we assume its a Mellanox CX5 adapter. We then
allocate additional 16/8 extra DMA read engines to stack0 and stack1
respectively on PEC2. This is done by populating the
XPEC_PCI_PRDSTKOVR and XPEC_NEST_READ_STACK_OVERRIDE as suggested by
the h/w team.</p>
</li>
<li><p>phb4: Enable PHB MMIO-0/1 Bars only when mmio window exists</p>
<p>Presently phb4_probe_stack() will always enable PHB MMIO0/1 windows
even if they doesn’t exist in phy_map. Hence we do some minor shuffling
in the phb4_probe_stack() so that MMIO-0/1 Bars are only enabled if
there corresponding MMIO window exists in the phy_map. In case phy_map
for an mmio window is ‘0’ we set the corresponding BAR register to
‘0’.</p>
</li>
<li><p>hw/phb4: Use local_alloc for phb4 structures</p>
<p>Struct phb4 is fairly heavyweight at 283664 bytes. On systems with
6x PHBs per socket this results in using 3.2MB of heap space the PHB
structures alone. This is a fairly large chunk of our 12MB heap and
on systems with particularly large PCIe topologies, or additional
PHBs we can fail to boot because we cannot allocate space for the
FDT blob.</p>
<p>This patch switches to using local_alloc() for the PHB structures
so they don’t consume too large a portion of our 12MB heap space.</p>
</li>
<li><p>phb4: Fix typo in disable lane eq code</p>
<p>In this commit</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">commit</span> <span class="mi">737</span><span class="n">c0ba3d72b8aab05a765a9fc111a48faac0f75</span>
<span class="n">Author</span><span class="p">:</span> <span class="n">Michael</span> <span class="n">Neuling</span> <span class="o">&lt;</span><span class="n">mikey</span><span class="nd">@neuling</span><span class="o">.</span><span class="n">org</span><span class="o">&gt;</span>
<span class="n">Date</span><span class="p">:</span> <span class="n">Thu</span> <span class="n">Feb</span> <span class="mi">22</span> <span class="mi">10</span><span class="p">:</span><span class="mi">52</span><span class="p">:</span><span class="mi">18</span> <span class="mi">2018</span> <span class="o">+</span><span class="mi">1100</span>
<span class="n">phb4</span><span class="p">:</span> <span class="n">Disable</span> <span class="n">lane</span> <span class="n">eq</span> <span class="n">when</span> <span class="n">retrying</span> <span class="n">some</span> <span class="n">nvidia</span> <span class="n">GEN3</span> <span class="n">devices</span>
</pre></div>
</div>
<p>We made a typo and set PH2 twice. This fixes it.</p>
<p>It worked previously as if only phase 2 (PH2) is set it, skips phase 2
and phase 3 (PH3).</p>
</li>
<li><p>phb4: Don’t probe a PHB if its garded</p>
<p>Presently phb4_probe_stack() causes an exception while trying to probe
a PHB if its garded. This causes skiboot to go into a reboot loop with
following exception log:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span> ***********************************************
Fatal MCE at 000000003006ecd4 .probe_phb4+0x570
CFAR : 00000000300b98a0
&lt;snip&gt;
Aborting!
CPU 0018 Backtrace:
S: 0000000031cc37e0 R: 000000003001a51c ._abort+0x4c
S: 0000000031cc3860 R: 0000000030028170 .exception_entry+0x180
S: 0000000031cc3a40 R: 0000000000001f10 *
S: 0000000031cc3c20 R: 000000003006ecb0 .probe_phb4+0x54c
S: 0000000031cc3e30 R: 0000000030014ca4 .main_cpu_entry+0x5b0
S: 0000000031cc3f00 R: 0000000030002700 boot_entry+0x1b8
</pre></div>
</div>
<p>This is caused as phb4_probe_stack() will ignore all xscom read/write
errors to enable PHB Bars and then tries to perform an mmio to read
PHB Version registers that cause the fatal MCE.</p>
<p>We fix this by ignoring the PHB probe if the first xscom_write() to
populate the PHB Bar register fails, which indicates that there is
something wrong with the PHB.</p>
</li>
<li><p>phb4: Workaround PHB errata with CFG write UR/CA errors</p>
<p>If the PHB encounters a UR or CA status on a CFG write, it will
incorrectly freeze the wrong PE. Instead of using the PE# specified
in the CONFIG_ADDRESS register, it will use the PE# of whatever
MMIO occurred last.</p>
<p>Work around this disabling freeze on such errors</p>
</li>
<li><p>phb4: Handle allocation errors in phb4_eeh_dump_regs()</p>
<p>If the zalloc fails (and it can be a rather large allocation),
we will overwite memory at 0 instead of failing.</p>
</li>
<li><p>phb4: Don’t try to access non-existent PEST entries</p>
<p>In a POWER9 chip, some PHB4s have 256 PEs, some have 512.</p>
<p>Currently, the diagnostics code retrieves 512 unconditionally,
which is wrong and causes us to incorrectly report bogus values
for the “high” PEs on the small PHBs.</p>
<p>Use the actual number of implemented PEs instead</p>
</li>
</ul>
</section>
<section id="capi2">
<h3>CAPI2<a class="headerlink" href="#capi2" title="Link to this heading"></a></h3>
<ul>
<li><p>phb4/capp: Use link width to allocate STQ engines to CAPP</p>
<p>Update phb4_init_capp_regs() to allocates STQ Engines to CAPP/PEC2
based on link width instead of always assuming it to x8.</p>
<p>Also re-factor the function slightly to evaluate the link-width only
once and cache it so that it can also be used to allocate DMA read
engines.</p>
</li>
<li><p>phb4/capp: Update DMA read engines set in APC_FSM_READ_MASK based on link-width</p>
<p>Commit 47c09cdfe7a3(“phb4/capp: Calculate STQ/DMA read engines based
on link-width for PEC”) update the CAPP init sequence by calculating
the needed STQ/DMA-read engines based on link width and populating it
in XPEC_NEST_CAPP_CNTL register. This however needs to be synchronized
with the value set in CAPP APC FSM Read Machine Mask Register.</p>
<p>Hence this patch update phb4_init_capp_regs() to calculate the link
width of the stack on PEC2 and populate the same values as previously
populated in PEC CAPP_CNTL register.</p>
</li>
<li><p>capp: Fix the capp recovery timeout comparison</p>
<p>The current capp recovery timeout control loop in
do_capp_recovery_scoms() uses a wrong comparison for return value of
tb_compare(). This may cause do_capp_recovery_scoms() to report an
timeout earlier than the 168ms stipulated time.</p>
<p>The patch fixes this by updating the loop timeout control branch in
do_capp_recovery_scoms() to use the correct enum tb_cmpval.</p>
</li>
<li><p>phb4: Disable 32-bit MSI in capi mode</p>
<p>If a capi device does a DMA write targeting an address lower than 4GB,
it does so through a 32-bit operation, per the PCI spec. In capi mode,
the first TVE entry is configured in bypass mode, so the address is
valid. But with any (bad) luck, the address could be 0xFFFFxxxx, thus
looking like a 32-bit MSI.</p>
<p>We currently enable both 32-bit and 64-bit MSIs, so the PHB will
interpret the DMA write as a MSI, which very likely results in an EEH
(MSI with a bad payload size).</p>
<p>We can fix it by disabling 32-bit MSI when switching the PHB to capi
mode. Capi devices are 64-bit.</p>
</li>
</ul>
</section>
<section id="nvlink2">
<h3>NVLINK2<a class="headerlink" href="#nvlink2" title="Link to this heading"></a></h3>
<p>Since v6.2-rc2:
- Add purging CPU L2 and L3 caches into NPU hreset.</p>
<blockquote>
<div><p>If a GPU is passed through to a guest and the guest unexpectedly terminates,
there can be cache lines in CPUs that belong to the GPU. So purge the caches
as part of the reset sequence. L1 is write through, so doesn’t need to be purged.</p>
<p>The sequence to purge the L2 and L3 caches from the hw team:</p>
<p>L2 purge:
1. initiate purge</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">putspy</span> <span class="n">pu</span><span class="o">.</span><span class="n">ex</span> <span class="n">EXP</span><span class="o">.</span><span class="n">L2</span><span class="o">.</span><span class="n">L2MISC</span><span class="o">.</span><span class="n">L2CERRS</span><span class="o">.</span><span class="n">PRD_PURGE_CMD_TYPE</span> <span class="n">L2CAC_FLUSH</span> <span class="o">-</span><span class="nb">all</span>
<span class="n">putspy</span> <span class="n">pu</span><span class="o">.</span><span class="n">ex</span> <span class="n">EXP</span><span class="o">.</span><span class="n">L2</span><span class="o">.</span><span class="n">L2MISC</span><span class="o">.</span><span class="n">L2CERRS</span><span class="o">.</span><span class="n">PRD_PURGE_CMD_TRIGGER</span> <span class="n">ON</span> <span class="o">-</span><span class="nb">all</span>
</pre></div>
</div>
<ol class="arabic" start="2">
<li><p>check this is off in all caches to know purge completed</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">getspy</span> <span class="n">pu</span><span class="o">.</span><span class="n">ex</span> <span class="n">EXP</span><span class="o">.</span><span class="n">L2</span><span class="o">.</span><span class="n">L2MISC</span><span class="o">.</span><span class="n">L2CERRS</span><span class="o">.</span><span class="n">PRD_PURGE_CMD_REG_BUSY</span> <span class="o">-</span><span class="nb">all</span>
</pre></div>
</div>
</li>
<li><div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">putspy</span> <span class="n">pu</span><span class="o">.</span><span class="n">ex</span> <span class="n">EXP</span><span class="o">.</span><span class="n">L2</span><span class="o">.</span><span class="n">L2MISC</span><span class="o">.</span><span class="n">L2CERRS</span><span class="o">.</span><span class="n">PRD_PURGE_CMD_TRIGGER</span> <span class="n">OFF</span> <span class="o">-</span><span class="nb">all</span>
</pre></div>
</div>
</li>
</ol>
<p>L3 purge:
1. Start the purge:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">putspy</span> <span class="n">pu</span><span class="o">.</span><span class="n">ex</span> <span class="n">EXP</span><span class="o">.</span><span class="n">L3</span><span class="o">.</span><span class="n">L3_MISC</span><span class="o">.</span><span class="n">L3CERRS</span><span class="o">.</span><span class="n">L3_PRD_PURGE_TTYPE</span> <span class="n">FULL_PURGE</span> <span class="o">-</span><span class="nb">all</span>
<span class="n">putspy</span> <span class="n">pu</span><span class="o">.</span><span class="n">ex</span> <span class="n">EXP</span><span class="o">.</span><span class="n">L3</span><span class="o">.</span><span class="n">L3_MISC</span><span class="o">.</span><span class="n">L3CERRS</span><span class="o">.</span><span class="n">L3_PRD_PURGE_REQ</span> <span class="n">ON</span> <span class="o">-</span><span class="nb">all</span>
</pre></div>
</div>
<ol class="arabic" start="2">
<li><p>Ensure that the purge has completed by checking the status bit:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">getspy</span> <span class="n">pu</span><span class="o">.</span><span class="n">ex</span> <span class="n">EXP</span><span class="o">.</span><span class="n">L3</span><span class="o">.</span><span class="n">L3_MISC</span><span class="o">.</span><span class="n">L3CERRS</span><span class="o">.</span><span class="n">L3_PRD_PURGE_REQ</span> <span class="o">-</span><span class="nb">all</span>
</pre></div>
</div>
<p>You should see it say OFF if it’s done:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">p9n</span><span class="o">.</span><span class="n">ex</span> <span class="n">k0</span><span class="p">:</span><span class="n">n0</span><span class="p">:</span><span class="n">s0</span><span class="p">:</span><span class="n">p00</span><span class="p">:</span><span class="n">c0</span>
<span class="n">EXP</span><span class="o">.</span><span class="n">L3</span><span class="o">.</span><span class="n">L3_MISC</span><span class="o">.</span><span class="n">L3CERRS</span><span class="o">.</span><span class="n">L3_PRD_PURGE_REQ</span>
<span class="n">OFF</span>
</pre></div>
</div>
</li>
</ol>
</div></blockquote>
<ul>
<li><p>npu2: Return sensible PCI error when not frozen</p>
<p>The current kernel calls OPAL_PCI_EEH_FREEZE_STATUS with an uninitialized
&#64;pci_error_type parameter and then analyzes it even if the OPAL call
returned OPAL_SUCCESS. This is results in unexpected EEH events and NPU
freezes.</p>
<p>This initializes &#64;pci_error_type and &#64;severity to known safe values.</p>
</li>
<li><p>npu2: Advertise correct TCE page size</p>
<p>The P9 NPU workbook says that only 4K/64K/16M/256M page size are supported
and in fact npu2_map_pe_dma_window() supports just these but in absence of
the “ibm,supported-tce-sizes” property Linux assumes the default P9 PHB4
page sizes - 4K/64K/2M/1G - so when Linux tries 2M/1G TCEs, we get lots of
“Unexpected TCE size” from npu2_tce_kill().</p>
<p>This advertises TCE page sizes so Linux could handle it correctly, i.e.
fall back to 4K/64K TCEs.</p>
</li>
</ul>
<p>Since v6.1:</p>
<ul>
<li><p>npu2: Add support for relaxed-ordering mode</p>
<p>Some device drivers support out of order access to GPU memory. This does
not affect the CPU view of memory but it does affect the GPU view of
memory. It should only be enabled if the GPU driver has requested it.</p>
<p>Add OPAL APIs allowing the driver to query relaxed ordering state or
request it to be set for a device. Current hardware only allows relaxed
ordering to be enabled per PCIe root port. So the code here doesn’t
enable relaxed ordering until it has been explicitly requested for every
device on the port.</p>
</li>
<li><p>Add the other 7 ATSD registers to the device tree.</p></li>
<li><p>npu2/hw-procedures: Don’t open code NPU2_NTL_MISC_CFG2_BRICK_ENABLE</p>
<p>Name this bit properly. There’s a lot more cleanup like this to be done,
but I’m catching this one now as part of some related changes.</p>
</li>
<li><p>npu2/hw-procedures: Enable parity and credit overflow checks</p>
<p>Enable these error checking features by setting the appropriate bits in
our one-off initialization of each “NTL Misc Config 2” register.</p>
<p>The exception is NDL RX parity checking, which should be disabled during
the link training procedures.</p>
</li>
<li><p>npu2: Use correct kill type for TCE invalidation</p>
<p>kill_type is enum of OPAL_PCI_TCE_KILL_PAGES, OPAL_PCI_TCE_KILL_PE,
OPAL_PCI_TCE_KILL_ALL and phb4_tce_kill() gets it right but
npu2_tce_kill() uses OPAL_PCI_TCE_KILL which is an OPAL API token.</p>
<p>This fixes an obvious mistype.</p>
</li>
</ul>
</section>
<section id="opencapi">
<h3>OpenCAPI<a class="headerlink" href="#opencapi" title="Link to this heading"></a></h3>
<p>Since v6.2-rc1:</p>
<ul class="simple">
<li><p>npu2-opencapi: Log extra information on link training failure</p></li>
<li><p>npu2-opencapi: Detect if link trained in degraded mode</p></li>
</ul>
<p>Since v6.1:</p>
<ul>
<li><p>Support OpenCAPI on Witherspoon platform</p></li>
<li><p>npu2-opencapi: Enable presence detection on ZZ</p>
<p>Presence detection for opencapi adapters was broken for ZZ planars v3
and below. All ZZ systems currently used in the lab have had their
planar upgraded, so we can now remove the override we had to force
presence and activate presence detection. Which should improve boot
time.</p>
<p>Considering the state of opal support on ZZ, this is really only for
lab usage on BML. The opencapi enablement team has okay’d the
change. In the unlikely case somebody tries opencapi on an old ZZ, the
presence detection through i2c will show that no adapter is present
and skiboot won’t try to access or train the link.</p>
</li>
<li><p>npu2-opencapi: Don’t send commands to NPU when link is down</p>
<p>Even if an opencapi link is down, we currently always try to issue a
config read operation when probing for PCI devices, because of the
default scan map used for an opencapi PHB. The config operation fails,
as expected, but it can also raise a FIR bit and trigger an HMI.</p>
<p>For opencapi, there’s no root device like for a “normal” PCI PHB, so
there’s no reason to do the config operation. To fix it, we keep the
scan map blank by default, and only add a device once the link is
trained.</p>
</li>
<li><p>opal/hmi: Catch NPU2 HMIs for opencapi</p>
<p>HMIs for NPU2 are filtered with the ‘compatible’ string of the PHB, so
add opencapi to the mix.</p>
</li>
<li><p>occ: Wait if OCC GPU presence status not immediately available</p>
<p>It takes a few seconds for the OCC to set everything up in order to read
GPU presence. At present, we try to kick off OCC initialisation as early as
possible to maximise the time it has to read GPU presence.</p>
<p>Unfortunately sometimes that’s not enough, so add a loop in
occ_get_gpu_presence() so that on the first time we try to get GPU presence
we keep trying for up to 2 seconds. Experimentally this seems to be
adequate.</p>
</li>
<li><p>hw/npu2-hw-procedures: Enable RX auto recal on OpenCAPI links</p>
<p>The RX_RC_ENABLE_AUTO_RECAL flag is required on OpenCAPI but not NVLink.</p>
<p>Traditionally, Hostboot sets this value according to the machine type.
However, now that Witherspoon supports both NVLink and OpenCAPI, it can’t
tell whether or not a link is OpenCAPI.</p>
<p>So instead, set it in skiboot, where it will only be triggered after we’ve
done device detection and found an OpenCAPI device.</p>
</li>
<li><p>hw/npu2-opencapi: Fix setting of supported OpenCAPI templates</p>
<p>In opal_npu_tl_set(), we made a typo that means the OPAL_NPU_TL_SET call
may not clear the enable bits for templates that were previously enabled
but are now disabled.</p>
<p>Fix the typo so we clear NPU2_OTL_CONFIG1_TX_TEMP2_EN as well as
TEMP{1,3}_EN.</p>
</li>
</ul>
</section>
<section id="barreleye-g2-and-zaius-platforms">
<h3>Barreleye G2 and Zaius platforms<a class="headerlink" href="#barreleye-g2-and-zaius-platforms" title="Link to this heading"></a></h3>
<ul>
<li><p>zaius: Add a slot table</p></li>
<li><p>zaius: Add slots for the Barreleye G2 HDD rack</p>
<p>The Barreleye G2 is distinct from the Zaius in that it features a 24
Bay NVMe/SATA HDD rack. To provide meaningful slot names for each NVMe
device we need to define a slot table for the NVMe capable HDD bays.</p>
<p>Unfortunately this isn’t straightforward because the PCIe path to the
NVMe devices isn’t fixed. The PCIe topology is something like:
P9 -&gt; HBA card -&gt; 9797 switch -&gt; 20x NVMe HDD slots</p>
<p>The 9797 switch is partitioned into two (or four) virtual switches which
allow multiple HBA cards to be used (e.g. one per socket). As a result
the exact BDFN of the ports will vary depending on how the system is
configured.</p>
<p>That said, the virtual switch configuration of the 9797 does not change
the device and function numbers of the switch downports. This means that
we can define a single slot table that maps switch ports to the NVMe bay
names.</p>
<p>Unfortunately we still need to guess which bus to use this table on, so
we assume that any switch downport we find with the PEX9797 VDID is part
of the 9797 that supports the HDD rack.</p>
</li>
</ul>
</section>
<section id="fsp-based-platforms-firenze-and-zz">
<h3>FSP based platforms (firenze and ZZ)<a class="headerlink" href="#fsp-based-platforms-firenze-and-zz" title="Link to this heading"></a></h3>
<p>Since v6.2-rc1:
- platform/firenze: Fix branch-to-null crash</p>
<blockquote>
<div><p>When the bus alloc and free methods were removed we missed a case in the
Firenze platform slot code that relied on the the bus-specific method to
the bus pointer in the request structure. This results in a
branch-to-null during boot and a crash. This patch fixes it by
initialising it manually here.</p>
</div></blockquote>
<p>Since v6.1:</p>
<ul>
<li><p>phb4/capp: Update the expected Eye-catcher for CAPP ucode lid</p>
<p>Currently on a FSP based P9 system load_capp_code() expects CAPP ucode
lid header to have eye-catcher magic of ‘CAPPPSLL’. However skiboot
currently supports CAPP ucode only lids that have a eye-catcher magic
of ‘CAPPLIDH’. This prevents skiboot from loading the ucode with this
error message:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">CAPP</span><span class="p">:</span> <span class="n">ucode</span> <span class="n">header</span> <span class="n">invalid</span>
</pre></div>
</div>
<p>We fix this issue by updating load_capp_ucode() to use the eye-catcher
value of ‘CAPPLIDH’ instead of ‘CAPPPSLL’.</p>
</li>
<li><p>FSP: Improve Reset/Reload log message</p>
<p>Below message is confusing. Lets make it clear.</p>
<p>FSP sends “R/R complete notification” whenever there is a dump. We use <cite>flag</cite>
to identify whether its its R/R completion -OR- just new dump notification.</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="p">[</span> <span class="mf">483.406351956</span><span class="p">,</span><span class="mi">6</span><span class="p">]</span> <span class="n">FSP</span><span class="p">:</span> <span class="n">SP</span> <span class="n">says</span> <span class="n">Reset</span><span class="o">/</span><span class="n">Reload</span> <span class="n">complete</span>
<span class="p">[</span> <span class="mf">483.406354278</span><span class="p">,</span><span class="mi">5</span><span class="p">]</span> <span class="n">DUMP</span><span class="p">:</span> <span class="n">FipS</span> <span class="n">dump</span> <span class="n">available</span><span class="o">.</span> <span class="n">ID</span> <span class="o">=</span> <span class="mh">0x1a00001f</span> <span class="p">[</span><span class="n">size</span><span class="p">:</span> <span class="mi">6367640</span> <span class="nb">bytes</span><span class="p">]</span>
<span class="p">[</span> <span class="mf">483.406355968</span><span class="p">,</span><span class="mi">7</span><span class="p">]</span> <span class="n">A</span> <span class="n">Reset</span><span class="o">/</span><span class="n">Reload</span> <span class="n">was</span> <span class="n">NOT</span> <span class="n">done</span>
</pre></div>
</div>
</li>
</ul>
</section>
<section id="witherspoon-platform">
<h3>Witherspoon platform<a class="headerlink" href="#witherspoon-platform" title="Link to this heading"></a></h3>
<ul>
<li><p>platforms/astbmc/witherspoon: Implement OpenCAPI support</p>
<p>OpenCAPI on Witherspoon is slightly more involved than on Zaius and ZZ, due
to the OpenCAPI links using the SXM2 connectors that are used for NVLink
GPUs.</p>
<p>This patch adds the regular OpenCAPI platform information, and also a
Witherspoon-specific presence detection callback that uses the previously
added OCC GPU presence detection to figure out the device types plugged
into each SXM2 socket.</p>
<p>The SXM2 connectors are capable of carrying 2 OpenCAPI links, and future
OpenCAPI devices are expected to make use of this. However, we don’t yet
support ganged links and the various implications that has for handling
things like device reset, so for now, we only enable 1 brick per device.</p>
</li>
</ul>
</section>
</section>
<section id="contributors">
<h2>Contributors<a class="headerlink" href="#contributors" title="Link to this heading"></a></h2>
<p>The v6.2 release of skiboot contains 240 changesets from 28 developers, working for 2 employers.
A total of 9146 lines were added, and 2610 removed (delta 6536).</p>
<section id="developers-with-the-most-changesets">
<h3>Developers with the most changesets<a class="headerlink" href="#developers-with-the-most-changesets" title="Link to this heading"></a></h3>
<table class="docutils align-default">
<thead>
<tr class="row-odd"><th class="head"><p>Developer</p></th>
<th class="head"><p>#</p></th>
<th class="head"><p>%</p></th>
</tr>
</thead>
<tbody>
<tr class="row-even"><td><p>Stewart Smith</p></td>
<td><p>58</p></td>
<td><p>(24.2%)</p></td>
</tr>
<tr class="row-odd"><td><p>Andrew Jeffery</p></td>
<td><p>30</p></td>
<td><p>(12.5%)</p></td>
</tr>
<tr class="row-even"><td><p>Oliver O’Halloran</p></td>
<td><p>27</p></td>
<td><p>(11.2%)</p></td>
</tr>
<tr class="row-odd"><td><p>Joel Stanley</p></td>
<td><p>17</p></td>
<td><p>(7.1%)</p></td>
</tr>
<tr class="row-even"><td><p>Vaibhav Jain</p></td>
<td><p>14</p></td>
<td><p>(5.8%)</p></td>
</tr>
<tr class="row-odd"><td><p>Benjamin Herrenschmidt</p></td>
<td><p>12</p></td>
<td><p>(5.0%)</p></td>
</tr>
<tr class="row-even"><td><p>Frederic Barrat</p></td>
<td><p>11</p></td>
<td><p>(4.6%)</p></td>
</tr>
<tr class="row-odd"><td><p>Nicholas Piggin</p></td>
<td><p>11</p></td>
<td><p>(4.6%)</p></td>
</tr>
<tr class="row-even"><td><p>Andrew Donnellan</p></td>
<td><p>10</p></td>
<td><p>(4.2%)</p></td>
</tr>
<tr class="row-odd"><td><p>Vasant Hegde</p></td>
<td><p>9</p></td>
<td><p>(3.8%)</p></td>
</tr>
<tr class="row-even"><td><p>Reza Arbab</p></td>
<td><p>8</p></td>
<td><p>(3.3%)</p></td>
</tr>
<tr class="row-odd"><td><p>Samuel Mendoza-Jonas</p></td>
<td><p>5</p></td>
<td><p>(2.1%)</p></td>
</tr>
<tr class="row-even"><td><p>Alexey Kardashevskiy</p></td>
<td><p>4</p></td>
<td><p>(1.7%)</p></td>
</tr>
<tr class="row-odd"><td><p>Michael Neuling</p></td>
<td><p>4</p></td>
<td><p>(1.7%)</p></td>
</tr>
<tr class="row-even"><td><p>Prem Shanker Jha</p></td>
<td><p>3</p></td>
<td><p>(1.2%)</p></td>
</tr>
<tr class="row-odd"><td><p>Cédric Le Goater</p></td>
<td><p>2</p></td>
<td><p>(0.8%)</p></td>
</tr>
<tr class="row-even"><td><p>Rashmica Gupta</p></td>
<td><p>2</p></td>
<td><p>(0.8%)</p></td>
</tr>
<tr class="row-odd"><td><p>Mahesh J Salgaonkar</p></td>
<td><p>2</p></td>
<td><p>(0.8%)</p></td>
</tr>
<tr class="row-even"><td><p>Alistair Popple</p></td>
<td><p>2</p></td>
<td><p>(0.8%)</p></td>
</tr>
<tr class="row-odd"><td><p>Shilpasri G Bhat</p></td>
<td><p>1</p></td>
<td><p>(0.4%)</p></td>
</tr>
<tr class="row-even"><td><p>Adriana Kobylak</p></td>
<td><p>1</p></td>
<td><p>(0.4%)</p></td>
</tr>
<tr class="row-odd"><td><p>Madhavan Srinivasan</p></td>
<td><p>1</p></td>
<td><p>(0.4%)</p></td>
</tr>
<tr class="row-even"><td><p>Artem Senichev</p></td>
<td><p>1</p></td>
<td><p>(0.4%)</p></td>
</tr>
<tr class="row-odd"><td><p>Russell Currey</p></td>
<td><p>1</p></td>
<td><p>(0.4%)</p></td>
</tr>
<tr class="row-even"><td><p>Vaidyanathan Srinivasan</p></td>
<td><p>1</p></td>
<td><p>(0.4%)</p></td>
</tr>
<tr class="row-odd"><td><p>Cyril Bur</p></td>
<td><p>1</p></td>
<td><p>(0.4%)</p></td>
</tr>
<tr class="row-even"><td><p>Jeremy Kerr</p></td>
<td><p>1</p></td>
<td><p>(0.4%)</p></td>
</tr>
<tr class="row-odd"><td><p>Michael Ellerman</p></td>
<td><p>1</p></td>
<td><p>(0.4%)</p></td>
</tr>
</tbody>
</table>
</section>
<section id="developers-with-the-most-changed-lines">
<h3>Developers with the most changed lines<a class="headerlink" href="#developers-with-the-most-changed-lines" title="Link to this heading"></a></h3>
<table class="docutils align-default">
<thead>
<tr class="row-odd"><th class="head"><p>Developer</p></th>
<th class="head"><p>#</p></th>
<th class="head"><p>%</p></th>
</tr>
</thead>
<tbody>
<tr class="row-even"><td><p>Andrew Jeffery</p></td>
<td><p>2861</p></td>
<td><p>(29.3%)</p></td>
</tr>
<tr class="row-odd"><td><p>Stewart Smith</p></td>
<td><p>1891</p></td>
<td><p>(19.4%)</p></td>
</tr>
<tr class="row-even"><td><p>Prem Shanker Jha</p></td>
<td><p>1046</p></td>
<td><p>(10.7%)</p></td>
</tr>
<tr class="row-odd"><td><p>Andrew Donnellan</p></td>
<td><p>799</p></td>
<td><p>(8.2%)</p></td>
</tr>
<tr class="row-even"><td><p>Oliver O’Halloran</p></td>
<td><p>649</p></td>
<td><p>(6.6%)</p></td>
</tr>
<tr class="row-odd"><td><p>Reza Arbab</p></td>
<td><p>441</p></td>
<td><p>(4.5%)</p></td>
</tr>
<tr class="row-even"><td><p>Nicholas Piggin</p></td>
<td><p>412</p></td>
<td><p>(4.2%)</p></td>
</tr>
<tr class="row-odd"><td><p>Vaibhav Jain</p></td>
<td><p>278</p></td>
<td><p>(2.8%)</p></td>
</tr>
<tr class="row-even"><td><p>Cédric Le Goater</p></td>
<td><p>250</p></td>
<td><p>(2.6%)</p></td>
</tr>
<tr class="row-odd"><td><p>Frederic Barrat</p></td>
<td><p>168</p></td>
<td><p>(1.7%)</p></td>
</tr>
<tr class="row-even"><td><p>Rashmica Gupta</p></td>
<td><p>161</p></td>
<td><p>(1.6%)</p></td>
</tr>
<tr class="row-odd"><td><p>Joel Stanley</p></td>
<td><p>152</p></td>
<td><p>(1.6%)</p></td>
</tr>
<tr class="row-even"><td><p>Benjamin Herrenschmidt</p></td>
<td><p>138</p></td>
<td><p>(1.4%)</p></td>
</tr>
<tr class="row-odd"><td><p>Artem Senichev</p></td>
<td><p>101</p></td>
<td><p>(1.0%)</p></td>
</tr>
<tr class="row-even"><td><p>Samuel Mendoza-Jonas</p></td>
<td><p>83</p></td>
<td><p>(0.9%)</p></td>
</tr>
<tr class="row-odd"><td><p>Michael Neuling</p></td>
<td><p>82</p></td>
<td><p>(0.8%)</p></td>
</tr>
<tr class="row-even"><td><p>Michael Ellerman</p></td>
<td><p>61</p></td>
<td><p>(0.6%)</p></td>
</tr>
<tr class="row-odd"><td><p>Mahesh J Salgaonkar</p></td>
<td><p>50</p></td>
<td><p>(0.5%)</p></td>
</tr>
<tr class="row-even"><td><p>Vasant Hegde</p></td>
<td><p>44</p></td>
<td><p>(0.5%)</p></td>
</tr>
<tr class="row-odd"><td><p>Alexey Kardashevskiy</p></td>
<td><p>32</p></td>
<td><p>(0.3%)</p></td>
</tr>
<tr class="row-even"><td><p>Adriana Kobylak</p></td>
<td><p>29</p></td>
<td><p>(0.3%)</p></td>
</tr>
<tr class="row-odd"><td><p>Alistair Popple</p></td>
<td><p>18</p></td>
<td><p>(0.2%)</p></td>
</tr>
<tr class="row-even"><td><p>Shilpasri G Bhat</p></td>
<td><p>4</p></td>
<td><p>(0.0%)</p></td>
</tr>
<tr class="row-odd"><td><p>Madhavan Srinivasan</p></td>
<td><p>3</p></td>
<td><p>(0.0%)</p></td>
</tr>
<tr class="row-even"><td><p>Cyril Bur</p></td>
<td><p>3</p></td>
<td><p>(0.0%)</p></td>
</tr>
<tr class="row-odd"><td><p>Jeremy Kerr</p></td>
<td><p>3</p></td>
<td><p>(0.0%)</p></td>
</tr>
<tr class="row-even"><td><p>Russell Currey</p></td>
<td><p>2</p></td>
<td><p>(0.0%)</p></td>
</tr>
<tr class="row-odd"><td><p>Vaidyanathan Srinivasan</p></td>
<td><p>2</p></td>
<td><p>(0.0%)</p></td>
</tr>
</tbody>
</table>
</section>
<section id="developers-with-the-most-lines-removed">
<h3>Developers with the most lines removed<a class="headerlink" href="#developers-with-the-most-lines-removed" title="Link to this heading"></a></h3>
<table class="docutils align-default">
<thead>
<tr class="row-odd"><th class="head"><p>Developer</p></th>
<th class="head"><p>#</p></th>
<th class="head"><p>%</p></th>
</tr>
</thead>
<tbody>
<tr class="row-even"><td><p>Cédric Le Goater</p></td>
<td><p>205</p></td>
<td><p>(7.9%)</p></td>
</tr>
<tr class="row-odd"><td><p>Samuel Mendoza-Jonas</p></td>
<td><p>8</p></td>
<td><p>(0.3%)</p></td>
</tr>
<tr class="row-even"><td><p>Shilpasri G Bhat</p></td>
<td><p>1</p></td>
<td><p>(0.0%)</p></td>
</tr>
</tbody>
</table>
</section>
<section id="developers-with-the-most-signoffs">
<h3>Developers with the most signoffs<a class="headerlink" href="#developers-with-the-most-signoffs" title="Link to this heading"></a></h3>
<table class="docutils align-default">
<thead>
<tr class="row-odd"><th class="head"><p>Developer</p></th>
<th class="head"><p>#</p></th>
<th class="head"><p>%</p></th>
</tr>
</thead>
<tbody>
<tr class="row-even"><td><p>Stewart Smith</p></td>
<td><p>182</p></td>
<td><p>(95.3%)</p></td>
</tr>
<tr class="row-odd"><td><p>Alistair Popple</p></td>
<td><p>3</p></td>
<td><p>(1.6%)</p></td>
</tr>
<tr class="row-even"><td><p>Akshay Adiga</p></td>
<td><p>2</p></td>
<td><p>(1.0%)</p></td>
</tr>
<tr class="row-odd"><td><p>Christophe Lombard</p></td>
<td><p>1</p></td>
<td><p>(0.5%)</p></td>
</tr>
<tr class="row-even"><td><p>Ryan Grimm</p></td>
<td><p>1</p></td>
<td><p>(0.5%)</p></td>
</tr>
<tr class="row-odd"><td><p>Michael Neuling</p></td>
<td><p>1</p></td>
<td><p>(0.5%)</p></td>
</tr>
<tr class="row-even"><td><p>Mahesh J Salgaonkar</p></td>
<td><p>1</p></td>
<td><p>(0.5%)</p></td>
</tr>
<tr class="row-odd"><td><p>Total</p></td>
<td><p>191</p></td>
<td></td>
</tr>
</tbody>
</table>
</section>
<section id="developers-with-the-most-reviews">
<h3>Developers with the most reviews<a class="headerlink" href="#developers-with-the-most-reviews" title="Link to this heading"></a></h3>
<table class="docutils align-default">
<thead>
<tr class="row-odd"><th class="head"><p>Developer</p></th>
<th class="head"><p>#</p></th>
<th class="head"><p>%</p></th>
</tr>
</thead>
<tbody>
<tr class="row-even"><td><p>Andrew Donnellan</p></td>
<td><p>15</p></td>
<td><p>(19.7%)</p></td>
</tr>
<tr class="row-odd"><td><p>Frederic Barrat</p></td>
<td><p>11</p></td>
<td><p>(14.5%)</p></td>
</tr>
<tr class="row-even"><td><p>Oliver O’Halloran</p></td>
<td><p>9</p></td>
<td><p>(11.8%)</p></td>
</tr>
<tr class="row-odd"><td><p>Alistair Popple</p></td>
<td><p>8</p></td>
<td><p>(10.5%)</p></td>
</tr>
<tr class="row-even"><td><p>Vasant Hegde</p></td>
<td><p>5</p></td>
<td><p>(6.6%)</p></td>
</tr>
<tr class="row-odd"><td><p>Samuel Mendoza-Jonas</p></td>
<td><p>4</p></td>
<td><p>(5.3%)</p></td>
</tr>
<tr class="row-even"><td><p>Christophe Lombard</p></td>
<td><p>3</p></td>
<td><p>(3.9%)</p></td>
</tr>
<tr class="row-odd"><td><p>Gregory S. Still</p></td>
<td><p>3</p></td>
<td><p>(3.9%)</p></td>
</tr>
<tr class="row-even"><td><p>Mahesh J Salgaonkar</p></td>
<td><p>2</p></td>
<td><p>(2.6%)</p></td>
</tr>
<tr class="row-odd"><td><p>RANGANATHPRASAD G. BRAHMASAMUDRA</p></td>
<td><p>2</p></td>
<td><p>(2.6%)</p></td>
</tr>
<tr class="row-even"><td><p>Jennifer A. Stofer</p></td>
<td><p>2</p></td>
<td><p>(2.6%)</p></td>
</tr>
<tr class="row-odd"><td><p>AMIT J. TENDOLKAR</p></td>
<td><p>2</p></td>
<td><p>(2.6%)</p></td>
</tr>
<tr class="row-even"><td><p>Christian R. Geddes</p></td>
<td><p>2</p></td>
<td><p>(2.6%)</p></td>
</tr>
<tr class="row-odd"><td><p>Cédric Le Goater</p></td>
<td><p>1</p></td>
<td><p>(1.3%)</p></td>
</tr>
<tr class="row-even"><td><p>Shilpasri G Bhat</p></td>
<td><p>1</p></td>
<td><p>(1.3%)</p></td>
</tr>
<tr class="row-odd"><td><p>Daniel M. Crowell</p></td>
<td><p>1</p></td>
<td><p>(1.3%)</p></td>
</tr>
<tr class="row-even"><td><p>Alexey Kardashevskiy</p></td>
<td><p>1</p></td>
<td><p>(1.3%)</p></td>
</tr>
<tr class="row-odd"><td><p>Joel Stanley</p></td>
<td><p>1</p></td>
<td><p>(1.3%)</p></td>
</tr>
<tr class="row-even"><td><p>Vaibhav Jain</p></td>
<td><p>1</p></td>
<td><p>(1.3%)</p></td>
</tr>
<tr class="row-odd"><td><p>Nicholas Piggin</p></td>
<td><p>1</p></td>
<td><p>(1.3%)</p></td>
</tr>
<tr class="row-even"><td><p>Andrew Jeffery</p></td>
<td><p>1</p></td>
<td><p>(1.3%)</p></td>
</tr>
<tr class="row-odd"><td><p>Total</p></td>
<td><p>76</p></td>
<td></td>
</tr>
</tbody>
</table>
</section>
<section id="developers-with-the-most-test-credits">
<h3>Developers with the most test credits<a class="headerlink" href="#developers-with-the-most-test-credits" title="Link to this heading"></a></h3>
<table class="docutils align-default">
<thead>
<tr class="row-odd"><th class="head"><p>Developer</p></th>
<th class="head"><p>#</p></th>
<th class="head"><p>%</p></th>
</tr>
</thead>
<tbody>
<tr class="row-even"><td><p>Jenkins Server</p></td>
<td><p>3</p></td>
<td><p>(12.0%)</p></td>
</tr>
<tr class="row-odd"><td><p>Cronus HW CI</p></td>
<td><p>3</p></td>
<td><p>(12.0%)</p></td>
</tr>
<tr class="row-even"><td><p>Hostboot CI</p></td>
<td><p>3</p></td>
<td><p>(12.0%)</p></td>
</tr>
<tr class="row-odd"><td><p>Jenkins OP Build CI</p></td>
<td><p>3</p></td>
<td><p>(12.0%)</p></td>
</tr>
<tr class="row-even"><td><p>FSP CI Jenkins</p></td>
<td><p>3</p></td>
<td><p>(12.0%)</p></td>
</tr>
<tr class="row-odd"><td><p>Jenkins OP HW</p></td>
<td><p>3</p></td>
<td><p>(12.0%)</p></td>
</tr>
<tr class="row-even"><td><p>Vasant Hegde</p></td>
<td><p>2</p></td>
<td><p>(8.0%)</p></td>
</tr>
<tr class="row-odd"><td><p>Andrew Donnellan</p></td>
<td><p>1</p></td>
<td><p>(4.0%)</p></td>
</tr>
<tr class="row-even"><td><p>Oliver O’Halloran</p></td>
<td><p>1</p></td>
<td><p>(4.0%)</p></td>
</tr>
<tr class="row-odd"><td><p>Andrew Jeffery</p></td>
<td><p>1</p></td>
<td><p>(4.0%)</p></td>
</tr>
<tr class="row-even"><td><p>HWSV CI</p></td>
<td><p>1</p></td>
<td><p>(4.0%)</p></td>
</tr>
<tr class="row-odd"><td><p>Artem Senichev</p></td>
<td><p>1</p></td>
<td><p>(4.0%)</p></td>
</tr>
<tr class="row-even"><td><p>Total</p></td>
<td><p>25</p></td>
<td></td>
</tr>
</tbody>
</table>
</section>
<section id="developers-who-gave-the-most-tested-by-credits">
<h3>Developers who gave the most tested-by credits<a class="headerlink" href="#developers-who-gave-the-most-tested-by-credits" title="Link to this heading"></a></h3>
<table class="docutils align-default">
<thead>
<tr class="row-odd"><th class="head"><p>Developer</p></th>
<th class="head"><p>#</p></th>
<th class="head"><p>%</p></th>
</tr>
</thead>
<tbody>
<tr class="row-even"><td><p>Prem Shanker Jha</p></td>
<td><p>19</p></td>
<td><p>(76.0%)</p></td>
</tr>
<tr class="row-odd"><td><p>Frederic Barrat</p></td>
<td><p>2</p></td>
<td><p>(8.0%)</p></td>
</tr>
<tr class="row-even"><td><p>Andrew Jeffery</p></td>
<td><p>1</p></td>
<td><p>(4.0%)</p></td>
</tr>
<tr class="row-odd"><td><p>Vaibhav Jain</p></td>
<td><p>1</p></td>
<td><p>(4.0%)</p></td>
</tr>
<tr class="row-even"><td><p>Stewart Smith</p></td>
<td><p>1</p></td>
<td><p>(4.0%)</p></td>
</tr>
<tr class="row-odd"><td><p>Benjamin Herrenschmidt</p></td>
<td><p>1</p></td>
<td><p>(4.0%)</p></td>
</tr>
</tbody>
</table>
</section>
<section id="developers-with-the-most-report-credits">
<h3>Developers with the most report credits<a class="headerlink" href="#developers-with-the-most-report-credits" title="Link to this heading"></a></h3>
<table class="docutils align-default">
<thead>
<tr class="row-odd"><th class="head"><p>Developer</p></th>
<th class="head"><p>#</p></th>
<th class="head"><p>%</p></th>
</tr>
</thead>
<tbody>
<tr class="row-even"><td><p>Vasant Hegde</p></td>
<td><p>2</p></td>
<td><p>(25.0%)</p></td>
</tr>
<tr class="row-odd"><td><p>Frederic Barrat</p></td>
<td><p>1</p></td>
<td><p>(12.5%)</p></td>
</tr>
<tr class="row-even"><td><p>Dawn Sylvia</p></td>
<td><p>1</p></td>
<td><p>(12.5%)</p></td>
</tr>
<tr class="row-odd"><td><p>Meng Li</p></td>
<td><p>1</p></td>
<td><p>(12.5%)</p></td>
</tr>
<tr class="row-even"><td><p>Tyler Seredynski</p></td>
<td><p>1</p></td>
<td><p>(12.5%)</p></td>
</tr>
<tr class="row-odd"><td><p>Pridhiviraj Paidipeddi</p></td>
<td><p>1</p></td>
<td><p>(12.5%)</p></td>
</tr>
<tr class="row-even"><td><p>Stephanie Swanson</p></td>
<td><p>1</p></td>
<td><p>(12.5%)</p></td>
</tr>
</tbody>
</table>
</section>
<section id="developers-who-gave-the-most-report-credits">
<h3>Developers who gave the most report credits<a class="headerlink" href="#developers-who-gave-the-most-report-credits" title="Link to this heading"></a></h3>
<table class="docutils align-default">
<thead>
<tr class="row-odd"><th class="head"><p>Developer</p></th>
<th class="head"><p>#</p></th>
<th class="head"><p>%</p></th>
</tr>
</thead>
<tbody>
<tr class="row-even"><td><p>Stewart Smith</p></td>
<td><p>2</p></td>
<td><p>(25.0%)</p></td>
</tr>
<tr class="row-odd"><td><p>Vaidyanathan Srinivasan</p></td>
<td><p>2</p></td>
<td><p>(25.0%)</p></td>
</tr>
<tr class="row-even"><td><p>Vasant Hegde</p></td>
<td><p>1</p></td>
<td><p>(12.5%)</p></td>
</tr>
<tr class="row-odd"><td><p>Vaibhav Jain</p></td>
<td><p>1</p></td>
<td><p>(12.5%)</p></td>
</tr>
<tr class="row-even"><td><p>Andrew Donnellan</p></td>
<td><p>1</p></td>
<td><p>(12.5%)</p></td>
</tr>
<tr class="row-odd"><td><p>Michael Neuling</p></td>
<td><p>1</p></td>
<td><p>(12.5%)</p></td>
</tr>
</tbody>
</table>
</section>
<section id="employers-with-the-most-hackers">
<h3>Employers with the most hackers<a class="headerlink" href="#employers-with-the-most-hackers" title="Link to this heading"></a></h3>
<table class="docutils align-default">
<thead>
<tr class="row-odd"><th class="head"><p>Developer</p></th>
<th class="head"><p>#</p></th>
<th class="head"><p>%</p></th>
</tr>
</thead>
<tbody>
<tr class="row-even"><td><p>IBM</p></td>
<td><p>27</p></td>
<td><p>(96.4%)</p></td>
</tr>
<tr class="row-odd"><td><p>YADRO</p></td>
<td><p>1</p></td>
<td><p>(3.6%)</p></td>
</tr>
</tbody>
</table>
</section>
</section>
</section>
<div class="clearer"></div>
</div>
</div>
</div>
<div class="sphinxsidebar" role="navigation" aria-label="main navigation">
<div class="sphinxsidebarwrapper">
<div>
<h3><a href="../index.html">Table of Contents</a></h3>
<ul>
<li><a class="reference internal" href="#">skiboot-6.2</a><ul>
<li><a class="reference internal" href="#general">General</a><ul>
<li><a class="reference internal" href="#fast-reboot">Fast Reboot</a></li>
</ul>
</li>
<li><a class="reference internal" href="#utilities">Utilities</a></li>
<li><a class="reference internal" href="#development-and-debugging">Development and Debugging</a></li>
<li><a class="reference internal" href="#ci-testing-and-utilities">CI, testing, and utilities</a><ul>
<li><a class="reference internal" href="#mambo-platform">Mambo Platform</a></li>
<li><a class="reference internal" href="#qemu-platform">Qemu platform</a></li>
</ul>
</li>
<li><a class="reference internal" href="#power8-platforms">POWER8 Platforms</a><ul>
<li><a class="reference internal" href="#vesnin-platform">Vesnin Platform</a></li>
</ul>
</li>
<li><a class="reference internal" href="#power9-platforms">POWER9 Platforms</a><ul>
<li><a class="reference internal" href="#phb4">PHB4</a></li>
<li><a class="reference internal" href="#capi2">CAPI2</a></li>
<li><a class="reference internal" href="#nvlink2">NVLINK2</a></li>
<li><a class="reference internal" href="#opencapi">OpenCAPI</a></li>
<li><a class="reference internal" href="#barreleye-g2-and-zaius-platforms">Barreleye G2 and Zaius platforms</a></li>
<li><a class="reference internal" href="#fsp-based-platforms-firenze-and-zz">FSP based platforms (firenze and ZZ)</a></li>
<li><a class="reference internal" href="#witherspoon-platform">Witherspoon platform</a></li>
</ul>
</li>
<li><a class="reference internal" href="#contributors">Contributors</a><ul>
<li><a class="reference internal" href="#developers-with-the-most-changesets">Developers with the most changesets</a></li>
<li><a class="reference internal" href="#developers-with-the-most-changed-lines">Developers with the most changed lines</a></li>
<li><a class="reference internal" href="#developers-with-the-most-lines-removed">Developers with the most lines removed</a></li>
<li><a class="reference internal" href="#developers-with-the-most-signoffs">Developers with the most signoffs</a></li>
<li><a class="reference internal" href="#developers-with-the-most-reviews">Developers with the most reviews</a></li>
<li><a class="reference internal" href="#developers-with-the-most-test-credits">Developers with the most test credits</a></li>
<li><a class="reference internal" href="#developers-who-gave-the-most-tested-by-credits">Developers who gave the most tested-by credits</a></li>
<li><a class="reference internal" href="#developers-with-the-most-report-credits">Developers with the most report credits</a></li>
<li><a class="reference internal" href="#developers-who-gave-the-most-report-credits">Developers who gave the most report credits</a></li>
<li><a class="reference internal" href="#employers-with-the-most-hackers">Employers with the most hackers</a></li>
</ul>
</li>
</ul>
</li>
</ul>
</div>
<div>
<h4>Previous topic</h4>
<p class="topless"><a href="skiboot-6.1-rc1.html"
title="previous chapter">skiboot-6.1-rc1</a></p>
</div>
<div>
<h4>Next topic</h4>
<p class="topless"><a href="skiboot-6.2-rc1.html"
title="next chapter">skiboot-6.2-rc1</a></p>
</div>
<div role="note" aria-label="source link">
<h3>This Page</h3>
<ul class="this-page-menu">
<li><a href="../_sources/release-notes/skiboot-6.2.rst.txt"
rel="nofollow">Show Source</a></li>
</ul>
</div>
<div id="searchbox" style="display: none" role="search">
<h3 id="searchlabel">Quick search</h3>
<div class="searchformwrapper">
<form class="search" action="../search.html" method="get">
<input type="text" name="q" aria-labelledby="searchlabel" autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false"/>
<input type="submit" value="Go" />
</form>
</div>
</div>
<script>document.getElementById('searchbox').style.display = "block"</script>
</div>
</div>
<div class="clearer"></div>
</div>
<div class="related" role="navigation" aria-label="related navigation">
<h3>Navigation</h3>
<ul>
<li class="right" style="margin-right: 10px">
<a href="../genindex.html" title="General Index"
>index</a></li>
<li class="right" >
<a href="skiboot-6.2-rc1.html" title="skiboot-6.2-rc1"
>next</a> |</li>
<li class="right" >
<a href="skiboot-6.1-rc1.html" title="skiboot-6.1-rc1"
>previous</a> |</li>
<li class="nav-item nav-item-0"><a href="../index.html">skiboot d365a01
documentation</a> &#187;</li>
<li class="nav-item nav-item-1"><a href="index.html" >Release Notes</a> &#187;</li>
<li class="nav-item nav-item-this"><a href="">skiboot-6.2</a></li>
</ul>
</div>
<div class="footer" role="contentinfo">
&#169; Copyright 2016-2017, IBM, others.
Created using <a href="https://www.sphinx-doc.org/">Sphinx</a> 7.2.6.
</div>
</body>
</html>