hw/ide/cmd646.c - qemu - Git at Google

 /*
  * QEMU IDE Emulation: PCI cmd646 support.
  *
  * Copyright (c) 2003 Fabrice Bellard
  * Copyright (c) 2006 Openedhand Ltd.
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
  * in the Software without restriction, including without limitation the rights
  * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
  * copies of the Software, and to permit persons to whom the Software is
  * furnished to do so, subject to the following conditions:
  *
  * The above copyright notice and this permission notice shall be included in
  * all copies or substantial portions of the Software.
  *
  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  * THE SOFTWARE.
  */
 #include <hw/hw.h>
 #include <hw/pc.h>
 #include <hw/pci.h>
 #include <hw/isa.h>
 #include "block.h"
 #include "sysemu.h"
 #include "dma.h"

 #include <hw/ide/pci.h>

 /* CMD646 specific */
 #define MRDMODE		0x71
 #define   MRDMODE_INTR_CH0	0x04
 #define   MRDMODE_INTR_CH1	0x08
 #define   MRDMODE_BLK_CH0	0x10
 #define   MRDMODE_BLK_CH1	0x20
 #define UDIDETCR0	0x73
 #define UDIDETCR1	0x7B

 static void cmd646_update_irq(PCIIDEState *d);

 static uint64_t cmd646_cmd_read(void *opaque, target_phys_addr_t addr,
                                 unsigned size)
 {
     CMD646BAR *cmd646bar = opaque;

     if (addr != 2 || size != 1) {
         return ((uint64_t)1 << (size * 8)) - 1;
     }
     return ide_status_read(cmd646bar->bus, addr + 2);
 }

 static void cmd646_cmd_write(void *opaque, target_phys_addr_t addr,
                              uint64_t data, unsigned size)
 {
     CMD646BAR *cmd646bar = opaque;

     if (addr != 2 || size != 1) {
         return;
     }
     ide_cmd_write(cmd646bar->bus, addr + 2, data);
 }

 static const MemoryRegionOps cmd646_cmd_ops = {
     .read = cmd646_cmd_read,
     .write = cmd646_cmd_write,
     .endianness = DEVICE_LITTLE_ENDIAN,
 };

 static uint64_t cmd646_data_read(void *opaque, target_phys_addr_t addr,
                                  unsigned size)
 {
     CMD646BAR *cmd646bar = opaque;

     if (size == 1) {
         return ide_ioport_read(cmd646bar->bus, addr);
     } else if (addr == 0) {
         if (size == 2) {
             return ide_data_readw(cmd646bar->bus, addr);
         } else {
             return ide_data_readl(cmd646bar->bus, addr);
         }
     }
     return ((uint64_t)1 << (size * 8)) - 1;
 }

 static void cmd646_data_write(void *opaque, target_phys_addr_t addr,
                              uint64_t data, unsigned size)
 {
     CMD646BAR *cmd646bar = opaque;

     if (size == 1) {
         ide_ioport_write(cmd646bar->bus, addr, data);
     } else if (addr == 0) {
         if (size == 2) {
             ide_data_writew(cmd646bar->bus, addr, data);
         } else {
             ide_data_writel(cmd646bar->bus, addr, data);
         }
     }
 }

 static const MemoryRegionOps cmd646_data_ops = {
     .read = cmd646_data_read,
     .write = cmd646_data_write,
     .endianness = DEVICE_LITTLE_ENDIAN,
 };

 static void setup_cmd646_bar(PCIIDEState *d, int bus_num)
 {
     IDEBus *bus = &d->bus[bus_num];
     CMD646BAR *bar = &d->cmd646_bar[bus_num];

     bar->bus = bus;
     bar->pci_dev = d;
     memory_region_init_io(&bar->cmd, &cmd646_cmd_ops, bar, "cmd646-cmd", 4);
     memory_region_init_io(&bar->data, &cmd646_data_ops, bar, "cmd646-data", 8);
 }

 static uint64_t bmdma_read(void *opaque, target_phys_addr_t addr,
                            unsigned size)
 {
     BMDMAState *bm = opaque;
     PCIIDEState *pci_dev = bm->pci_dev;
     uint32_t val;

     if (size != 1) {
         return ((uint64_t)1 << (size * 8)) - 1;
     }

     switch(addr & 3) {
     case 0:
         val = bm->cmd;
         break;
     case 1:
         val = pci_dev->dev.config[MRDMODE];
         break;
     case 2:
         val = bm->status;
         break;
     case 3:
         if (bm == &pci_dev->bmdma[0]) {
             val = pci_dev->dev.config[UDIDETCR0];
         } else {
             val = pci_dev->dev.config[UDIDETCR1];
         }
         break;
     default:
         val = 0xff;
         break;
     }
 #ifdef DEBUG_IDE
     printf("bmdma: readb 0x%02x : 0x%02x\n", addr, val);
 #endif
     return val;
 }

 static void bmdma_write(void *opaque, target_phys_addr_t addr,
                         uint64_t val, unsigned size)
 {
     BMDMAState *bm = opaque;
     PCIIDEState *pci_dev = bm->pci_dev;

     if (size != 1) {
         return;
     }

 #ifdef DEBUG_IDE
     printf("bmdma: writeb 0x%02x : 0x%02x\n", addr, val);
 #endif
     switch(addr & 3) {
     case 0:
         bmdma_cmd_writeb(bm, val);
         break;
     case 1:
         pci_dev->dev.config[MRDMODE] =
             (pci_dev->dev.config[MRDMODE] & ~0x30) | (val & 0x30);
         cmd646_update_irq(pci_dev);
         break;
     case 2:
         bm->status = (val & 0x60) | (bm->status & 1) | (bm->status & ~val & 0x06);
         break;
     case 3:
         if (bm == &pci_dev->bmdma[0])
             pci_dev->dev.config[UDIDETCR0] = val;
         else
             pci_dev->dev.config[UDIDETCR1] = val;
         break;
     }
 }

 static const MemoryRegionOps cmd646_bmdma_ops = {
     .read = bmdma_read,
     .write = bmdma_write,
 };

 static void bmdma_setup_bar(PCIIDEState *d)
 {
     BMDMAState *bm;
     int i;

     memory_region_init(&d->bmdma_bar, "cmd646-bmdma", 16);
     for(i = 0;i < 2; i++) {
         bm = &d->bmdma[i];
         memory_region_init_io(&bm->extra_io, &cmd646_bmdma_ops, bm,
                               "cmd646-bmdma-bus", 4);
         memory_region_add_subregion(&d->bmdma_bar, i * 8, &bm->extra_io);
         memory_region_init_io(&bm->addr_ioport, &bmdma_addr_ioport_ops, bm,
                               "cmd646-bmdma-ioport", 4);
         memory_region_add_subregion(&d->bmdma_bar, i * 8 + 4, &bm->addr_ioport);
     }
 }

 /* XXX: call it also when the MRDMODE is changed from the PCI config
    registers */
 static void cmd646_update_irq(PCIIDEState *d)
 {
     int pci_level;
     pci_level = ((d->dev.config[MRDMODE] & MRDMODE_INTR_CH0) &&
                  !(d->dev.config[MRDMODE] & MRDMODE_BLK_CH0)) ||
         ((d->dev.config[MRDMODE] & MRDMODE_INTR_CH1) &&
          !(d->dev.config[MRDMODE] & MRDMODE_BLK_CH1));
     qemu_set_irq(d->dev.irq[0], pci_level);
 }

 /* the PCI irq level is the logical OR of the two channels */
 static void cmd646_set_irq(void *opaque, int channel, int level)
 {
     PCIIDEState *d = opaque;
     int irq_mask;

     irq_mask = MRDMODE_INTR_CH0 << channel;
     if (level)
         d->dev.config[MRDMODE] |= irq_mask;
     else
         d->dev.config[MRDMODE] &= ~irq_mask;
     cmd646_update_irq(d);
 }

 static void cmd646_reset(void *opaque)
 {
     PCIIDEState *d = opaque;
     unsigned int i;

     for (i = 0; i < 2; i++) {
         ide_bus_reset(&d->bus[i]);
     }
 }

 /* CMD646 PCI IDE controller */
 static int pci_cmd646_ide_initfn(PCIDevice *dev)
 {
     PCIIDEState *d = DO_UPCAST(PCIIDEState, dev, dev);
     uint8_t *pci_conf = d->dev.config;
     qemu_irq *irq;
     int i;

     pci_conf[PCI_CLASS_PROG] = 0x8f;

     pci_conf[0x51] = 0x04; // enable IDE0
     if (d->secondary) {
         /* XXX: if not enabled, really disable the seconday IDE controller */
         pci_conf[0x51] |= 0x08; /* enable IDE1 */
     }

     setup_cmd646_bar(d, 0);
     setup_cmd646_bar(d, 1);
     pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &d->cmd646_bar[0].data);
     pci_register_bar(dev, 1, PCI_BASE_ADDRESS_SPACE_IO, &d->cmd646_bar[0].cmd);
     pci_register_bar(dev, 2, PCI_BASE_ADDRESS_SPACE_IO, &d->cmd646_bar[1].data);
     pci_register_bar(dev, 3, PCI_BASE_ADDRESS_SPACE_IO, &d->cmd646_bar[1].cmd);
     bmdma_setup_bar(d);
     pci_register_bar(dev, 4, PCI_BASE_ADDRESS_SPACE_IO, &d->bmdma_bar);

     /* TODO: RST# value should be 0 */
     pci_conf[PCI_INTERRUPT_PIN] = 0x01; // interrupt on pin 1

     irq = qemu_allocate_irqs(cmd646_set_irq, d, 2);
     for (i = 0; i < 2; i++) {
         ide_bus_new(&d->bus[i], &d->dev.qdev, i);
         ide_init2(&d->bus[i], irq[i]);

         bmdma_init(&d->bus[i], &d->bmdma[i], d);
         d->bmdma[i].bus = &d->bus[i];
         qemu_add_vm_change_state_handler(d->bus[i].dma->ops->restart_cb,
                                          &d->bmdma[i].dma);
     }

     vmstate_register(&dev->qdev, 0, &vmstate_ide_pci, d);
     qemu_register_reset(cmd646_reset, d);
     return 0;
 }

 static void pci_cmd646_ide_exitfn(PCIDevice *dev)
 {
     PCIIDEState *d = DO_UPCAST(PCIIDEState, dev, dev);
     unsigned i;

     for (i = 0; i < 2; ++i) {
         memory_region_del_subregion(&d->bmdma_bar, &d->bmdma[i].extra_io);
         memory_region_destroy(&d->bmdma[i].extra_io);
         memory_region_del_subregion(&d->bmdma_bar, &d->bmdma[i].addr_ioport);
         memory_region_destroy(&d->bmdma[i].addr_ioport);
         memory_region_destroy(&d->cmd646_bar[i].cmd);
         memory_region_destroy(&d->cmd646_bar[i].data);
     }
     memory_region_destroy(&d->bmdma_bar);
 }

 void pci_cmd646_ide_init(PCIBus *bus, DriveInfo **hd_table,
                          int secondary_ide_enabled)
 {
     PCIDevice *dev;

     dev = pci_create(bus, -1, "cmd646-ide");
     qdev_prop_set_uint32(&dev->qdev, "secondary", secondary_ide_enabled);
     qdev_init_nofail(&dev->qdev);

     pci_ide_create_devs(dev, hd_table);
 }

 static Property cmd646_ide_properties[] = {
     DEFINE_PROP_UINT32("secondary", PCIIDEState, secondary, 0),
     DEFINE_PROP_END_OF_LIST(),
 };

 static void cmd646_ide_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
     PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);

     k->init = pci_cmd646_ide_initfn;
     k->exit = pci_cmd646_ide_exitfn;
     k->vendor_id = PCI_VENDOR_ID_CMD;
     k->device_id = PCI_DEVICE_ID_CMD_646;
     k->revision = 0x07;
     k->class_id = PCI_CLASS_STORAGE_IDE;
     dc->props = cmd646_ide_properties;
 }

 static TypeInfo cmd646_ide_info = {
     .name          = "cmd646-ide",
     .parent        = TYPE_PCI_DEVICE,
     .instance_size = sizeof(PCIIDEState),
     .class_init    = cmd646_ide_class_init,
 };

 static void cmd646_ide_register_types(void)
 {
     type_register_static(&cmd646_ide_info);
 }

 type_init(cmd646_ide_register_types)
	/*
	* QEMU IDE Emulation: PCI cmd646 support.
	*
	* Copyright (c) 2003 Fabrice Bellard
	* Copyright (c) 2006 Openedhand Ltd.
	*
	* Permission is hereby granted, free of charge, to any person obtaining a copy
	* of this software and associated documentation files (the "Software"), to deal
	* in the Software without restriction, including without limitation the rights
	* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
	* copies of the Software, and to permit persons to whom the Software is
	* furnished to do so, subject to the following conditions:
	*
	* The above copyright notice and this permission notice shall be included in
	* all copies or substantial portions of the Software.
	*
	* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
	* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
	* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
	* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
	* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
	* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
	* THE SOFTWARE.
	*/
	#include <hw/hw.h>
	#include <hw/pc.h>
	#include <hw/pci.h>
	#include <hw/isa.h>
	#include "block.h"
	#include "sysemu.h"
	#include "dma.h"

	#include <hw/ide/pci.h>

	/* CMD646 specific */
	#define MRDMODE 0x71
	#define MRDMODE_INTR_CH0 0x04
	#define MRDMODE_INTR_CH1 0x08
	#define MRDMODE_BLK_CH0 0x10
	#define MRDMODE_BLK_CH1 0x20
	#define UDIDETCR0 0x73
	#define UDIDETCR1 0x7B

	static void cmd646_update_irq(PCIIDEState *d);

	static uint64_t cmd646_cmd_read(void *opaque, target_phys_addr_t addr,
	unsigned size)
	{
	CMD646BAR *cmd646bar = opaque;

	if (addr != 2 \|\| size != 1) {
	return ((uint64_t)1 << (size * 8)) - 1;
	}
	return ide_status_read(cmd646bar->bus, addr + 2);
	}

	static void cmd646_cmd_write(void *opaque, target_phys_addr_t addr,
	uint64_t data, unsigned size)
	{
	CMD646BAR *cmd646bar = opaque;

	if (addr != 2 \|\| size != 1) {
	return;
	}
	ide_cmd_write(cmd646bar->bus, addr + 2, data);
	}

	static const MemoryRegionOps cmd646_cmd_ops = {
	.read = cmd646_cmd_read,
	.write = cmd646_cmd_write,
	.endianness = DEVICE_LITTLE_ENDIAN,
	};

	static uint64_t cmd646_data_read(void *opaque, target_phys_addr_t addr,
	unsigned size)
	{
	CMD646BAR *cmd646bar = opaque;

	if (size == 1) {
	return ide_ioport_read(cmd646bar->bus, addr);
	} else if (addr == 0) {
	if (size == 2) {
	return ide_data_readw(cmd646bar->bus, addr);
	} else {
	return ide_data_readl(cmd646bar->bus, addr);
	}
	}
	return ((uint64_t)1 << (size * 8)) - 1;
	}

	static void cmd646_data_write(void *opaque, target_phys_addr_t addr,
	uint64_t data, unsigned size)
	{
	CMD646BAR *cmd646bar = opaque;

	if (size == 1) {
	ide_ioport_write(cmd646bar->bus, addr, data);
	} else if (addr == 0) {
	if (size == 2) {
	ide_data_writew(cmd646bar->bus, addr, data);
	} else {
	ide_data_writel(cmd646bar->bus, addr, data);
	}
	}
	}

	static const MemoryRegionOps cmd646_data_ops = {
	.read = cmd646_data_read,
	.write = cmd646_data_write,
	.endianness = DEVICE_LITTLE_ENDIAN,
	};

	static void setup_cmd646_bar(PCIIDEState *d, int bus_num)
	{
	IDEBus *bus = &d->bus[bus_num];
	CMD646BAR *bar = &d->cmd646_bar[bus_num];

	bar->bus = bus;
	bar->pci_dev = d;
	memory_region_init_io(&bar->cmd, &cmd646_cmd_ops, bar, "cmd646-cmd", 4);
	memory_region_init_io(&bar->data, &cmd646_data_ops, bar, "cmd646-data", 8);
	}

	static uint64_t bmdma_read(void *opaque, target_phys_addr_t addr,
	unsigned size)
	{
	BMDMAState *bm = opaque;
	PCIIDEState *pci_dev = bm->pci_dev;
	uint32_t val;

	if (size != 1) {
	return ((uint64_t)1 << (size * 8)) - 1;
	}

	switch(addr & 3) {
	case 0:
	val = bm->cmd;
	break;
	case 1:
	val = pci_dev->dev.config[MRDMODE];
	break;
	case 2:
	val = bm->status;
	break;
	case 3:
	if (bm == &pci_dev->bmdma[0]) {
	val = pci_dev->dev.config[UDIDETCR0];
	} else {
	val = pci_dev->dev.config[UDIDETCR1];
	}
	break;
	default:
	val = 0xff;
	break;
	}
	#ifdef DEBUG_IDE
	printf("bmdma: readb 0x%02x : 0x%02x\n", addr, val);
	#endif
	return val;
	}

	static void bmdma_write(void *opaque, target_phys_addr_t addr,
	uint64_t val, unsigned size)
	{
	BMDMAState *bm = opaque;
	PCIIDEState *pci_dev = bm->pci_dev;

	if (size != 1) {
	return;
	}

	#ifdef DEBUG_IDE
	printf("bmdma: writeb 0x%02x : 0x%02x\n", addr, val);
	#endif
	switch(addr & 3) {
	case 0:
	bmdma_cmd_writeb(bm, val);
	break;
	case 1:
	pci_dev->dev.config[MRDMODE] =
	(pci_dev->dev.config[MRDMODE] & ~0x30) \| (val & 0x30);
	cmd646_update_irq(pci_dev);
	break;
	case 2:
	bm->status = (val & 0x60) \| (bm->status & 1) \| (bm->status & ~val & 0x06);
	break;
	case 3:
	if (bm == &pci_dev->bmdma[0])
	pci_dev->dev.config[UDIDETCR0] = val;
	else
	pci_dev->dev.config[UDIDETCR1] = val;
	break;
	}
	}

	static const MemoryRegionOps cmd646_bmdma_ops = {
	.read = bmdma_read,
	.write = bmdma_write,
	};

	static void bmdma_setup_bar(PCIIDEState *d)
	{
	BMDMAState *bm;
	int i;

	memory_region_init(&d->bmdma_bar, "cmd646-bmdma", 16);
	for(i = 0;i < 2; i++) {
	bm = &d->bmdma[i];
	memory_region_init_io(&bm->extra_io, &cmd646_bmdma_ops, bm,
	"cmd646-bmdma-bus", 4);
	memory_region_add_subregion(&d->bmdma_bar, i * 8, &bm->extra_io);
	memory_region_init_io(&bm->addr_ioport, &bmdma_addr_ioport_ops, bm,
	"cmd646-bmdma-ioport", 4);
	memory_region_add_subregion(&d->bmdma_bar, i * 8 + 4, &bm->addr_ioport);
	}
	}

	/* XXX: call it also when the MRDMODE is changed from the PCI config
	registers */
	static void cmd646_update_irq(PCIIDEState *d)
	{
	int pci_level;
	pci_level = ((d->dev.config[MRDMODE] & MRDMODE_INTR_CH0) &&
	!(d->dev.config[MRDMODE] & MRDMODE_BLK_CH0)) \|\|
	((d->dev.config[MRDMODE] & MRDMODE_INTR_CH1) &&
	!(d->dev.config[MRDMODE] & MRDMODE_BLK_CH1));
	qemu_set_irq(d->dev.irq[0], pci_level);
	}

	/* the PCI irq level is the logical OR of the two channels */
	static void cmd646_set_irq(void *opaque, int channel, int level)
	{
	PCIIDEState *d = opaque;
	int irq_mask;

	irq_mask = MRDMODE_INTR_CH0 << channel;
	if (level)
	d->dev.config[MRDMODE] \|= irq_mask;
	else
	d->dev.config[MRDMODE] &= ~irq_mask;
	cmd646_update_irq(d);
	}

	static void cmd646_reset(void *opaque)
	{
	PCIIDEState *d = opaque;
	unsigned int i;

	for (i = 0; i < 2; i++) {
	ide_bus_reset(&d->bus[i]);
	}
	}

	/* CMD646 PCI IDE controller */
	static int pci_cmd646_ide_initfn(PCIDevice *dev)
	{
	PCIIDEState *d = DO_UPCAST(PCIIDEState, dev, dev);
	uint8_t *pci_conf = d->dev.config;
	qemu_irq *irq;
	int i;

	pci_conf[PCI_CLASS_PROG] = 0x8f;

	pci_conf[0x51] = 0x04; // enable IDE0
	if (d->secondary) {
	/* XXX: if not enabled, really disable the seconday IDE controller */
	pci_conf[0x51] \|= 0x08; /* enable IDE1 */
	}

	setup_cmd646_bar(d, 0);
	setup_cmd646_bar(d, 1);
	pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &d->cmd646_bar[0].data);
	pci_register_bar(dev, 1, PCI_BASE_ADDRESS_SPACE_IO, &d->cmd646_bar[0].cmd);
	pci_register_bar(dev, 2, PCI_BASE_ADDRESS_SPACE_IO, &d->cmd646_bar[1].data);
	pci_register_bar(dev, 3, PCI_BASE_ADDRESS_SPACE_IO, &d->cmd646_bar[1].cmd);
	bmdma_setup_bar(d);
	pci_register_bar(dev, 4, PCI_BASE_ADDRESS_SPACE_IO, &d->bmdma_bar);

	/* TODO: RST# value should be 0 */
	pci_conf[PCI_INTERRUPT_PIN] = 0x01; // interrupt on pin 1

	irq = qemu_allocate_irqs(cmd646_set_irq, d, 2);
	for (i = 0; i < 2; i++) {
	ide_bus_new(&d->bus[i], &d->dev.qdev, i);
	ide_init2(&d->bus[i], irq[i]);

	bmdma_init(&d->bus[i], &d->bmdma[i], d);
	d->bmdma[i].bus = &d->bus[i];
	qemu_add_vm_change_state_handler(d->bus[i].dma->ops->restart_cb,
	&d->bmdma[i].dma);
	}

	vmstate_register(&dev->qdev, 0, &vmstate_ide_pci, d);
	qemu_register_reset(cmd646_reset, d);
	return 0;
	}

	static void pci_cmd646_ide_exitfn(PCIDevice *dev)
	{
	PCIIDEState *d = DO_UPCAST(PCIIDEState, dev, dev);
	unsigned i;

	for (i = 0; i < 2; ++i) {
	memory_region_del_subregion(&d->bmdma_bar, &d->bmdma[i].extra_io);
	memory_region_destroy(&d->bmdma[i].extra_io);
	memory_region_del_subregion(&d->bmdma_bar, &d->bmdma[i].addr_ioport);
	memory_region_destroy(&d->bmdma[i].addr_ioport);
	memory_region_destroy(&d->cmd646_bar[i].cmd);
	memory_region_destroy(&d->cmd646_bar[i].data);
	}
	memory_region_destroy(&d->bmdma_bar);
	}

	void pci_cmd646_ide_init(PCIBus bus, DriveInfo *hd_table,
	int secondary_ide_enabled)
	{
	PCIDevice *dev;

	dev = pci_create(bus, -1, "cmd646-ide");
	qdev_prop_set_uint32(&dev->qdev, "secondary", secondary_ide_enabled);
	qdev_init_nofail(&dev->qdev);

	pci_ide_create_devs(dev, hd_table);
	}

	static Property cmd646_ide_properties[] = {
	DEFINE_PROP_UINT32("secondary", PCIIDEState, secondary, 0),
	DEFINE_PROP_END_OF_LIST(),
	};

	static void cmd646_ide_class_init(ObjectClass klass, void data)
	{
	DeviceClass *dc = DEVICE_CLASS(klass);
	PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);

	k->init = pci_cmd646_ide_initfn;
	k->exit = pci_cmd646_ide_exitfn;
	k->vendor_id = PCI_VENDOR_ID_CMD;
	k->device_id = PCI_DEVICE_ID_CMD_646;
	k->revision = 0x07;
	k->class_id = PCI_CLASS_STORAGE_IDE;
	dc->props = cmd646_ide_properties;
	}

	static TypeInfo cmd646_ide_info = {
	.name = "cmd646-ide",
	.parent = TYPE_PCI_DEVICE,
	.instance_size = sizeof(PCIIDEState),
	.class_init = cmd646_ide_class_init,
	};

	static void cmd646_ide_register_types(void)
	{
	type_register_static(&cmd646_ide_info);
	}

	type_init(cmd646_ide_register_types)