| commit | 7b43a2e19613f3702935872b21b1020f7d8c6a9b | [log] [tgz] |
|---|---|---|
| author | Eli Schwartz <eschwartz93@gmail.com> | Wed Jun 26 20:38:56 2024 -0400 |
| committer | Eli Schwartz <eschwartz93@gmail.com> | Wed Jun 26 21:35:09 2024 -0400 |
| tree | d963f6ab5bf6125bc45acae1f2b1d72a31054dd4 | |
| parent | ef83d943d96c5d73c09bd6e2abbfdbb15ae73029 [diff] |
depfixer: fix darwin regression when install rpaths are used Fixes regression in commit 78e9009ff9d36925e04f329f9082841002ddd848. new_rpath is only set when install_rpath appears in meson.build. Before this commit, we treated new_rpath as a single string to pass to -add_rpath. This worked as long as new_rpath had a single rpath in it, though for ELF we explicitly supported multiple rpaths separated with ":" (as binutils ld is quite happy with that too). install_name_tool does not support paths with colons in it: ``` 21:12 <awilfox> Load command 19 cmd LC_RPATH cmdsize 40 path /bar:/baz:/eli:/ldap (offset 12) 21:12 <awilfox> Load command 20 cmd LC_RPATH cmdsize 24 path /foo (offset 12) 21:14 <awilfox> so the result is: do not use colons ``` After commit 78e9009ff9d36925e04f329f9082841002ddd848, we simply ended up with one load command for LC_RPATH per char in new_rpath, which was wrong in every possible case. What we actually need to do is pass every distinct rpath as a separate `-add_rpath` argument, so we split it on the colons instead. We do the same splitting to ensure proper diff'ability for ELF anyways... Fixes #13355
Latest Meson version supporting previous Python versions:
Meson is available on PyPi, so it can be installed with pip3 install meson. The exact command to type to install with pip can vary between systems, be sure to use the Python 3 version of pip.
If you wish you can install it locally with the standard Python command:
python3 -m pip install meson
For builds using Ninja, Ninja can be downloaded directly from Ninja GitHub release page or via PyPi
python3 -m pip install ninja
More on Installing Meson build can be found at the getting meson page.
Meson can be run as a Python zip app. To generate the executable run the following command:
./packaging/create_zipapp.py --outfile meson.pyz --interpreter '/usr/bin/env python3' <source checkout>
Meson requires that you have a source directory and a build directory and that these two are different. In your source root must exist a file called meson.build. To generate the build system run this command:
meson setup <source directory> <build directory>
Depending on how you obtained Meson the command might also be called meson.py instead of plain meson. In the rest of this document we are going to use the latter form.
You can omit either of the two directories, and Meson will substitute the current directory and autodetect what you mean. This allows you to do things like this:
cd <source root> meson setup builddir
To compile, cd into your build directory and type ninja. To run unit tests, type ninja test.
More on running Meson build system commands can be found at the running meson page or by typing meson --help.
We love code contributions. See the contribution page on the website for details.
The channel to use is #mesonbuild either via Matrix (web interface) or OFTC IRC.
More information about the Meson build system can be found at the project's home page.
Meson is a registered trademark of Jussi Pakkanen.