tree d963f6ab5bf6125bc45acae1f2b1d72a31054dd4
parent ef83d943d96c5d73c09bd6e2abbfdbb15ae73029
author Eli Schwartz <eschwartz93@gmail.com> 1719448736 -0400
committer Eli Schwartz <eschwartz93@gmail.com> 1719452109 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQKqBAABCgCUFiEEYEETBMCdNmKDQO7/zrFn77VyK9YFAmZ8wd9fFIAAAAAALgAo
 aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYw
 NDExMzA0QzA5RDM2NjI4MzQwRUVGRkNFQjE2N0VGQjU3MjJCRDYWHGVzY2h3YXJ0
 ejkzQGdtYWlsLmNvbQAKCRDOsWfvtXIr1lWbD/wJyOrVawoY4X+mMyM3wZi3YBwk
 MXEnD5zCEqBZw7UP4S6pAaBhFZDgqyh5WYwKO8wgtgPnnZNju2B84P0Xby/j5nI0
 fDD4M4J3Ogaz81ckivCNwotuMdp7haXgY0BqH6WyLi8XN1gQco92y5Cwkl+fCDma
 H9R8t+fKqoccUDLk/bdu2S1XsrYkkkfDuGJYzN8N4n/+KmPBP7M7jm/POJ8BCAMT
 MyNHd+cmYAlo94yhErupvlGkIxvGjLEOhvE0zTYlzT6cb37/mQyzdiup+hhBtNb9
 pPrWLYNJeM0RJ2MF1x6Nb193MNbf00SsmmyXNvrdkuUje9Xwvvv9rVfMNKf+49Os
 c3EiC6QllBmKGjNBIYc8FQXSbnutk4o5jtZGngir1roIf7sdnTqI56dFxcvJZB8m
 1jCrErQtbjG/bwKfjYnS9dHiTEhDndEdKmHpg6AmZOJNa7VGXDaAW+fE1bIf9gbT
 uvQUFp1gc9lLCA4ZYeW+sw/x92Sle13w8s1na0iTiZY2h5vgboH51R/cdsv6ZXa8
 A/RKzgtSXmP6a6zpsxDZLWrJU/+0Q0twgdTTxNX9KjnO0clHyoskrtN1VbmD6w5D
 ek4C/IpuoQiGeg9XbQtdOI1VmLoG4JG4MfGgoEIHH830OQbSVtt+ZzLjQKACLZQV
 rvoTXyOtqLAO2uPgug==
 =y9iU
 -----END PGP SIGNATURE-----

depfixer: fix darwin regression when install rpaths are used

Fixes regression in commit 78e9009ff9d36925e04f329f9082841002ddd848.

new_rpath is only set when install_rpath appears in meson.build.

Before this commit, we treated new_rpath as a single string to pass to
-add_rpath. This worked as long as new_rpath had a single rpath in it,
though for ELF we explicitly supported multiple rpaths separated with
":" (as binutils ld is quite happy with that too).

install_name_tool does not support paths with colons in it:
```
21:12 <awilfox> Load command 19          cmd LC_RPATH      cmdsize 40         path /bar:/baz:/eli:/ldap (offset 12)
21:12 <awilfox> Load command 20          cmd LC_RPATH      cmdsize 24         path /foo (offset 12)
21:14 <awilfox> so the result is: do not use colons
```

After commit 78e9009ff9d36925e04f329f9082841002ddd848, we simply ended
up with one load command for LC_RPATH per char in new_rpath, which was
wrong in every possible case.

What we actually need to do is pass every distinct rpath as a separate
`-add_rpath` argument, so we split it on the colons instead. We do the
same splitting to ensure proper diff'ability for ELF anyways...

Fixes #13355