FSP/LED: Validate before creating LED nodes
If FSP messes up SLCA data then attention location code points
to some other location code and its possible that we may endup
in duplicate LED location code :-(
Better to continue with partial LED list than crashing OPAL because
of duplicate node in device tree.
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
[stewart@linux.vnet.ibm.com: prlog(PR_WARNING) on duplicate found]
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
diff --git a/hw/fsp/fsp-leds.c b/hw/fsp/fsp-leds.c
index dd6cacf..c9dc70a 100644
--- a/hw/fsp/fsp-leds.c
+++ b/hw/fsp/fsp-leds.c
@@ -1319,6 +1319,13 @@
/* LED child nodes */
list_for_each_safe(&cec_ledq, led, next, link) {
+ /* Duplicate LED location code */
+ if (dt_find_by_path(pled, led->loc_code)) {
+ prlog(PR_WARNING, PREFIX "duplicate location code %s",
+ led->loc_code);
+ continue;
+ }
+
cled = dt_new(pled, led->loc_code);
if (!cled) {
prlog(PR_WARNING, PREFIX
