commit 192e23b78418abc23a92a7174ae2294fabe4b8a3
author Daniel Verkamp <daniel@drv.nu> Mon Mar 11 20:26:18 2024 -0700
committer Kevin O'Connor <kevin@koconnor.net> Fri Mar 15 10:27:52 2024 -0400
tree 7f2da3085815b1118794db01db823328d95ed9d3
parent 3722c21de19ba64de56495502c0c025b913a9b15

vbe: implement function 09h (get/set palette data)

Since the VBE mode attributes indicate that all modes are not VGA
compatible, applications must use VBE function 09h to manipulate the
palette rather than directly accessing the VGA registers.

This implementation uses the standard VGA registers for all hardware,
which may not be appropriate; I only verified qemu -device VGA.

Without this patch, the get/set palette function returns an error code,
so programs that use 8-bit indexed color modes fail. For example, Quake
(DOS) printed "Error: Unable to load VESA palette" and exited when
trying to set a SVGA mode like 640x480, but with the patch it succeeds.
This fixes qemu issue #251 and #1862.

<https://gitlab.com/qemu-project/qemu/-/issues/251>
<https://gitlab.com/qemu-project/qemu/-/issues/1862>

Signed-off-by: Daniel Verkamp <daniel@drv.nu>
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>

vgasrc/vbe.c

diff --git a/vgasrc/vbe.c b/vgasrc/vbe.c
index 20437db..d7ce941 100644
--- a/vgasrc/vbe.c
+++ b/vgasrc/vbe.c
@@ -377,6 +377,63 @@
 }
 
 static void
+vbe_104f09(struct bregs *regs)
+{
+    if (!CONFIG_VGA_STDVGA_PORTS) {
+        // DAC palette support only available on devices with stdvga ports
+        regs->ax = 0x0100;
+        return;
+    }
+
+    struct vgamode_s *vmode_g = get_current_mode();
+    if (! vmode_g)
+        goto fail;
+    u8 memmodel = GET_GLOBAL(vmode_g->memmodel);
+    u8 depth = GET_GLOBAL(vmode_g->depth);
+    if (memmodel == MM_DIRECT || memmodel == MM_YUV || depth > 8) {
+        regs->ax = 0x034f;
+        return;
+    }
+    if (regs->dh)
+        goto fail;
+    u8 start = regs->dl;
+    int count = regs->cx;
+    int max_colors = 1 << depth;
+    if (start + count > max_colors)
+        goto fail;
+    u16 seg = regs->es;
+    u8 *data_far = (void*)(regs->di+0);
+    u8 rgb[3];
+    int i;
+    switch (regs->bl) {
+    case 0x80:
+    case 0x00:
+        for (i = 0; i < count; i++) {
+            rgb[0] = GET_FARVAR(seg, data_far[i*4 + 2]);
+            rgb[1] = GET_FARVAR(seg, data_far[i*4 + 1]);
+            rgb[2] = GET_FARVAR(seg, data_far[i*4 + 0]);
+            stdvga_dac_write(GET_SEG(SS), rgb, start + i, 1);
+        }
+        break;
+    case 0x01:
+        for (i = 0; i < count; i++) {
+            stdvga_dac_read(GET_SEG(SS), rgb, start + i, 1);
+            SET_FARVAR(seg, data_far[i*4 + 0], rgb[2]);
+            SET_FARVAR(seg, data_far[i*4 + 1], rgb[1]);
+            SET_FARVAR(seg, data_far[i*4 + 2], rgb[0]);
+            SET_FARVAR(seg, data_far[i*4 + 3], 0);
+        }
+        break;
+    default:
+        goto fail;
+    }
+    regs->ax = 0x004f;
+    return;
+fail:
+    regs->ax = 0x014f;
+}
+
+static void
 vbe_104f0a(struct bregs *regs)
 {
     debug_stub(regs);
@@ -456,6 +513,7 @@
     case 0x06: vbe_104f06(regs); break;
     case 0x07: vbe_104f07(regs); break;
     case 0x08: vbe_104f08(regs); break;
+    case 0x09: vbe_104f09(regs); break;
     case 0x0a: vbe_104f0a(regs); break;
     case 0x10: vbe_104f10(regs); break;
     case 0x15: vbe_104f15(regs); break;