Google Git
Sign in
qemu / qemu / 196137c1c6653adf6a49889814fe1d209d937861
commit196137c1c6653adf6a49889814fe1d209d937861[log] [tgz]
authorAkihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>Tue Jun 03 18:18:28 2025 +0900
committerMichael Tokarev <mjt@tls.msk.ru>Wed Jul 16 18:07:57 2025 +0300
treedc0f97dd16faf391427a02180fcfde1ad4127dc4
parent385eb77f6051d265322782a6f53a89bca9967d61 [diff]
ui/vnc: Do not copy z_stream

vnc_worker_thread_loop() copies z_stream stored in its local VncState to
the persistent VncState, and the copied one is freed with deflateEnd()
later. However, deflateEnd() refuses to operate with a copied z_stream
and returns Z_STREAM_ERROR, leaking the allocated memory.

Avoid copying the zlib state to fix the memory leak.

Fixes: bd023f953e5e ("vnc: threaded VNC server")
Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20250603-zlib-v3-1-20b857bd8d05@rsg.ci.i.u-tokyo.ac.jp>
(cherry picked from commit aef22331b5a4670f42638a5f63a26e93bf779aae)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
3 files changed
tree: dc0f97dd16faf391427a02180fcfde1ad4127dc4
  1. .github/
  2. .gitlab/
  3. .gitlab-ci.d/
  4. accel/
  5. audio/
  6. authz/
  7. backends/
  8. block/
  9. bsd-user/
  10. chardev/
  11. common-user/
  12. configs/
  13. contrib/
  14. crypto/
  15. disas/
  16. docs/
  17. dump/
  18. ebpf/
  19. fpu/
  20. fsdev/
  21. gdb-xml/
  22. gdbstub/
  23. hw/
  24. include/
  25. io/
  26. libdecnumber/
  27. linux-headers/
  28. linux-user/
  29. migration/
  30. monitor/
  31. nbd/
  32. net/
  33. pc-bios/
  34. plugins/
  35. po/
  36. python/
  37. qapi/
  38. qga/
  39. qobject/
  40. qom/
  41. replay/
  42. roms/
  43. scripts/
  44. scsi/
  45. semihosting/
  46. softmmu/
  47. storage-daemon/
  48. stubs/
  49. subprojects/
  50. target/
  51. tcg/
  52. tests/
  53. tools/
  54. trace/
  55. ui/
  56. util/
  57. dtc
  58. meson
  59. .dir-locals.el
  60. .editorconfig
  61. .exrc
  62. .gdbinit
  63. .gitattributes
  64. .gitignore
  65. .gitlab-ci.yml
  66. .gitmodules
  67. .gitpublish
  68. .mailmap
  69. .patchew.yml
  70. .readthedocs.yml
  71. .travis.yml
  72. block.c
  73. blockdev-nbd.c
  74. blockdev.c
  75. blockjob.c
  76. configure
  77. COPYING
  78. COPYING.LIB
  79. cpu.c
  80. cpus-common.c
  81. disas.c
  82. event-loop-base.c
  83. gitdm.config
  84. hmp-commands-info.hx
  85. hmp-commands.hx
  86. iothread.c
  87. job-qmp.c
  88. job.c
  89. Kconfig
  90. Kconfig.host
  91. LICENSE
  92. MAINTAINERS
  93. Makefile
  94. memory_ldst.c.inc
  95. meson.build
  96. meson_options.txt
  97. module-common.c
  98. os-posix.c
  99. os-win32.c
  100. page-vary-common.c
  101. page-vary.c
  102. qemu-bridge-helper.c
  103. qemu-edid.c
  104. qemu-img-cmds.hx
  105. qemu-img.c
  106. qemu-io-cmds.c
  107. qemu-io.c
  108. qemu-keymap.c
  109. qemu-nbd.c
  110. qemu-options.hx
  111. qemu.nsi
  112. qemu.sasl
  113. README.rst
  114. replication.c
  115. trace-events
  116. VERSION
  117. version.rc