tree 387191310b427ec97e0a8fd2d43df3bc8e2059a6
parent 4859da572b41d93339b2dbfc80a70ab9cd9aea7d
author Peter Maydell <peter.maydell@linaro.org> 1699036070 +0000
committer Peter Maydell <peter.maydell@linaro.org> 1706268647 +0000

hw/arm/musicpal: Convert to qemu_add_kbd_event_handler()

Convert the musicpal key input device to use
qemu_add_kbd_event_handler().  This lets us simplify it because we no
longer need to track whether we're in the middle of a PS/2 multibyte
key sequence.

In the conversion we move the keyboard handler registration from init
to realize, because devices shouldn't disturb the state of the
simulation by doing things like registering input handlers until
they're realized, so that device objects can be introspected
safely.

The behaviour where key-repeat is permitted for the arrow-keys only
is intentional (added in commit 7c6ce4baedfcd0c), so we retain it,
and add a comment to that effect.

This is a migration compatibility break for musicpal.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 20231103182750.855577-1-peter.maydell@linaro.org