Google Git
Sign in
qemu / qemu / b26c3f9cbd784a5f7db68049fd9c49a0a2077734
commitb26c3f9cbd784a5f7db68049fd9c49a0a2077734[log] [tgz]
authorDaniel P. Berrangé <berrange@redhat.com>Thu Mar 14 14:45:08 2019 +0000
committerDaniel P. Berrangé <berrange@redhat.com>Tue Apr 02 13:46:33 2019 +0100
tree0d5f60a709365de7d7aaa8a1320a5eeb78a84779
parentd61d1a1fb2f1db6c54651844a28389c523f3f8c7 [diff]
tests: refactor file monitor test to make it more understandable

The current file monitor unit tests are too clever for their own good
making it hard to understand the desired output.

Instead of trying to infer the expected events, explicitly list the
events we expect in the operation sequence.

Instead of dynamically building a matrix of tests, just have one giant
operation sequence that validates all scenarios in a single test.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
1 file changed
tree: 0d5f60a709365de7d7aaa8a1320a5eeb78a84779
  1. accel/
  2. audio/
  3. authz/
  4. backends/
  5. block/
  6. bsd-user/
  7. chardev/
  8. contrib/
  9. crypto/
  10. default-configs/
  11. disas/
  12. docs/
  13. fpu/
  14. fsdev/
  15. gdb-xml/
  16. hw/
  17. include/
  18. io/
  19. libdecnumber/
  20. linux-headers/
  21. linux-user/
  22. migration/
  23. nbd/
  24. net/
  25. pc-bios/
  26. po/
  27. python/
  28. qapi/
  29. qga/
  30. qobject/
  31. qom/
  32. replay/
  33. roms/
  34. scripts/
  35. scsi/
  36. slirp/
  37. stubs/
  38. target/
  39. tcg/
  40. tests/
  41. trace/
  42. ui/
  43. util/
  44. capstone
  45. dtc
  46. .cirrus.yml
  47. .dir-locals.el
  48. .editorconfig
  49. .exrc
  50. .gdbinit
  51. .gitignore
  52. .gitlab-ci.yml
  53. .gitmodules
  54. .gitpublish
  55. .mailmap
  56. .shippable.yml
  57. .travis.yml
  58. arch_init.c
  59. balloon.c
  60. block.c
  61. blockdev-nbd.c
  62. blockdev.c
  63. blockjob.c
  64. bootdevice.c
  65. bt-host.c
  66. bt-vhci.c
  67. Changelog
  68. CODING_STYLE
  69. configure
  70. COPYING
  71. COPYING.LIB
  72. cpus-common.c
  73. cpus.c
  74. device-hotplug.c
  75. device_tree.c
  76. disas.c
  77. dma-helpers.c
  78. dump.c
  79. exec.c
  80. gdbstub.c
  81. gitdm.config
  82. HACKING
  83. hmp-commands-info.hx
  84. hmp-commands.hx
  85. hmp.c
  86. hmp.h
  87. ioport.c
  88. iothread.c
  89. job-qmp.c
  90. job.c
  91. Kconfig.host
  92. LICENSE
  93. MAINTAINERS
  94. Makefile
  95. Makefile.objs
  96. Makefile.target
  97. memory.c
  98. memory_ldst.inc.c
  99. memory_mapping.c
  100. module-common.c
  101. monitor.c
  102. numa.c
  103. os-posix.c
  104. os-win32.c
  105. qdev-monitor.c
  106. qemu-bridge-helper.c
  107. qemu-deprecated.texi
  108. qemu-doc.texi
  109. qemu-edid.c
  110. qemu-ga.texi
  111. qemu-img-cmds.hx
  112. qemu-img.c
  113. qemu-img.texi
  114. qemu-io-cmds.c
  115. qemu-io.c
  116. qemu-keymap.c
  117. qemu-nbd.c
  118. qemu-nbd.texi
  119. qemu-option-trace.texi
  120. qemu-options-wrapper.h
  121. qemu-options.h
  122. qemu-options.hx
  123. qemu-seccomp.c
  124. qemu-tech.texi
  125. qemu.nsi
  126. qemu.sasl
  127. qmp.c
  128. qtest.c
  129. README
  130. replication.c
  131. replication.h
  132. rules.mak
  133. thunk.c
  134. tpm.c
  135. trace-events
  136. VERSION
  137. version.rc
  138. vl.c
  139. win_dump.c
  140. win_dump.h