)]}'
{
  "commit": "fd41dd4eae5f7ea92f10c04cb3f217727fcee91f",
  "tree": "04cf70812be04f55d4a4aa5cd770a7ab5b1ec6eb",
  "parents": [
    "2cbf09925ad45401673a79ab77f67de2f04a826c"
  ],
  "author": {
    "name": "Eric Blake",
    "email": "eblake@redhat.com",
    "time": "Mon May 04 09:05:25 2015 -0600"
  },
  "committer": {
    "name": "Markus Armbruster",
    "email": "armbru@redhat.com",
    "time": "Tue May 05 18:39:01 2015 +0200"
  },
  "message": "qapi: Prefer \u0027struct\u0027 over \u0027type\u0027 in generator\n\nReferring to \"type\" as both a meta-type (built-in, enum, union,\nalternate, or struct) and a specific type (the name that the\nschema uses for declaring structs) is confusing.  The confusion\nis only made worse by the fact that the generator mostly already\nrefers to struct even when dealing with expr[\u0027type\u0027].  This\ncommit changes the generator to consistently refer to it as\nstruct everywhere, plus a single back-compat tweak that allows\naccepting the existing .json files as-is, so that the meat of\nthis change is separate from the mindless churn of that change.\n\nFix the testsuite fallout for error messages that change, and\nin some cases, become more legible.  Improve comments to better\nmatch our intentions where a struct (rather than any complex\ntype) is required.  Note that in some cases, an error message\nnow refers to \u0027struct\u0027 while the schema still refers to \u0027type\u0027;\nthat will be cleaned up in the later commit to the schema.\n\nSigned-off-by: Eric Blake \u003ceblake@redhat.com\u003e\nReviewed-by: Markus Armbruster \u003carmbru@redhat.com\u003e\nSigned-off-by: Markus Armbruster \u003carmbru@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9c8d68cfb4aac5769dda650bbc0266148c92c194",
      "old_mode": 33188,
      "old_path": "scripts/qapi-types.py",
      "new_id": "a429d9ec055f3c71d4693b9d0d72a68fb116afbf",
      "new_mode": 33188,
      "new_path": "scripts/qapi-types.py"
    },
    {
      "type": "modify",
      "old_id": "9222671ff824bc8365be2cc789bc49b2ccd4715c",
      "old_mode": 33188,
      "old_path": "scripts/qapi-visit.py",
      "new_id": "c739a95a87efc5b37af0077d713eb6e086598ee2",
      "new_mode": 33188,
      "new_path": "scripts/qapi-visit.py"
    },
    {
      "type": "modify",
      "old_id": "e391b5a649a670fb67d9520d22f6d64db16c2197",
      "old_mode": 33188,
      "old_path": "scripts/qapi.py",
      "new_id": "e50fec826bd6f8ba2bac16f65f51484494dabcc8",
      "new_mode": 33188,
      "new_path": "scripts/qapi.py"
    },
    {
      "type": "modify",
      "old_id": "c3a6b7723c5d09487ebdf92a5e9ea1782b343cdd",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/alternate-good.out",
      "new_id": "99848eefbb7493d179cb7cf793d6b5ea0ff3529c",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/alternate-good.out"
    },
    {
      "type": "modify",
      "old_id": "f398bbb7d3f41d2dbfcf7ba8b76829288f699918",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/bad-base.err",
      "new_id": "154274bdd3f2678da93b90328976892be6e10503",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/bad-base.err"
    },
    {
      "type": "modify",
      "old_id": "42b490ce0b26e1f9cabe56012481fb1e0eb0b18b",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/bad-ident.err",
      "new_id": "c4190602b5c4f552b4fea0fe3d6f9e186134cd11",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/bad-ident.err"
    },
    {
      "type": "modify",
      "old_id": "de6168c82d6f06c6fe87e8eb6495871726707a50",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/bad-type-bool.err",
      "new_id": "62fd70baafd63ec5e37ecd445663959bcb9023df",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/bad-type-bool.err"
    },
    {
      "type": "modify",
      "old_id": "82871204ed4499ac2773ac63ce09dd19c190919d",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/data-member-array.out",
      "new_id": "c39fa254843a49988a557e94a5c9e91debfa6b41",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/data-member-array.out"
    },
    {
      "type": "modify",
      "old_id": "ceb6e46cfed15edcecd68e1e1383aa792efbc3c9",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/double-type.err",
      "new_id": "f9613c6d6b53b4c07d40b280979a846745157970",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/double-type.err"
    },
    {
      "type": "modify",
      "old_id": "bb0f02d298a14515df1eec12a735ef7df5bb71af",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/flat-union-bad-base.json",
      "new_id": "d41c80c3bdc84928c4699aeaf4c9b79d04677558",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/flat-union-bad-base.json"
    },
    {
      "type": "modify",
      "old_id": "60e47efab58df62039e2925f889b3599fdb2610e",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/flat-union-base-star.err",
      "new_id": "b7748f08bfdff0c170c1282107034c8f541dfa7c",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/flat-union-base-star.err"
    },
    {
      "type": "modify",
      "old_id": "994533a514e50cb11d283ec80c5006e79eb3d975",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/flat-union-base-star.json",
      "new_id": "76724075b16d3f46f18b8df19e5283c85b118d57",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/flat-union-base-star.json"
    },
    {
      "type": "modify",
      "old_id": "185bf51a72aa2a38d7bc12ec7c7d63ce591a4cbe",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/flat-union-base-union.err",
      "new_id": "ede9859a398e2b1e3fb2c227f053ea4225d2117c",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/flat-union-base-union.err"
    },
    {
      "type": "modify",
      "old_id": "838986c48a5eb0792368cbbde6d501b21b9f6ea5",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/flat-union-base-union.json",
      "new_id": "0ba6e28d3be4443143946a30aa71ae2aa9973fa9",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/flat-union-base-union.json"
    },
    {
      "type": "modify",
      "old_id": "5d541133b9364d4c26ea02a310a2ee89622f966e",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/flat-union-branch-clash.out",
      "new_id": "04c239565e6fcd1678e27fe7be17cd35f4d2b3aa",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/flat-union-branch-clash.out"
    },
    {
      "type": "modify",
      "old_id": "f3da1175f885e9f38dd9742d6119d323a3b9bcaf",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/flat-union-inline.json",
      "new_id": "65c15d0a1e53b5911aa28c63c378b7a3c29321b9",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/flat-union-inline.json"
    },
    {
      "type": "modify",
      "old_id": "d373131653dfa2372eda9dd9fe935a137da4e800",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/flat-union-int-branch.json",
      "new_id": "ee93cf803abf67be0fb458a0961e95a02c645240",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/flat-union-int-branch.json"
    },
    {
      "type": "modify",
      "old_id": "790b6759b8348fd6d06d00696a43845ed7d6bb96",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/flat-union-invalid-discriminator.err",
      "new_id": "5f4055614eab17214adf2e8da4b543bac3083bd9",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/flat-union-invalid-discriminator.err"
    },
    {
      "type": "modify",
      "old_id": "03c952e28a8c6aa6d858310ef053a9f3eacbbc60",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/flat-union-reverse-define.out",
      "new_id": "1ed7b8a51900758e85703132a91ce100f8b1981c",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/flat-union-reverse-define.out"
    },
    {
      "type": "modify",
      "old_id": "313ecf3ad38829a0544b9d8156611be4ec2a20c1",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/qapi-schema-test.out",
      "new_id": "83ab1a51390c42e2e935574ec39b66c75c9585e2",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/qapi-schema-test.out"
    },
    {
      "type": "modify",
      "old_id": "3cc82c0701cffb68d4023680d3f100aed2bcd5eb",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/union-invalid-base.err",
      "new_id": "9f637963e8f43c8124ce4569bf13be4ff2d88794",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/union-invalid-base.err"
    },
    {
      "type": "modify",
      "old_id": "0a35bfdbd62e4843dec8e03dc39cb28d98cf7d38",
      "old_mode": 33188,
      "old_path": "tests/qapi-schema/unknown-expr-key.err",
      "new_id": "12f5ed5b435bab9a6aaf487b9a8a9ca3a5e73408",
      "new_mode": 33188,
      "new_path": "tests/qapi-schema/unknown-expr-key.err"
    }
  ]
}