commit fbfc29e3bf145581e84c12ffc432ab56ce1dea0d
author Kevin Wolf <kwolf@redhat.com> Thu Jun 13 17:34:04 2019 +0200
committer Markus Armbruster <armbru@redhat.com> Tue Jun 18 08:14:17 2019 +0200
tree 2922c5fadb07f55fb45b816bdd1806c4cfcaed46
parent 920824165c49bfbd1e0e9e07fd92e0bbbf32aea3

monitor: Replace monitor_init() with monitor_init_{hmp, qmp}()

Most callers know which monitor type they want to have. Instead of
calling monitor_init() with flags that can describe both types of
monitors, make monitor_init_{hmp,qmp}() public interfaces that take
specific bools instead of flags and call these functions directly.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20190613153405.24769-15-kwolf@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>

gdbstub.c

diff --git a/gdbstub.c b/gdbstub.c
index d614a1f..8618e34 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -3344,7 +3344,7 @@
         /* Initialize a monitor terminal for gdb */
         mon_chr = qemu_chardev_new(NULL, TYPE_CHARDEV_GDB,
                                    NULL, NULL, &error_abort);
-        monitor_init(mon_chr, 0);
+        monitor_init_hmp(mon_chr, false);
     } else {
         qemu_chr_fe_deinit(&s->chr, true);
         mon_chr = s->mon_chr;