)]}'
{
  "commit": "fbf4fa1091046fd58f60281134d904e2fb377752",
  "tree": "4b37e217c56ee14a091d6af8fa7e92fd70e09ff7",
  "parents": [
    "46a25ae3f0e75e230c06e21435850b1cd1c44f07"
  ],
  "author": {
    "name": "Daniel P. Berrangé",
    "email": "berrange@redhat.com",
    "time": "Tue Feb 10 16:35:53 2026 +0000"
  },
  "committer": {
    "name": "Thomas Huth",
    "email": "thuth@redhat.com",
    "time": "Mon Mar 02 09:48:10 2026 +0100"
  },
  "message": "tests/docker: improve handling of docker probes\n\nThe docker.py script has logic to guess the container command and\ndetects one of\n\n  * docker\n  * sudo -n docker\n  * podman\n\nbut the \"docker.py probe\" command then throws away the detected argv\nand prints a slightly different argv based solely on the detected\nargv[0]. The result is that \u0027probe\u0027 will print\n\n  * docker\n  * sudo docker\n  * podman\n\nwhich means that if sudo was detected \u0026 the result of \u0027probe\u0027 were\nused directly, it would end up prompting for password interaction\nevery time.\n\nThe \u0027configure\u0027 script, however, runs \u0027probe\u0027 and then throws away\nthe printed argv again, reporting only \u0027podman\u0027 or \u0027docker\u0027, which\nis used to set the $(RUNC) variable for tests/docker/Makefile.include\nwhich is in turn used to pass --engine to docker.py. So the docker.py\ncommand will re-detect the need for \u0027sudo -n\u0027 and use it correctly\n\nThe problem with this is that some commands in Makefile.include do\nnot call docker.py at all, they invoke $(RUNC) directly. Since\nconfigure threw away the \u0027sudo\u0027 command prefix Makefile.in won\u0027t\nbe adding either \u0027sudo\u0027 or \u0027sudo -n\u0027, it\u0027ll just run plain \u0027docker\u0027\nwhich is wrong.\n\nThis commit sanitizes things so that the \u0027docker.py probe\u0027 prints\nout the exact detected ARGV, and configure fully preserves this\nARGV when setting $(RUNC). Since \"$(RUNC)\" is no longer just a bare\nengine name, however, we must now also set the $(CONTAINER_ENGINE)\nvariable for Makefile.include so it can pass something sane to\nthe --engine arg for docker.py\n\nReviewed-by: Thomas Huth \u003cthuth@redhat.com\u003e\nSigned-off-by: Daniel P. Berrangé \u003cberrange@redhat.com\u003e\nMessage-ID: \u003c20260210163556.713841-2-berrange@redhat.com\u003e\nSigned-off-by: Thomas Huth \u003cthuth@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "5e114acea28d0d0b8909f3c9e6fa19edb4c52dc5",
      "old_mode": 33261,
      "old_path": "configure",
      "new_id": "b99ba65d71861be937f5b7f41a2db5e9c7ee8a5b",
      "new_mode": 33261,
      "new_path": "configure"
    },
    {
      "type": "modify",
      "old_id": "38467cca610411a0299b7ead459965f4d12f8de5",
      "old_mode": 33188,
      "old_path": "tests/docker/Makefile.include",
      "new_id": "7d4582b6a8d6c107901f51f7fff3edfb9e750556",
      "new_mode": 33188,
      "new_path": "tests/docker/Makefile.include"
    },
    {
      "type": "modify",
      "old_id": "3b8a26704df1987dac947219a3cea47a6121f0b9",
      "old_mode": 33261,
      "old_path": "tests/docker/docker.py",
      "new_id": "ff68c7bf6f21ef1a1ddf880182720d286e3f7300",
      "new_mode": 33261,
      "new_path": "tests/docker/docker.py"
    }
  ]
}