commit fa8053841efebab7fcdc76252b953f8dafe7a343
author Zhenzhong Duan <zhenzhong.duan@intel.com> Wed May 22 19:01:06 2024 +0200
committer Thomas Huth <thuth@redhat.com> Mon Jun 24 08:03:34 2024 +0200
tree 6e47ec42e7a08d5aa06838bbc55e8846cf9ec3dc
parent 1aeebbd6213af1aef09b4906c487f9079a5d8947

vfio/ccw: Fix the missed unrealize() call in error path

When get name failed, we should call unrealize() so that
vfio_ccw_realize() is self contained.

Fixes: 909a6254eda ("vfio/ccw: Make vfio cdev pre-openable by passing a file handle")
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20240522170107.289532-7-clg@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>

hw/vfio/ccw.c

diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
index a468fa2..36f2677 100644
--- a/hw/vfio/ccw.c
+++ b/hw/vfio/ccw.c
@@ -588,7 +588,7 @@
     }
 
     if (!vfio_device_get_name(vbasedev, errp)) {
-        return;
+        goto out_unrealize;
     }
 
     if (!vfio_attach_device(cdev->mdevid, vbasedev,
@@ -631,6 +631,7 @@
     vfio_detach_device(vbasedev);
 out_attach_dev_err:
     g_free(vbasedev->name);
+out_unrealize:
     if (cdc->unrealize) {
         cdc->unrealize(cdev);
     }