commit f988388025c230ef3293cc0c3820cb40e03adfbf
author Stefan Weil <sw@weilnetz.de> Wed Mar 05 22:23:00 2014 +0100
committer Stefan Hajnoczi <stefanha@redhat.com> Thu Mar 13 14:42:24 2014 +0100
tree 0937333939b9627ee21cdb7385bc1152a70acbfe
parent 9562f69cfdc55c7c1625bb88df1637fed182e68b

qemu-io: Fix warnings from static code analysis

Smatch complains about several global symbols which should be local.

Add the missing 'static' attributes and move the 'extern' declaration
of variable qemuio_misalign to qemu-io.h. This variable also changes
the type from 'int' to 'bool' which better fits documents its use.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

include/qemu-io.h

diff --git a/include/qemu-io.h b/include/qemu-io.h
index 7e7c07c..5d6006f 100644
--- a/include/qemu-io.h
+++ b/include/qemu-io.h
@@ -38,6 +38,8 @@
     helpfunc_t  help;
 } cmdinfo_t;
 
+extern bool qemuio_misalign;
+
 bool qemuio_command(BlockDriverState *bs, const char *cmd);
 
 void qemuio_add_command(const cmdinfo_t *ci);