commit f5bdd781316d2ba140323cb98392e44cac54017d
author Peter Maydell <peter.maydell@linaro.org> Mon May 14 18:30:43 2018 +0100
committer Michael Tokarev <mjt@tls.msk.ru> Sun May 20 08:55:54 2018 +0300
tree ca78244d68e2b82b637c30fb9023b1a39b896e66
parent d29eb678bcfbb2fbf4b79423797253ee02f5c6cf

gdbstub: Use qemu_set_cloexec()

Use the utility routine qemu_set_cloexec() rather than
manually calling fcntl(). This lets us drop the #ifndef _WIN32
guards and also means Coverity doesn't complain that we're
ignoring the fcntl error return (CID 1005665, CID 1005667).

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

gdbstub.c

diff --git a/gdbstub.c b/gdbstub.c
index 9682e16..b99980d 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1828,9 +1828,7 @@
             perror("accept");
             return;
         } else if (fd >= 0) {
-#ifndef _WIN32
-            fcntl(fd, F_SETFD, FD_CLOEXEC);
-#endif
+            qemu_set_cloexec(fd);
             break;
         }
     }
@@ -1857,9 +1855,7 @@
         perror("socket");
         return -1;
     }
-#ifndef _WIN32
-    fcntl(fd, F_SETFD, FD_CLOEXEC);
-#endif
+    qemu_set_cloexec(fd);
 
     socket_set_fast_reuse(fd);