Google Git
Sign in
qemu / qemu / f24ec9feadfed032a91e06cb3c564db533d5ff11
commitf24ec9feadfed032a91e06cb3c564db533d5ff11[log] [tgz]
authorClaudio Imbrenda <imbrenda@linux.ibm.com>Thu Nov 28 13:33:57 2019 +0100
committerThomas Huth <thuth@redhat.com>Fri Nov 29 09:16:02 2019 +0100
tree41b11a84548ce64765654a02c6cfffb40bebb11a
parent1a61a081ac33ae6cb7dd2e38d119a572f416c7f7 [diff]
pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

The existing s390 bios gets the LOADPARM information from the system using
an SCLP call that specifies a buffer length too small to contain all the
output.

The recent fixes in the SCLP code have exposed this bug, since now the
SCLP call will return an error (as per architecture) instead of
writing partially and completing successfully.

The solution is simply to specify the full page length as the SCCB
length instead of a smaller size.

Fixes: 832be0d8a3bb ("s390x: sclp: Report insufficient SCCB length")
Fixes: 9a22473c70f3 ("pc-bios/s390-ccw: get LOADPARM stored in SCP Read Info")

Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Message-Id: <1574944437-31182-1-git-send-email-imbrenda@linux.ibm.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
Tested-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
1 file changed
tree: 41b11a84548ce64765654a02c6cfffb40bebb11a
  1. accel/
  2. audio/
  3. authz/
  4. backends/
  5. block/
  6. bsd-user/
  7. chardev/
  8. contrib/
  9. crypto/
  10. default-configs/
  11. disas/
  12. docs/
  13. dump/
  14. fpu/
  15. fsdev/
  16. gdb-xml/
  17. hw/
  18. include/
  19. io/
  20. libdecnumber/
  21. linux-headers/
  22. linux-user/
  23. migration/
  24. monitor/
  25. nbd/
  26. net/
  27. pc-bios/
  28. plugins/
  29. po/
  30. python/
  31. qapi/
  32. qga/
  33. qobject/
  34. qom/
  35. replay/
  36. roms/
  37. scripts/
  38. scsi/
  39. stubs/
  40. target/
  41. tcg/
  42. tests/
  43. trace/
  44. ui/
  45. util/
  46. capstone
  47. dtc
  48. slirp
  49. .cirrus.yml
  50. .dir-locals.el
  51. .editorconfig
  52. .exrc
  53. .gdbinit
  54. .gitignore
  55. .gitlab-ci.yml
  56. .gitmodules
  57. .gitpublish
  58. .mailmap
  59. .patchew.yml
  60. .shippable.yml
  61. .travis.yml
  62. arch_init.c
  63. balloon.c
  64. block.c
  65. blockdev-nbd.c
  66. blockdev.c
  67. blockjob.c
  68. bootdevice.c
  69. bt-host.c
  70. bt-vhci.c
  71. Changelog
  72. CODING_STYLE.rst
  73. configure
  74. COPYING
  75. COPYING.LIB
  76. cpus-common.c
  77. cpus.c
  78. device-hotplug.c
  79. device_tree.c
  80. disas.c
  81. dma-helpers.c
  82. exec-vary.c
  83. exec.c
  84. gdbstub.c
  85. gitdm.config
  86. hmp-commands-info.hx
  87. hmp-commands.hx
  88. ioport.c
  89. iothread.c
  90. job-qmp.c
  91. job.c
  92. Kconfig.host
  93. LICENSE
  94. MAINTAINERS
  95. Makefile
  96. Makefile.objs
  97. Makefile.target
  98. memory.c
  99. memory_ldst.inc.c
  100. memory_mapping.c
  101. module-common.c
  102. os-posix.c
  103. os-win32.c
  104. qdev-monitor.c
  105. qemu-bridge-helper.c
  106. qemu-deprecated.texi
  107. qemu-doc.texi
  108. qemu-edid.c
  109. qemu-img-cmds.hx
  110. qemu-img.c
  111. qemu-img.texi
  112. qemu-io-cmds.c
  113. qemu-io.c
  114. qemu-keymap.c
  115. qemu-nbd.c
  116. qemu-nbd.texi
  117. qemu-option-trace.texi
  118. qemu-options-wrapper.h
  119. qemu-options.h
  120. qemu-options.hx
  121. qemu-seccomp.c
  122. qemu-tech.texi
  123. qemu.nsi
  124. qemu.sasl
  125. qtest.c
  126. README.rst
  127. replication.c
  128. replication.h
  129. rules.mak
  130. thunk.c
  131. tpm.c
  132. trace-events
  133. VERSION
  134. version.rc
  135. vl.c