commit f160a5b25b33b69b089815cfd435aa3199497984
author Dinah Baum <dinahbaum123@gmail.com> Tue Feb 21 06:06:30 2023 -0500
committer Thomas Huth <thuth@redhat.com> Mon Feb 27 09:15:39 2023 +0100
tree 831b490b003305502720f3992eb3b795fd20f047
parent c8db90b86d0849b59452b8cac5b477bb65dcb6a1

configure: Add 'mkdir build' check

QEMU configure script goes into an infinite error printing loop
when in read only directory due to 'build' dir never being created.

Checking if 'mkdir dir' succeeds prevents this error.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/321
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Dinah Baum <dinahbaum123@gmail.com>
Message-Id: <20230221110631.4142-1-dinahbaum123@gmail.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
[thuth: Remove second "touch $MARKER"]
Signed-off-by: Thomas Huth <thuth@redhat.com>

configure

diff --git a/configure b/configure
index cf6db3d..dccb5d4 100755
--- a/configure
+++ b/configure
@@ -31,8 +31,12 @@
         fi
     fi
 
-    mkdir build
-    touch $MARKER
+    if ! mkdir build || ! touch $MARKER
+    then
+        echo "ERROR: Could not create ./build directory. Check the permissions on"
+        echo "your source directory, or try doing an out-of-tree build."
+        exit 1
+    fi
 
     cat > GNUmakefile <<'EOF'
 # This file is auto-generated by configure to support in-source tree