commit f15da599a1c5326e105425a74d2fb004a2a2649e
author Zhenzhong Duan <zhenzhong.duan@intel.com> Mon Jul 01 09:48:08 2024 +0800
committer Cédric Le Goater <clg@redhat.com> Tue Jul 09 11:50:37 2024 +0200
tree b2d719f813e0d0a44b7895b333a90c182a29c7bb
parent 956b30b9cf856470612e8d2c2c4985fb7e40a970

vfio/display: Fix potential memleak of edid info

EDID related device region info is leaked in vfio_display_edid_init()
error path and VFIODisplay destroying path.

Fixes: 08479114b0de ("vfio/display: add edid support.")
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

hw/vfio/display.c

diff --git a/hw/vfio/display.c b/hw/vfio/display.c
index 661e921..9c57fd3 100644
--- a/hw/vfio/display.c
+++ b/hw/vfio/display.c
@@ -171,7 +171,9 @@
 
 err:
     trace_vfio_display_edid_write_error();
+    g_free(dpy->edid_info);
     g_free(dpy->edid_regs);
+    dpy->edid_info = NULL;
     dpy->edid_regs = NULL;
     return;
 }
@@ -182,6 +184,7 @@
         return;
     }
 
+    g_free(dpy->edid_info);
     g_free(dpy->edid_regs);
     g_free(dpy->edid_blob);
     timer_free(dpy->edid_link_timer);