Google Git
Sign in
qemu / qemu / eeea1faa099f82328f5831cf252f8ce0a59a9287
commiteeea1faa099f82328f5831cf252f8ce0a59a9287[log] [tgz]
authorMax Reitz <mreitz@redhat.com>Tue Feb 25 16:56:18 2020 +0100
committerKevin Wolf <kwolf@redhat.com>Fri Mar 06 17:15:37 2020 +0100
tree99a8ba12b38cd0e41ed227b5418e8ae9d0dec391
parent81311255f217859413c94f2cd9cebf2684bbda94 [diff]
block: Fix leak in bdrv_create_file_fallback()

@options is leaked by the first two return statements in this function.

Note that blk_new_open() takes the reference to @options even on
failure, so all we need to do to fix the leak is to move the QDict
allocation down to where we actually need it.

Reported-by: Coverity (CID 1419884)
Fixes: fd17146cd93d1704cd96d7c2757b325fc7aac6fd
       ("block: Generic file creation fallback")
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20200225155618.133412-1-mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
1 file changed
tree: 99a8ba12b38cd0e41ed227b5418e8ae9d0dec391
  1. .gitlab-ci.d/
  2. accel/
  3. audio/
  4. authz/
  5. backends/
  6. block/
  7. bsd-user/
  8. chardev/
  9. contrib/
  10. crypto/
  11. default-configs/
  12. disas/
  13. docs/
  14. dump/
  15. fpu/
  16. fsdev/
  17. gdb-xml/
  18. hw/
  19. include/
  20. io/
  21. libdecnumber/
  22. linux-headers/
  23. linux-user/
  24. migration/
  25. monitor/
  26. nbd/
  27. net/
  28. pc-bios/
  29. plugins/
  30. po/
  31. python/
  32. qapi/
  33. qga/
  34. qobject/
  35. qom/
  36. replay/
  37. roms/
  38. scripts/
  39. scsi/
  40. softmmu/
  41. stubs/
  42. target/
  43. tcg/
  44. tests/
  45. tools/
  46. trace/
  47. ui/
  48. util/
  49. capstone
  50. dtc
  51. slirp
  52. .cirrus.yml
  53. .dir-locals.el
  54. .editorconfig
  55. .exrc
  56. .gdbinit
  57. .gitignore
  58. .gitlab-ci-edk2.yml
  59. .gitlab-ci.yml
  60. .gitmodules
  61. .gitpublish
  62. .mailmap
  63. .patchew.yml
  64. .readthedocs.yml
  65. .shippable.yml
  66. .travis.yml
  67. arch_init.c
  68. balloon.c
  69. block.c
  70. blockdev-nbd.c
  71. blockdev.c
  72. blockjob.c
  73. bootdevice.c
  74. Changelog
  75. CODING_STYLE.rst
  76. configure
  77. COPYING
  78. COPYING.LIB
  79. cpus-common.c
  80. cpus.c
  81. device-hotplug.c
  82. device_tree.c
  83. disas.c
  84. dma-helpers.c
  85. exec-vary.c
  86. exec.c
  87. gdbstub.c
  88. gitdm.config
  89. hmp-commands-info.hx
  90. hmp-commands.hx
  91. ioport.c
  92. iothread.c
  93. job-qmp.c
  94. job.c
  95. Kconfig.host
  96. LICENSE
  97. MAINTAINERS
  98. Makefile
  99. Makefile.objs
  100. Makefile.target
  101. memory.c
  102. memory_ldst.inc.c
  103. memory_mapping.c
  104. module-common.c
  105. os-posix.c
  106. os-win32.c
  107. qdev-monitor.c
  108. qemu-bridge-helper.c
  109. qemu-edid.c
  110. qemu-img-cmds.hx
  111. qemu-img.c
  112. qemu-io-cmds.c
  113. qemu-io.c
  114. qemu-keymap.c
  115. qemu-nbd.c
  116. qemu-options-wrapper.h
  117. qemu-options.h
  118. qemu-options.hx
  119. qemu-seccomp.c
  120. qemu.nsi
  121. qemu.sasl
  122. qtest.c
  123. README.rst
  124. replication.c
  125. replication.h
  126. rules.mak
  127. thunk.c
  128. tpm.c
  129. trace-events
  130. VERSION
  131. version.rc