commit ebcd88ceb5da70ee17c1d22e9874524649335759
author Peter Maydell <peter.maydell@linaro.org> Fri Feb 11 12:26:47 2011 +0000
committer Aurelien Jarno <aurelien@aurel32.net> Sun Feb 20 17:28:37 2011 +0100
tree 2eaca9f2e32fe778b00a9581ff0c2fa4c4c87e0c
parent e5ca24cba969b58eb3fe0e7c239df3abe21831c0

target-arm: Refactor handling of VQDMULL

Refactor the handling of VQDMULL so that it is dealt with in
its own if() case rather than together with the accumulating
instructions.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

target-arm/translate.c

diff --git a/target-arm/translate.c b/target-arm/translate.c
index 0c93896..a44e84c 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -5131,16 +5131,16 @@
                     default: /* 15 is RESERVED.  */
                         return 1;
                     }
-                    if (op == 5 || op == 13 || (op >= 8 && op <= 11)) {
+                    if (op == 13) {
+                        /* VQDMULL */
+                        gen_neon_addl_saturate(cpu_V0, cpu_V0, size);
+                        neon_store_reg64(cpu_V0, rd + pass);
+                    } else if (op == 5 || (op >= 8 && op <= 11)) {
                         /* Accumulate.  */
                         if (op == 10 || op == 11) {
                             gen_neon_negl(cpu_V0, size);
                         }
-
-                        if (op != 13) {
-                            neon_load_reg64(cpu_V1, rd + pass);
-                        }
-
+                        neon_load_reg64(cpu_V1, rd + pass);
                         switch (op) {
                         case 5: case 8: case 10: /* VABAL, VMLAL, VMLSL */
                             gen_neon_addl(size);
@@ -5149,10 +5149,6 @@
                             gen_neon_addl_saturate(cpu_V0, cpu_V0, size);
                             gen_neon_addl_saturate(cpu_V0, cpu_V1, size);
                             break;
-                            /* Fall through.  */
-                        case 13: /* VQDMULL */
-                            gen_neon_addl_saturate(cpu_V0, cpu_V0, size);
-                            break;
                         default:
                             abort();
                         }