commit e549d2aaeba1cfac207c9a9675cc203e6372a22e
author Bandan Das <bsd@redhat.com> Wed Jun 03 18:38:10 2015 -0400
committer Markus Armbruster <armbru@redhat.com> Mon Jun 22 17:40:00 2015 +0200
tree 556ff747b9acf1b91ea39f0fb011a7de2e1c0e29
parent dd41eea77129a4cd8ae5170b02e0fee175af314e

monitor: Fix failure path for "S" argument

Since the "S" argument type is only used with the "?" flag,
the bug can't bite.

Signed-off-by: Bandan Das <bsd@redhat.com>
Acked-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>

monitor.c

diff --git a/monitor.c b/monitor.c
index 4c7faf9..8b1dbf8 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4016,7 +4016,7 @@
                 if (len <= 0) {
                     monitor_printf(mon, "%s: string expected\n",
                                    cmd->name);
-                    break;
+                    goto fail;
                 }
                 qdict_put(qdict, key, qstring_from_str(p));
                 p += len;