util/log: Return bool from qemu_set_log_filename
Per the recommendations in qapi/error.h, return false on failure.
Use the return value in the monitor, the only place we aren't
already passing error_fatal or error_abort.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220417183019.755276-4-richard.henderson@linaro.org>
diff --git a/util/log.c b/util/log.c
index ffa66a2..a838686 100644
--- a/util/log.c
+++ b/util/log.c
@@ -138,7 +138,7 @@
*
* filename may be NULL. In that case, log output is sent to stderr
*/
-void qemu_set_log_filename(const char *filename, Error **errp)
+bool qemu_set_log_filename(const char *filename, Error **errp)
{
g_free(logfilename);
logfilename = NULL;
@@ -149,7 +149,7 @@
/* We only accept one %d, no other format strings */
if (pidstr[1] != 'd' || strchr(pidstr + 2, '%')) {
error_setg(errp, "Bad logfile format: %s", filename);
- return;
+ return false;
} else {
logfilename = g_strdup_printf(filename, getpid());
}
@@ -160,6 +160,7 @@
qemu_log_close();
qemu_set_log(qemu_loglevel);
+ return true;
}
/* Returns true if addr is in our debug filter or no filter defined
