)]}'
{
  "commit": "e274408cdc07b431ef6dfdbb5011c5ef434702e8",
  "tree": "4863048689ef71b84c19a5e3a878fa9a4771ca93",
  "parents": [
    "48942138177a89c920d0a01397ccbc4040090e5e"
  ],
  "author": {
    "name": "Markus Armbruster",
    "email": "armbru@redhat.com",
    "time": "Tue May 05 17:29:17 2020 +0200"
  },
  "committer": {
    "name": "Markus Armbruster",
    "email": "armbru@redhat.com",
    "time": "Fri May 15 07:07:58 2020 +0200"
  },
  "message": "s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes,eaes}-256\n\nBoth s390_features[S390_FEAT_PCC_CMAC_AES_256].name and\ns390_features[S390_FEAT_PCC_CMAC_EAES_256].name is\n\"pcc-cmac-eaes-256\".  The former is obviously a pasto.\n\nImpact:\n\n* s390_feat_bitmap_to_ascii() misidentifies S390_FEAT_PCC_CMAC_AES_256\n  as \"pcc-cmac-eaes-256\".  Affects QMP commands query-cpu-definitions,\n  query-cpu-model-expansion, query-cpu-model-baseline,\n  query-cpu-model-comparison, and the error message when\n  s390_realize_cpu_model() fails in check_compatibility().\n\n* s390_cpu_list() also misidentifies it.  Affects -cpu help.\n\n* s390_cpu_model_register_props() creates CPU property\n  \"pcc-cmac-eaes-256\" twice.  The second one fails, but the error is\n  ignored (a later commit will change that).  Results in a single\n  property \"pcc-cmac-eaes-256\" with the description for\n  S390_FEAT_PCC_CMAC_AES_256, and no property for\n  S390_FEAT_PCC_CMAC_EAES_256.  CPU properties are visible in CLI -cpu\n  and -device, QMP \u0026 HMP device_add, QMP device-list-properties, and\n  QOM introspection.\n\nThe two features are almost always used via their group msa4.  Such\nuse is not affected by this bug.\n\nFix by deleting the wayward \u0027e\u0027.\n\nFixes: 782417446279 (\"s390x/cpumodel: introduce CPU features\")\nCc: Halil Pasic \u003cpasic@linux.ibm.com\u003e\nCc: Cornelia Huck \u003ccohuck@redhat.com\u003e\nCc: Christian Borntraeger \u003cborntraeger@de.ibm.com\u003e\nCc: Richard Henderson \u003crth@twiddle.net\u003e\nCc: David Hildenbrand \u003cdavid@redhat.com\u003e\nCc: qemu-s390x@nongnu.org\nSigned-off-by: Markus Armbruster \u003carmbru@redhat.com\u003e\nReviewed-by: David Hildenbrand \u003cdavid@redhat.com\u003e\nTested-by: Christian Borntraeger \u003cborntraeger@de.ibm.com\u003e\nMessage-Id: \u003c20200505152926.18877-10-armbru@redhat.com\u003e\nReviewed-by: Cornelia Huck \u003ccohuck@redhat.com\u003e\n[Lost paragraph in commit message restored, Fixes: tweaked]\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "60db28351d059091b6e05fd62c37e916bc79d3f1",
      "old_mode": 33188,
      "old_path": "target/s390x/cpu_features_def.inc.h",
      "new_id": "5942f81f16595816e7e65cf61299c26b57ae2469",
      "new_mode": 33188,
      "new_path": "target/s390x/cpu_features_def.inc.h"
    }
  ]
}