commit dfae8e00f8ddeedcda24bd28f71d4fd2a9f988b8
author Peter Maydell <peter.maydell@linaro.org> Fri Feb 08 07:58:41 2013 +0000
committer Riku Voipio <riku.voipio@linaro.org> Mon Mar 11 14:34:05 2013 +0200
tree 0b20f25353cc5cfa637fdfd7c6eb66203800a4c3
parent 63ec54d7b319824df8b60cfe25afdfb607ce3905

linux-user: make bogus negative iovec lengths fail EINVAL

If the guest passes us a bogus negative length for an iovec, fail
EINVAL rather than proceeding blindly forward. This fixes some of
the error cases tests for readv and writev in the LTP.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>

linux-user/syscall.c

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 1729446..bab9ab5 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -1776,7 +1776,7 @@
         errno = 0;
         return NULL;
     }
-    if (count > IOV_MAX) {
+    if (count < 0 || count > IOV_MAX) {
         errno = EINVAL;
         return NULL;
     }