commit df9cb669425051f4f4364cffb19c9b8089e04297
author Gerd Hoffmann <kraxel@redhat.com> Thu Jul 07 17:04:17 2011 +0200
committer Gerd Hoffmann <kraxel@redhat.com> Wed Jul 20 10:08:53 2011 +0200
tree 8ba476bd2086a7509b6f1751059478e331bafb96
parent 03ff09580ef6cbc4a893b6e3e6bbff33180ec70a

spice: add sanity check for spice ports

Make sure at least one port (port=.. or tls-port=...)
is specified.  Also apply range checks to the port numbers.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

ui/spice-core.c

diff --git a/ui/spice-core.c b/ui/spice-core.c
index e142452..1100417 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -480,7 +480,16 @@
     port = qemu_opt_get_number(opts, "port", 0);
     tls_port = qemu_opt_get_number(opts, "tls-port", 0);
     if (!port && !tls_port) {
-        return;
+        fprintf(stderr, "neither port nor tls-port specified for spice.");
+        exit(1);
+    }
+    if (port < 0 || port > 65535) {
+        fprintf(stderr, "spice port is out of range");
+        exit(1);
+    }
+    if (tls_port < 0 || tls_port > 65535) {
+        fprintf(stderr, "spice tls-port is out of range");
+        exit(1);
     }
     password = qemu_opt_get(opts, "password");