commit ddfc8b96eec648f35f0f054bd3f0a05df6cd34fb
author Philippe Mathieu-Daudé <f4bug@amsat.org> Mon May 18 17:53:03 2020 +0200
committer Paolo Bonzini <pbonzini@redhat.com> Wed Jun 10 12:10:22 2020 -0400
tree 09d26ee645826170cd55f6bf934c473b55ec28d6
parent 38df19fad71abe8823f8b416f672be95c2ac8d04

exec: Propagate cpu_memory_rw_debug() error

Do not ignore the MemTxResult error type returned by
the address_space_rw() API.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

exec.c

diff --git a/exec.c b/exec.c
index 0e197e5..9cbde85 100644
--- a/exec.c
+++ b/exec.c
@@ -3771,6 +3771,7 @@
     while (len > 0) {
         int asidx;
         MemTxAttrs attrs;
+        MemTxResult res;
 
         page = addr & TARGET_PAGE_MASK;
         phys_addr = cpu_get_phys_page_attrs_debug(cpu, page, &attrs);
@@ -3783,11 +3784,14 @@
             l = len;
         phys_addr += (addr & ~TARGET_PAGE_MASK);
         if (is_write) {
-            address_space_write_rom(cpu->cpu_ases[asidx].as, phys_addr,
-                                    attrs, buf, l);
+            res = address_space_write_rom(cpu->cpu_ases[asidx].as, phys_addr,
+                                          attrs, buf, l);
         } else {
-            address_space_read(cpu->cpu_ases[asidx].as, phys_addr, attrs, buf,
-                               l);
+            res = address_space_read(cpu->cpu_ases[asidx].as, phys_addr,
+                                     attrs, buf, l);
+        }
+        if (res != MEMTX_OK) {
+            return -1;
         }
         len -= l;
         buf += l;