Google Git
Sign in
qemu / qemu / dcac64711ea906e844ae60a5927e5580f7252c1e
commitdcac64711ea906e844ae60a5927e5580f7252c1e[log] [tgz]
authorMarkus Armbruster <armbru@redhat.com>Thu Feb 14 16:22:36 2019 +0100
committerMarkus Armbruster <armbru@redhat.com>Mon Feb 18 14:44:04 2019 +0100
treec301702ab4cff7e031d6c8638a7fd9d1a031a57d
parent83a22d89b0d96cba0b2b6d843a443e3400322e0b [diff]
qapi: Clean up modular built-in code generation a bit

We neglect to call .visit_module() for the special module we use for
built-ins.  Harmless, but clean it up anyway.  The
tests/qapi-schema/*.out now show the built-in module as 'module None'.

Subclasses of QAPISchemaModularCVisitor need to ._add_module() this
special module to enable code generation for built-ins.  When this
hasn't been done, QAPISchemaModularCVisitor.visit_module() does
nothing for the special module.  That looks like built-ins could
accidentally be generated into the wrong module when a subclass
neglects to call ._add_module().  Can't happen, because built-ins are
all visited before any other module.  But that's non-obvious.  Switch
off code generation explicitly.

Rename QAPISchemaModularCVisitor._begin_module() to
._begin_user_module().

New QAPISchemaModularCVisitor._is_builtin_module(), for clarity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20190214152251.2073-4-armbru@redhat.com>
16 files changed
tree: c301702ab4cff7e031d6c8638a7fd9d1a031a57d
  1. accel/
  2. audio/
  3. backends/
  4. block/
  5. bsd-user/
  6. chardev/
  7. contrib/
  8. crypto/
  9. default-configs/
  10. disas/
  11. docs/
  12. fpu/
  13. fsdev/
  14. gdb-xml/
  15. hw/
  16. include/
  17. io/
  18. libdecnumber/
  19. linux-headers/
  20. linux-user/
  21. migration/
  22. nbd/
  23. net/
  24. pc-bios/
  25. po/
  26. qapi/
  27. qga/
  28. qobject/
  29. qom/
  30. replay/
  31. roms/
  32. scripts/
  33. scsi/
  34. slirp/
  35. stubs/
  36. target/
  37. tcg/
  38. tests/
  39. trace/
  40. ui/
  41. util/
  42. capstone
  43. dtc
  44. .cirrus.yml
  45. .dir-locals.el
  46. .editorconfig
  47. .exrc
  48. .gdbinit
  49. .gitignore
  50. .gitmodules
  51. .gitpublish
  52. .mailmap
  53. .shippable.yml
  54. .travis.yml
  55. arch_init.c
  56. balloon.c
  57. block.c
  58. blockdev-nbd.c
  59. blockdev.c
  60. blockjob.c
  61. bootdevice.c
  62. bt-host.c
  63. bt-vhci.c
  64. Changelog
  65. CODING_STYLE
  66. configure
  67. COPYING
  68. COPYING.LIB
  69. cpus-common.c
  70. cpus.c
  71. device-hotplug.c
  72. device_tree.c
  73. disas.c
  74. dma-helpers.c
  75. dump.c
  76. exec.c
  77. gdbstub.c
  78. gitdm.config
  79. HACKING
  80. hmp-commands-info.hx
  81. hmp-commands.hx
  82. hmp.c
  83. hmp.h
  84. ioport.c
  85. iothread.c
  86. job-qmp.c
  87. job.c
  88. LICENSE
  89. MAINTAINERS
  90. Makefile
  91. Makefile.objs
  92. Makefile.target
  93. memory.c
  94. memory_ldst.inc.c
  95. memory_mapping.c
  96. module-common.c
  97. monitor.c
  98. numa.c
  99. os-posix.c
  100. os-win32.c
  101. qdev-monitor.c
  102. qdict-test-data.txt
  103. qemu-bridge-helper.c
  104. qemu-deprecated.texi
  105. qemu-doc.texi
  106. qemu-edid.c
  107. qemu-ga.texi
  108. qemu-img-cmds.hx
  109. qemu-img.c
  110. qemu-img.texi
  111. qemu-io-cmds.c
  112. qemu-io.c
  113. qemu-keymap.c
  114. qemu-nbd.c
  115. qemu-nbd.texi
  116. qemu-option-trace.texi
  117. qemu-options-wrapper.h
  118. qemu-options.h
  119. qemu-options.hx
  120. qemu-seccomp.c
  121. qemu-tech.texi
  122. qemu.nsi
  123. qemu.sasl
  124. qmp.c
  125. qtest.c
  126. README
  127. replication.c
  128. replication.h
  129. rules.mak
  130. thunk.c
  131. tpm.c
  132. trace-events
  133. VERSION
  134. version.rc
  135. vl.c
  136. win_dump.c
  137. win_dump.h