Google Git
Sign in
qemu / qemu / db68f4ff06cbe0517ed0d9b5634f6cddaed2547c
commitdb68f4ff06cbe0517ed0d9b5634f6cddaed2547c[log] [tgz]
authorStefan Hajnoczi <stefanha@redhat.com>Wed Jun 26 08:48:12 2019 +0100
committerMichael S. Tsirkin <mst@redhat.com>Thu Jul 04 17:00:32 2019 -0400
tree09127383fdd8160bb275cd2594fb8e6e17bdfb34
parent457cfcccdd107a968d106934df63b836b5dd743e [diff]
libvhost-user: add vmsg_set_reply_u64() helper

The VhostUserMsg request is reused as the reply by message processing
functions.  This is risky since request fields may corrupt the reply if
the vhost-user message handler function forgets to re-initialize them.

Changing this practice would be very invasive but we can introduce a
helper function to make u64 payload replies safe.  This also eliminates
code duplication in message processing functions.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20190626074815.19994-2-stefanha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
1 file changed
tree: 09127383fdd8160bb275cd2594fb8e6e17bdfb34
  1. accel/
  2. audio/
  3. authz/
  4. backends/
  5. block/
  6. bsd-user/
  7. chardev/
  8. contrib/
  9. crypto/
  10. default-configs/
  11. disas/
  12. docs/
  13. fpu/
  14. fsdev/
  15. gdb-xml/
  16. hw/
  17. include/
  18. io/
  19. libdecnumber/
  20. linux-headers/
  21. linux-user/
  22. migration/
  23. monitor/
  24. nbd/
  25. net/
  26. pc-bios/
  27. po/
  28. python/
  29. qapi/
  30. qga/
  31. qobject/
  32. qom/
  33. replay/
  34. roms/
  35. scripts/
  36. scsi/
  37. stubs/
  38. target/
  39. tcg/
  40. tests/
  41. trace/
  42. ui/
  43. util/
  44. capstone
  45. dtc
  46. slirp
  47. .cirrus.yml
  48. .dir-locals.el
  49. .editorconfig
  50. .exrc
  51. .gdbinit
  52. .gitignore
  53. .gitlab-ci.yml
  54. .gitmodules
  55. .gitpublish
  56. .mailmap
  57. .patchew.yml
  58. .shippable.yml
  59. .travis.yml
  60. arch_init.c
  61. balloon.c
  62. block.c
  63. blockdev-nbd.c
  64. blockdev.c
  65. blockjob.c
  66. bootdevice.c
  67. bt-host.c
  68. bt-vhci.c
  69. Changelog
  70. CODING_STYLE
  71. configure
  72. COPYING
  73. COPYING.LIB
  74. cpus-common.c
  75. cpus.c
  76. device-hotplug.c
  77. device_tree.c
  78. disas.c
  79. dma-helpers.c
  80. dump.c
  81. exec.c
  82. gdbstub.c
  83. gitdm.config
  84. HACKING
  85. hmp-commands-info.hx
  86. hmp-commands.hx
  87. hmp.h
  88. ioport.c
  89. iothread.c
  90. job-qmp.c
  91. job.c
  92. Kconfig.host
  93. LICENSE
  94. MAINTAINERS
  95. Makefile
  96. Makefile.objs
  97. Makefile.target
  98. memory.c
  99. memory_ldst.inc.c
  100. memory_mapping.c
  101. module-common.c
  102. numa.c
  103. os-posix.c
  104. os-win32.c
  105. qdev-monitor.c
  106. qemu-bridge-helper.c
  107. qemu-deprecated.texi
  108. qemu-doc.texi
  109. qemu-edid.c
  110. qemu-ga.texi
  111. qemu-img-cmds.hx
  112. qemu-img.c
  113. qemu-img.texi
  114. qemu-io-cmds.c
  115. qemu-io.c
  116. qemu-keymap.c
  117. qemu-nbd.c
  118. qemu-nbd.texi
  119. qemu-option-trace.texi
  120. qemu-options-wrapper.h
  121. qemu-options.h
  122. qemu-options.hx
  123. qemu-seccomp.c
  124. qemu-tech.texi
  125. qemu.nsi
  126. qemu.sasl
  127. qtest.c
  128. README
  129. replication.c
  130. replication.h
  131. rules.mak
  132. thunk.c
  133. tpm.c
  134. trace-events
  135. VERSION
  136. version.rc
  137. vl.c
  138. win_dump.c
  139. win_dump.h