commit d71a243220db1e6bc04425b5988b8a9bc8523345
author Markus Armbruster <armbru@redhat.com> Mon Jan 25 14:26:35 2021 +0100
committer Markus Armbruster <armbru@redhat.com> Fri Mar 05 15:40:42 2021 +0100
tree 966fe60a81ad0e4fab34bf992b6372222e263e21
parent fe352f5c0056b4d21ae033ec49acc0bce9897e53

error: Fix "Converting to ERRP_GUARD()" doc on "valid at return"

Setting errp = NULL is wrong: the automatic error propagation still
propagates the dangling pointer _auto_errp_prop.local_err.  We need to
set *errp = NULL to clear the dangling pointer.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210125132635.1253219-1-armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

include/qapi/error.h

diff --git a/include/qapi/error.h b/include/qapi/error.h
index eaa05c4..4a9260b 100644
--- a/include/qapi/error.h
+++ b/include/qapi/error.h
@@ -235,7 +235,7 @@
  *    error_propagate_prepend(errp, *errp, ...) by error_prepend(errp, ...)
  *
  * 4. Ensure @errp is valid at return: when you destroy *errp, set
- *    errp = NULL.
+ *    *errp = NULL.
  *
  * Example:
  *