Google Git
Sign in
qemu / qemu / d2c3080e41fd2c9bc36c996cc9d33804462ba803
commitd2c3080e41fd2c9bc36c996cc9d33804462ba803[log] [tgz]
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>Fri Sep 20 11:25:43 2019 +0300
committerJohn Snow <jsnow@redhat.com>Thu Oct 17 17:02:32 2019 -0400
treefaa16eec6452d036d5762ca0329a4ecdcb0b1ab2
parentb56a1e31759b750e111b4dd35171007bf493fc89 [diff]
block/qcow2: proper locking on bitmap add/remove paths

qmp_block_dirty_bitmap_add and do_block_dirty_bitmap_remove do acquire
aio context since 0a6c86d024c52b. But this is not enough: we also must
lock qcow2 mutex when access in-image metadata. Especially it concerns
freeing qcow2 clusters.

To achieve this, move qcow2_can_store_new_dirty_bitmap and
qcow2_remove_persistent_dirty_bitmap to coroutine context.

Since we work in coroutines in correct aio context, we don't need
context acquiring in blockdev.c anymore, drop it.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-id: 20190920082543.23444-4-vsementsov@virtuozzo.com
Signed-off-by: John Snow <jsnow@redhat.com>
6 files changed
tree: faa16eec6452d036d5762ca0329a4ecdcb0b1ab2
  1. accel/
  2. audio/
  3. authz/
  4. backends/
  5. block/
  6. bsd-user/
  7. chardev/
  8. contrib/
  9. crypto/
  10. default-configs/
  11. disas/
  12. docs/
  13. dump/
  14. fpu/
  15. fsdev/
  16. gdb-xml/
  17. hw/
  18. include/
  19. io/
  20. libdecnumber/
  21. linux-headers/
  22. linux-user/
  23. migration/
  24. monitor/
  25. nbd/
  26. net/
  27. pc-bios/
  28. po/
  29. python/
  30. qapi/
  31. qga/
  32. qobject/
  33. qom/
  34. replay/
  35. roms/
  36. scripts/
  37. scsi/
  38. stubs/
  39. target/
  40. tcg/
  41. tests/
  42. trace/
  43. ui/
  44. util/
  45. capstone
  46. dtc
  47. slirp
  48. .cirrus.yml
  49. .dir-locals.el
  50. .editorconfig
  51. .exrc
  52. .gdbinit
  53. .gitignore
  54. .gitlab-ci.yml
  55. .gitmodules
  56. .gitpublish
  57. .mailmap
  58. .patchew.yml
  59. .shippable.yml
  60. .travis.yml
  61. arch_init.c
  62. balloon.c
  63. block.c
  64. blockdev-nbd.c
  65. blockdev.c
  66. blockjob.c
  67. bootdevice.c
  68. bt-host.c
  69. bt-vhci.c
  70. Changelog
  71. CODING_STYLE.rst
  72. configure
  73. COPYING
  74. COPYING.LIB
  75. cpus-common.c
  76. cpus.c
  77. device-hotplug.c
  78. device_tree.c
  79. disas.c
  80. dma-helpers.c
  81. exec.c
  82. gdbstub.c
  83. gitdm.config
  84. hmp-commands-info.hx
  85. hmp-commands.hx
  86. ioport.c
  87. iothread.c
  88. job-qmp.c
  89. job.c
  90. Kconfig.host
  91. LICENSE
  92. MAINTAINERS
  93. Makefile
  94. Makefile.objs
  95. Makefile.target
  96. memory.c
  97. memory_ldst.inc.c
  98. memory_mapping.c
  99. module-common.c
  100. os-posix.c
  101. os-win32.c
  102. qdev-monitor.c
  103. qemu-bridge-helper.c
  104. qemu-deprecated.texi
  105. qemu-doc.texi
  106. qemu-edid.c
  107. qemu-img-cmds.hx
  108. qemu-img.c
  109. qemu-img.texi
  110. qemu-io-cmds.c
  111. qemu-io.c
  112. qemu-keymap.c
  113. qemu-nbd.c
  114. qemu-nbd.texi
  115. qemu-option-trace.texi
  116. qemu-options-wrapper.h
  117. qemu-options.h
  118. qemu-options.hx
  119. qemu-seccomp.c
  120. qemu-tech.texi
  121. qemu.nsi
  122. qemu.sasl
  123. qtest.c
  124. README.rst
  125. replication.c
  126. replication.h
  127. rules.mak
  128. thunk.c
  129. tpm.c
  130. trace-events
  131. VERSION
  132. version.rc
  133. vl.c