)]}'
{
  "commit": "c9e8ecf2fb8ffd559c63fff413063c4e18a7c989",
  "tree": "eaecfd3bb3afcf70749ea3093686fcddca14dc3c",
  "parents": [
    "257bf4f160c50ca8c4ebd603f519f5c786013fb7"
  ],
  "author": {
    "name": "Christian Quante",
    "email": "christian@quante.one",
    "time": "Sat Aug 22 12:43:27 2026 +0200"
  },
  "committer": {
    "name": "Fabiano Rosas",
    "email": "farosas@suse.de",
    "time": "Thu Sep 10 17:21:39 2026 -0300"
  },
  "message": "tests/qtest/fdc-test: give each test case its own QEMU instance\n\nThe test cases share one QEMU instance and, with it, the state of the\nfloppy controller.  Several of them therefore only pass in the order they\nhappen to be registered in: test_read_no_dma_1, _18 and _19 read the medium\nthat test_media_insert leaves in the drive, so running any of them on its\nown fails.  fuzz-registers is worse -- it writes 1000 random values to the\neight I/O ports at FLOPPY_BASE and restores none of them, which is harmless\nonly because it is the last test case to run in the shared instance; the\ntwo registered after it start one of their own.  Moving it anywhere else\nleaves an unacknowledged interrupt behind and the next test dies in\nsend_seek().\n\nRegister the test cases from a table instead, through a wrapper that starts\na QEMU instance, runs one test and stops it again.  The test functions are\nunchanged: they reach the current instance through global_qtest, which\nqtest_start() reassigns for every test.  The three read_no_dma tests now\ninsert their own medium, and test_read_id no longer ejects at the end -- it\ndid that only to leave the drive as the next test expected to find it.\n\nThe two CVE test cases keep qtest_add_func(); they already run a QEMU\ninstance of their own and do not use global_qtest.\n\nThe same pattern is used by tests/qtest/boot-serial-test.c.\n\nEvery test case now passes on its own, and the suite passes with the\nregistration order reversed.\n\nSigned-off-by: Christian Quante \u003cchristian@quante.one\u003e\nTested-by: Marc-André Lureau \u003cmarcandre.lureau@redhat.com\u003e\nSigned-off-by: Fabiano Rosas \u003cfarosas@suse.de\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "1e1dd8659d00a8c3cbe2ab6f2d52d93d60360690",
      "old_mode": 33188,
      "old_path": "tests/qtest/fdc-test.c",
      "new_id": "fd38475bf7b7381ecb22d36127a978c5ab855b70",
      "new_mode": 33188,
      "new_path": "tests/qtest/fdc-test.c"
    }
  ]
}
