)]}'
{
  "commit": "c827fafcaad3e8b3dcf7eeb5944b03f6b63dfc44",
  "tree": "75857aa72e6c73f3d4c34172c7d5becc7fa34719",
  "parents": [
    "4760cedc61328e47bf7f1fabceb9937facfa4cdd"
  ],
  "author": {
    "name": "Fabiano Rosas",
    "email": "farosas@suse.de",
    "time": "Mon Mar 11 20:33:35 2024 -0300"
  },
  "committer": {
    "name": "Peter Xu",
    "email": "peterx@redhat.com",
    "time": "Tue Mar 12 15:22:23 2024 -0400"
  },
  "message": "migration: Fix error handling after dup in file migration\n\nThe file migration code was allowing a possible -1 from a failed call\nto dup() to propagate into the new QIOFileChannel::fd before checking\nfor validity. Coverity doesn\u0027t like that, possibly due to the the\nlseek(-1, ...) call that would ensue before returning from the channel\ncreation routine.\n\nUse the newly introduced qio_channel_file_dupfd() to properly check\nthe return of dup() before proceeding.\n\nFixes: CID 1539961\nFixes: CID 1539965\nFixes: CID 1539960\nFixes: 2dd7ee7a51 (\"migration/multifd: Add incoming QIOChannelFile support\")\nFixes: decdc76772 (\"migration/multifd: Add mapped-ram support to fd: URI\")\nReported-by: Peter Maydell \u003cpeter.maydell@linaro.org\u003e\nSigned-off-by: Fabiano Rosas \u003cfarosas@suse.de\u003e\nReviewed-by: \"Daniel P. Berrangé\" \u003cberrange@redhat.com\u003e\nLink: https://lore.kernel.org/r/20240311233335.17299-3-farosas@suse.de\nSigned-off-by: Peter Xu \u003cpeterx@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d4ae72d132e588d7acff0db6146af4a45d9f1c07",
      "old_mode": 33188,
      "old_path": "migration/fd.c",
      "new_id": "4e2a63a73db1c9045f8f959b06150d62264a0d6d",
      "new_mode": 33188,
      "new_path": "migration/fd.c"
    },
    {
      "type": "modify",
      "old_id": "b0b963e0cec4f011e63930704ebfec4129d13b7c",
      "old_mode": 33188,
      "old_path": "migration/file.c",
      "new_id": "e56c5eb0a546e616c1b247f9e18c3feda13d3e88",
      "new_mode": 33188,
      "new_path": "migration/file.c"
    }
  ]
}
