)]}'
{
  "commit": "c6f5dd7ac8ef62dcdec4cdeda1467c658161afff",
  "tree": "3699832abed0e44c05e6e0d0833f2a75fd8faf36",
  "parents": [
    "5b567c21c6d517beeb1087399f733662d7e8ff62"
  ],
  "author": {
    "name": "Michal Privoznik",
    "email": "mprivozn@redhat.com",
    "time": "Tue Jan 07 15:52:07 2025 +0100"
  },
  "committer": {
    "name": "Konstantin Kostiuk",
    "email": "kkostiuk@redhat.com",
    "time": "Wed Feb 26 13:34:25 2025 +0200"
  },
  "message": "qga: Don\u0027t daemonize before channel is initialized\n\nIf the agent is set to daemonize but for whatever reason fails to\ninit the channel, the error message is lost. Worse, the agent\ndaemonizes needlessly and returns success. For instance:\n\n  # qemu-ga -m virtio-serial \\\n            -p /dev/nonexistent_device \\\n            -f /run/qemu-ga.pid \\\n            -t /run \\\n            -d\n  # echo $?\n  0\n\nThis makes it needlessly hard for init scripts to detect a\nfailure in qemu-ga startup. Though, they shouldn\u0027t pass \u0027-d\u0027 in\nthe first place.\n\nLet\u0027s open the channel first and only after that become a daemon.\n\nRelated bug: https://bugs.gentoo.org/810628\n\nSigned-off-by: Michal Privoznik \u003cmprivozn@redhat.com\u003e\nReviewed-by: Ján Tomko \u003cjtomko@redhat.com\u003e\nReviewed-by: Konstantin Kostiuk \u003ckkostiuk@redhat.com\u003e\nMessage-ID: \u003c7a42b0cbda5c7e01cf76bc1b29a1210cd018fa78.1736261360.git.mprivozn@redhat.com\u003e\nSigned-off-by: Konstantin Kostiuk \u003ckkostiuk@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "eccfa3387135bb4cf6b68c57c12ceb3b3e2d6619",
      "old_mode": 33188,
      "old_path": "qga/main.c",
      "new_id": "72c39b042f7cdef52b22badbb3b86422542ceb2d",
      "new_mode": 33188,
      "new_path": "qga/main.c"
    }
  ]
}
