Google GitGoogle Git
Sign in
qemu/qemu/c63f672ee57075463e5b96aaa3edc8f445bf924e
commit
c63f672ee57075463e5b96aaa3edc8f445bf924e
[log]
author
Marc-André Lureau <marcandre.lureau@redhat.com>
Mon Sep 07 14:50:10 2026 +0400
committer
Kostiantyn Kostiuk <kkostiuk@redhat.com>
Tue Sep 15 14:09:40 2026 +0300
tree
bf013afd941f8cca28e0b34010e882089de3929b
parent
1a8ae57a6155bf0d34cc315efcfa38b2251460d3 [diff]
qga/vss-win32: evaluate err_set() macro argument only once

The err_set macro expands its 'err' parameter three times. When
callers pass GetLastError(), the Win32 error code is fetched on
each expansion and may change between evaluations, since the
intervening function calls can reset the thread's last-error value.

Capture the argument in a local DWORD once and reference that
throughout the macro body.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
Link: https://lore.kernel.org/qemu-devel/20260907-qga-v1-12-86456ad356e2@redhat.com
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
1 file changed
tree: bf013afd941f8cca28e0b34010e882089de3929b
  1. .claude/
  2. .gemini/
  3. .github/
  4. .gitlab/
  5. .gitlab-ci.d/
  6. accel/
  7. audio/
  8. authz/
  9. backends/
  10. block/
  11. bsd-user/
  12. chardev/
  13. common-user/
  14. configs/
  15. contrib/
  16. crypto/
  17. disas/
  18. docs/
  19. dump/
  20. ebpf/
  21. fpu/
  22. fsdev/
  23. gdbstub/
  24. host/
  25. hw/
  26. include/
  27. io/
  28. libdecnumber/
  29. linux-headers/
  30. linux-user/
  31. migration/
  32. monitor/
  33. nbd/
  34. net/
  35. pc-bios/
  36. plugins/
  37. po/
  38. python/
  39. pyvenv/
  40. qapi/
  41. qga/
  42. qobject/
  43. qom/
  44. replay/
  45. roms/
  46. rust/
  47. scripts/
  48. scsi/
  49. semihosting/
  50. stats/
  51. storage-daemon/
  52. stubs/
  53. subprojects/
  54. system/
  55. target/
  56. tcg/
  57. tests/
  58. tools/
  59. trace/
  60. ui/
  61. util/
  62. .b4-config
  63. .dir-locals.el
  64. .editorconfig
  65. .exrc
  66. .gdbinit
  67. .git-blame-ignore-revs
  68. .gitattributes
  69. .gitignore
  70. .gitlab-ci.yml
  71. .gitlab-map-auto
  72. .gitlab-map-manual
  73. .gitmodules
  74. .gitpublish
  75. .mailmap
  76. .patchew.yml
  77. .readthedocs.yml
  78. .travis.yml
  79. AGENTS.md
  80. block.c
  81. blockdev-nbd.c
  82. blockdev.c
  83. blockjob.c
  84. Cargo.lock
  85. Cargo.toml
  86. clippy.toml
  87. configure
  88. COPYING
  89. COPYING.LIB
  90. cpu-common.c
  91. cpu-target.c
  92. event-loop-base.c
  93. gitdm.config
  94. hmp-commands-info.hx
  95. hmp-commands.hx
  96. iothread.c
  97. job-qmp.c
  98. job.c
  99. Kconfig
  100. Kconfig.host
  101. LICENSE
  102. MAINTAINERS
  103. Makefile
  104. meson.build
  105. meson_options.txt
  106. module-common.c
  107. os-posix.c
  108. os-wasm.c
  109. os-win32.c
  110. page-vary-common.c
  111. page-vary-system.c
  112. pythondeps.toml
  113. qemu-bridge-helper.c
  114. qemu-edid.c
  115. qemu-img-cmds.hx
  116. qemu-img.c
  117. qemu-io-cmds.c
  118. qemu-io.c
  119. qemu-keymap.c
  120. qemu-nbd.c
  121. qemu-options.hx
  122. qemu.nsi
  123. qemu.sasl
  124. README.rst
  125. replication.c
  126. run.in
  127. target-info-qom.c
  128. target-info-stub.c
  129. target-info.c
  130. trace-events
  131. VERSION
  132. version.rc