commit c59fb13be7fd937c087ed103abad4c2d9d2bcfab
author Markus Armbruster <armbru@redhat.com> Mon May 13 16:17:01 2024 +0200
committer Markus Armbruster <armbru@redhat.com> Mon May 27 12:42:44 2024 +0200
tree 3463db513ebe65856ba1542b5cbba608a816ec22
parent 29ad187c1c89fcf82d4e73e90bec9722d548efed

cpus: Improve error messages on memsave, pmemsave write error

qmp_memsave() and qmp_pmemsave() report fwrite() error as

    An IO error has occurred

Improve this to

    writing memory to '<filename>' failed

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240513141703.549874-5-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

system/cpus.c

diff --git a/system/cpus.c b/system/cpus.c
index 68d161d..f8fa78f 100644
--- a/system/cpus.c
+++ b/system/cpus.c
@@ -813,7 +813,8 @@
             goto exit;
         }
         if (fwrite(buf, 1, l, f) != l) {
-            error_setg(errp, QERR_IO_ERROR);
+            error_setg(errp, "writing memory to '%s' failed",
+                       filename);
             goto exit;
         }
         addr += l;
@@ -843,7 +844,8 @@
             l = size;
         cpu_physical_memory_read(addr, buf, l);
         if (fwrite(buf, 1, l, f) != l) {
-            error_setg(errp, QERR_IO_ERROR);
+            error_setg(errp, "writing memory to '%s' failed",
+                       filename);
             goto exit;
         }
         addr += l;