commit c53a7285b4377e91f30b7742c7e12c16d6bf86f0
author Avi Kivity <avi@redhat.com> Sun May 16 14:59:57 2010 +0300
committer Kevin Wolf <kwolf@redhat.com> Fri May 21 11:49:18 2010 +0200
tree bf012c66eddd97a04dbe4d6795cd10a1ccbba4cc
parent 81a204e44356a4e147ee4bcfded3d25793c5a2ad

block: fix aio_flush segfaults for read-only protocols (e.g. curl)

Not all block format drivers expose an io_flush method (reasonable for
read-only protocols), so calling io_flush there will immediately segfault.

Fix by checking for the method's existence before calling it.

Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

aio.c

diff --git a/aio.c b/aio.c
index f164a47..2f08655 100644
--- a/aio.c
+++ b/aio.c
@@ -113,7 +113,9 @@
         qemu_aio_wait();
 
         QLIST_FOREACH(node, &aio_handlers, node) {
-            ret |= node->io_flush(node->opaque);
+            if (node->io_flush) {
+                ret |= node->io_flush(node->opaque);
+            }
         }
     } while (qemu_bh_poll() || ret > 0);
 }