commit c47c0bcb33e154b82b4f6b90984aba998fcc4f18
author Daniel P. Berrangé <berrange@redhat.com> Thu Mar 11 11:43:43 2021 +0000
committer Gerd Hoffmann <kraxel@redhat.com> Mon Mar 15 17:37:44 2021 +0100
tree 83dcb08e23fbbc3ef94f8ec34c7021d563d834cb
parent 99522f69d62216f5d9581f66f2c0edca6bd48f78

ui: deprecate "password" option for SPICE server

With the new "password-secret" option, there is no reason to use the old
inecure "password" option with -spice, so it can be deprecated.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20210311114343.439820-4-berrange@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

ui/spice-core.c

diff --git a/ui/spice-core.c b/ui/spice-core.c
index b9d8ace..272d19b 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -686,6 +686,8 @@
     } else {
         str = qemu_opt_get(opts, "password");
         if (str) {
+            warn_report("'password' option is deprecated and insecure, "
+                        "use 'password-secret' instead");
             password = g_strdup(str);
         }
     }