commit c4075353854ed320cf9225ebd5605836ae236640
author Richard Henderson <richard.henderson@linaro.org> Mon May 01 21:46:25 2023 +0100
committer Richard Henderson <richard.henderson@linaro.org> Tue May 02 13:05:45 2023 -0700
tree ea8c36b24a2463954985d8cd9b42bbb0cac5646a
parent bef317d0c36d66cb44d14a0838d5abe7b26b0344

qemu/int128: Re-shuffle Int128Alias members

Clang 14, with --enable-tcg-interpreter errors with

include/qemu/int128.h:487:16: error: alignment of field 'i' (128 bits)
  does not match the alignment of the first field in transparent union;
  transparent_union attribute ignored [-Werror,-Wignored-attributes]
    __int128_t i;
               ^
include/qemu/int128.h:486:12: note: alignment of first field is 64 bits
    Int128 s;
           ^
1 error generated.

By placing the __uint128_t member first, this is avoided.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230501204625.277361-1-richard.henderson@linaro.org>

include/qemu/int128.h

diff --git a/include/qemu/int128.h b/include/qemu/int128.h
index f62a46b..9e46cfae 100644
--- a/include/qemu/int128.h
+++ b/include/qemu/int128.h
@@ -483,9 +483,9 @@
  */
 #ifdef CONFIG_INT128
 typedef union {
-    Int128 s;
-    __int128_t i;
     __uint128_t u;
+    __int128_t i;
+    Int128 s;
 } Int128Alias __attribute__((transparent_union));
 #else
 typedef Int128 Int128Alias;