)]}'
{
  "commit": "c0fcd6334ff673b571ac068f28b6b779bdade8a2",
  "tree": "627c6ddd09396e4de1756921610ba31aae60ddd2",
  "parents": [
    "fa6426805b124400cfb700b75e8fe4a89dd2ed7a"
  ],
  "author": {
    "name": "Dongwon Kim",
    "email": "dongwon.kim@intel.com",
    "time": "Wed May 08 10:54:02 2024 -0700"
  },
  "committer": {
    "name": "Marc-André Lureau",
    "email": "marcandre.lureau@redhat.com",
    "time": "Tue May 14 17:14:12 2024 +0400"
  },
  "message": "ui/console: Use qemu_dmabuf_new() and free() helpers instead\n\nThis commit introduces utility functions for the creation and deallocation\nof QemuDmaBuf instances. Additionally, it updates all relevant sections\nof the codebase to utilize these new utility functions.\n\nv7: remove prefix, \"dpy_gl_\" from all helpers\n    qemu_dmabuf_free() returns without doing anything if input is null\n    (Daniel P. Berrangé \u003cberrange@redhat.com\u003e)\n    call G_DEFINE_AUTOPTR_CLEANUP_FUNC for qemu_dmabuf_free()\n    (Daniel P. Berrangé \u003cberrange@redhat.com\u003e)\n\nv8: Introduction of helpers was removed as those were already added\n    by the previous commit\n\nv9: set dmabuf-\u003eallow_fences to \u0027true\u0027 when dmabuf is created in\n    virtio_gpu_create_dmabuf()/virtio-gpu-udmabuf.c\n\n    removed unnecessary spaces were accidently added in the patch,\n    \u0027ui/console: Use qemu_dmabuf_new() a...\u0027\n\nv11: Calling qemu_dmabuf_close was removed as closing dmabuf-\u003efd will be\n     done in qemu_dmabuf_free anyway.\n     (Daniel P. Berrangé \u003cberrange@redhat.com\u003e)\n\nv12: --- Calling qemu_dmabuf_close separately as qemu_dmabuf_free doesn\u0027t\n         do it.\n\n     --- \u0027dmabuf\u0027 is now allocated space so it should be freed at the end of\n         dbus_scanout_texture\n\nv13: --- Immediately free dmabuf after it is released to prevent possible\n         leaking of the ptr\n         (Marc-André Lureau \u003cmarcandre.lureau@redhat.com\u003e)\n\n     --- Use g_autoptr macro to define *dmabuf for auto clean up instead of\n         calling qemu_dmabuf_free\n         (Marc-André Lureau \u003cmarcandre.lureau@redhat.com\u003e)\n\nv14: --- (vhost-user-gpu) Change qemu_dmabuf_free back to g_clear_pointer\n         as it was done because of some misunderstanding (v13).\n\n     --- (vhost-user-gpu) g-\u003edmabuf[m-\u003escanout_id] needs to be set to NULL\n         to prevent freed dmabuf to be accessed again in case if(fd\u003d\u003d-1)break;\n         happens (before new dmabuf is allocated). Otherwise, it would cause\n         invalid memory access when the same function is executed. Also NULL\n         check should be done before qemu_dmabuf_close (it asserts dmabuf!\u003dNULL.).\n         (Marc-André Lureau \u003cmarcandre.lureau@redhat.com\u003e)\n\nSuggested-by: Marc-André Lureau \u003cmarcandre.lureau@redhat.com\u003e\nCc: Philippe Mathieu-Daudé \u003cphilmd@linaro.org\u003e\nCc: Daniel P. Berrangé \u003cberrange@redhat.com\u003e\nCc: Vivek Kasireddy \u003cvivek.kasireddy@intel.com\u003e\nSigned-off-by: Dongwon Kim \u003cdongwon.kim@intel.com\u003e\nMessage-Id: \u003c20240508175403.3399895-6-dongwon.kim@intel.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "454e5afcff54d428a94fcb9be333d02dbba1f740",
      "old_mode": 33188,
      "old_path": "hw/display/vhost-user-gpu.c",
      "new_id": "e4b398d26c039783c3ff416fefa3cb482a782c22",
      "new_mode": 33188,
      "new_path": "hw/display/vhost-user-gpu.c"
    },
    {
      "type": "modify",
      "old_id": "c90eba281e75acd436b2aaf06d698f0fcb3ff5f0",
      "old_mode": 33188,
      "old_path": "hw/display/virtio-gpu-udmabuf.c",
      "new_id": "c02ec6d37dc4b897d90a10f5f612d5c219b84f0d",
      "new_mode": 33188,
      "new_path": "hw/display/virtio-gpu-udmabuf.c"
    },
    {
      "type": "modify",
      "old_id": "7784502b530313923c4a5ab42b01ca87b25d1c03",
      "old_mode": 33188,
      "old_path": "hw/vfio/display.c",
      "new_id": "fe624a6c9b86e7204e2763ab62ef60903f19d350",
      "new_mode": 33188,
      "new_path": "hw/vfio/display.c"
    },
    {
      "type": "modify",
      "old_id": "b9da6c08ef41174610eb92726c590309a53696a3",
      "old_mode": 33188,
      "old_path": "include/hw/vfio/vfio-common.h",
      "new_id": "d66e27db02a4db8329204f88d02a204eedf1caa1",
      "new_mode": 33188,
      "new_path": "include/hw/vfio/vfio-common.h"
    },
    {
      "type": "modify",
      "old_id": "ed44cdad6b349407018d13f761ff589e9769598f",
      "old_mode": 33188,
      "old_path": "include/hw/virtio/virtio-gpu.h",
      "new_id": "56d6e821bf040176ba7f3347ff02e7a86e25e873",
      "new_mode": 33188,
      "new_path": "include/hw/virtio/virtio-gpu.h"
    },
    {
      "type": "modify",
      "old_id": "62d1e2d3f9e48adce1d6aeedd15550b7c7b06f14",
      "old_mode": 33188,
      "old_path": "ui/dbus-listener.c",
      "new_id": "54900880433eda6e4747c953ac4f212b423cbdb1",
      "new_mode": 33188,
      "new_path": "ui/dbus-listener.c"
    }
  ]
}