commit c0fc5123ad33158f6f289a896b568b9adce7d1f2
author Kevin Wolf <kwolf@redhat.com> Fri Sep 29 16:51:46 2023 +0200
committer Kevin Wolf <kwolf@redhat.com> Thu Oct 12 16:31:33 2023 +0200
tree a589f4e13760c298ed3b8c057f756b10a89ccf77
parent b7cfc7d58ec697a681a269036dc8f6444ffd495d

block: Mark bdrv_primary_child() and callers GRAPH_RDLOCK

This adds GRAPH_RDLOCK annotations to declare that callers of
bdrv_primary_child() need to hold a reader lock for the graph
because it accesses the children list of a node.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20230929145157.45443-12-kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

block/snapshot.c

diff --git a/block/snapshot.c b/block/snapshot.c
index 5540655..ad2bf6e 100644
--- a/block/snapshot.c
+++ b/block/snapshot.c
@@ -311,7 +311,10 @@
          * respective option (with the qdict_put_str() call above).
          * Assert that .bdrv_open() has attached the right BDS as primary child.
          */
+        bdrv_graph_rdlock_main_loop();
         assert(bdrv_primary_bs(bs) == fallback_bs);
+        bdrv_graph_rdunlock_main_loop();
+
         bdrv_unref(fallback_bs);
         return ret;
     }