commit c05dfcb7f2c5e39fc47c347de305df4e6afb4fa9
author Fabiano Rosas <farosas@suse.de> Thu Feb 29 12:29:59 2024 -0300
committer Peter Xu <peterx@redhat.com> Fri Mar 01 15:42:04 2024 +0800
tree 81260a1275b385de671dc652e0a0757ff7e475e7
parent 0478b030fa2530cbbfc4d6432e8e39a16d06865b

io: fsync before closing a file channel

Make sure the data is flushed to disk before closing file
channels. This is to ensure data is on disk and not lost in the event
of a host crash.

This is currently being implemented to affect the migration code when
migrating to a file, but all QIOChannelFile users should benefit from
the change.

Reviewed-by: "Daniel P. Berrangé" <berrange@redhat.com>
Acked-by: "Daniel P. Berrangé" <berrange@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20240229153017.2221-6-farosas@suse.de
Signed-off-by: Peter Xu <peterx@redhat.com>

io/channel-file.c

diff --git a/io/channel-file.c b/io/channel-file.c
index a6ad777..d4706fa 100644
--- a/io/channel-file.c
+++ b/io/channel-file.c
@@ -242,6 +242,11 @@
 {
     QIOChannelFile *fioc = QIO_CHANNEL_FILE(ioc);
 
+    if (qemu_fdatasync(fioc->fd) < 0) {
+        error_setg_errno(errp, errno,
+                         "Unable to synchronize file data with storage device");
+        return -1;
+    }
     if (qemu_close(fioc->fd) < 0) {
         error_setg_errno(errp, errno,
                          "Unable to close file");