commit bb509d944129e9987d10d97a1dd4a3e099cd505d
author Philippe Mathieu-Daudé <philmd@linaro.org> Fri Dec 16 08:28:32 2022 +0100
committer Philippe Mathieu-Daudé <philmd@linaro.org> Mon Feb 27 22:29:02 2023 +0100
tree 75fa7fc906bed5b7ed7837d036ec0d2e63163796
parent 7ae8e6c9a21bff7db376a8b1b135dffa0bb920d6

dump: Replace tswapN() -> cpu_to_dumpN()

All uses of tswap in that file are wrong, and should be using
cpu_to_dumpN, which correctly tests the endianness of the output.

Reported-by: Richard Henderson <richard.henderson@linaro.org>
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230225094903.53167-2-philmd@linaro.org>

dump/dump.c

diff --git a/dump/dump.c b/dump/dump.c
index 1362810..0ab229e 100644
--- a/dump/dump.c
+++ b/dump/dump.c
@@ -907,13 +907,13 @@
     if (dump_is_64bit(s)) {
         const Elf64_Nhdr *hdr = note;
         note_head_sz = sizeof(Elf64_Nhdr);
-        name_sz = tswap64(hdr->n_namesz);
-        desc_sz = tswap64(hdr->n_descsz);
+        name_sz = cpu_to_dump64(s, hdr->n_namesz);
+        desc_sz = cpu_to_dump64(s, hdr->n_descsz);
     } else {
         const Elf32_Nhdr *hdr = note;
         note_head_sz = sizeof(Elf32_Nhdr);
-        name_sz = tswap32(hdr->n_namesz);
-        desc_sz = tswap32(hdr->n_descsz);
+        name_sz = cpu_to_dump32(s, hdr->n_namesz);
+        desc_sz = cpu_to_dump32(s, hdr->n_descsz);
     }
 
     if (note_head_size) {