commit b801e3cb2a7fd631a219222a8cbe9d554c906070
author Paolo Bonzini <pbonzini@redhat.com> Tue Oct 29 10:45:51 2024 +0100
committer Paolo Bonzini <pbonzini@redhat.com> Thu Oct 31 18:28:32 2024 +0100
tree 6ac9a4df0938700c017b91196f971a667aeef24f
parent 845b54efafa5c28040570dcb6d7f8f84d23e37f3

qom: use object_new_with_class when possible

A small optimization/code simplification, that also makes it clear that
we won't look for a type in a not-loaded-yet module---the module will
have been loaded by a call to module_object_class_by_name(), if present.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

hw/core/qdev.c

diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index db36f54..2f740fa 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -167,10 +167,11 @@
 
 DeviceState *qdev_try_new(const char *name)
 {
-    if (!module_object_class_by_name(name)) {
+    ObjectClass *oc = module_object_class_by_name(name);
+    if (!oc) {
         return NULL;
     }
-    return DEVICE(object_new(name));
+    return DEVICE(object_new_with_class(oc));
 }
 
 static QTAILQ_HEAD(, DeviceListener) device_listeners

qom/object_interfaces.c

diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
index e0833c8..1f2aa13 100644
--- a/qom/object_interfaces.c
+++ b/qom/object_interfaces.c
@@ -108,7 +108,7 @@
     }
 
     assert(qdict);
-    obj = object_new(type);
+    obj = object_new_with_class(klass);
     object_set_properties_from_qdict(obj, qdict, v, &local_err);
     if (local_err) {
         goto out;

qom/qom-qmp-cmds.c

diff --git a/qom/qom-qmp-cmds.c b/qom/qom-qmp-cmds.c
index e91a235..69a8e17 100644
--- a/qom/qom-qmp-cmds.c
+++ b/qom/qom-qmp-cmds.c
@@ -141,7 +141,7 @@
         return NULL;
     }
 
-    obj = object_new(typename);
+    obj = object_new_with_class(klass);
 
     object_property_iter_init(&iter, obj);
     while ((prop = object_property_iter_next(&iter))) {