Google Git
Sign in
qemu / qemu / b5806108d20fc32b4692e721d8bd6376f4ca4a69
commitb5806108d20fc32b4692e721d8bd6376f4ca4a69[log] [tgz]
authorAlberto Garcia <berto@igalia.com>Wed Sep 13 11:28:17 2017 +0300
committerKevin Wolf <kwolf@redhat.com>Tue Sep 26 14:46:23 2017 +0200
tree85e7f935c7dfe158516c34b04bfc57923d146275
parent93e53fb6952c85ef54b209c92358963fb66d0fa2 [diff]
throttle: Assert that bkt->max is valid in throttle_compute_wait()

If bkt->max == 0 and bkt->burst_length > 1 then we could have a
division by 0 in throttle_do_compute_wait(). That configuration is
however not permitted and is already detected by throttle_is_valid(),
but let's assert it in throttle_compute_wait() to make it explicit.

Found by Coverity (CID: 1381016).

Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
1 file changed
tree: 85e7f935c7dfe158516c34b04bfc57923d146275
  1. accel/
  2. audio/
  3. backends/
  4. block/
  5. bsd-user/
  6. chardev/
  7. contrib/
  8. crypto/
  9. default-configs/
  10. disas/
  11. docs/
  12. fpu/
  13. fsdev/
  14. gdb-xml/
  15. hw/
  16. include/
  17. io/
  18. libdecnumber/
  19. linux-headers/
  20. linux-user/
  21. migration/
  22. nbd/
  23. net/
  24. pc-bios/
  25. po/
  26. qapi/
  27. qga/
  28. qobject/
  29. qom/
  30. replay/
  31. roms/
  32. scripts/
  33. scsi/
  34. slirp/
  35. stubs/
  36. target/
  37. tcg/
  38. tests/
  39. trace/
  40. ui/
  41. util/
  42. dtc
  43. .dir-locals.el
  44. .editorconfig
  45. .exrc
  46. .gdbinit
  47. .gitignore
  48. .gitmodules
  49. .mailmap
  50. .shippable.yml
  51. .travis.yml
  52. arch_init.c
  53. balloon.c
  54. block.c
  55. blockdev-nbd.c
  56. blockdev.c
  57. blockjob.c
  58. bootdevice.c
  59. bt-host.c
  60. bt-vhci.c
  61. Changelog
  62. CODING_STYLE
  63. configure
  64. COPYING
  65. COPYING.LIB
  66. COPYING.PYTHON
  67. cpus-common.c
  68. cpus.c
  69. device-hotplug.c
  70. device_tree.c
  71. disas.c
  72. dma-helpers.c
  73. dump.c
  74. exec.c
  75. gdbstub.c
  76. HACKING
  77. hmp-commands-info.hx
  78. hmp-commands.hx
  79. hmp.c
  80. hmp.h
  81. ioport.c
  82. iothread.c
  83. LICENSE
  84. MAINTAINERS
  85. Makefile
  86. Makefile.objs
  87. Makefile.target
  88. memory.c
  89. memory_ldst.inc.c
  90. memory_mapping.c
  91. module-common.c
  92. monitor.c
  93. numa.c
  94. os-posix.c
  95. os-win32.c
  96. qapi-schema.json
  97. qdev-monitor.c
  98. qdict-test-data.txt
  99. qemu-bridge-helper.c
  100. qemu-doc.texi
  101. qemu-ga.texi
  102. qemu-img-cmds.hx
  103. qemu-img.c
  104. qemu-img.texi
  105. qemu-io-cmds.c
  106. qemu-io.c
  107. qemu-nbd.c
  108. qemu-nbd.texi
  109. qemu-option-trace.texi
  110. qemu-options-wrapper.h
  111. qemu-options.h
  112. qemu-options.hx
  113. qemu-seccomp.c
  114. qemu-tech.texi
  115. qemu.nsi
  116. qemu.sasl
  117. qmp.c
  118. qtest.c
  119. README
  120. replication.c
  121. replication.h
  122. rules.mak
  123. thunk.c
  124. tpm.c
  125. trace-events
  126. VERSION
  127. version.rc
  128. vl.c