commit b35348c7e62dc9b7caaabf3b45863ac119db9347
author Richard Henderson <richard.henderson@linaro.org> Tue Mar 05 10:15:50 2024 -1000
committer Richard Henderson <richard.henderson@linaro.org> Tue Mar 12 03:36:19 2024 -1000
tree 4527e6cca018fd1c3859a400a68c5a39ff69d487
parent 8de24b15630a9b2d474be593289c8bf54dacd50a

linux-user/elfload: Don't close an unopened file descriptor

Fixes Coverity CID: 1534964
Fixes: 106f8da664 ("linux-user/elfload: Open core file after vma_init")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

linux-user/elfload.c

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 4dbca05..26d4c1d 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -4522,7 +4522,9 @@
     ret = -errno;
     mmap_unlock();
     cpu_list_unlock();
-    close(fd);
+    if (fd >= 0) {
+        close(fd);
+    }
     return ret;
 }
 #endif /* USE_ELF_CORE_DUMP */