commit b0197cf80a903aa1e401cc7ebdf8be8bc307297b
author Marcel Apfelbaum <marcel.apfelbaum@gmail.com> Mon Apr 30 23:02:18 2018 +0300
committer Marcel Apfelbaum <marcel.apfelbaum@gmail.com> Thu May 03 20:52:29 2018 +0300
tree 0272945b6f0dbc5cb45fafc7bd8b12fba9227c6e
parent 1bad4957c8c4d5367961cb3d5287b2f25a1d6847

hw/rdma: Fix possible usage of a NULL pointer

Coverity CID 1390586; The cq handle is provided by the guest
and cannot be trusted to be previuosly allocated.
Fix it by exiting the completion flow.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
Message-Id: <20180430200223.4119-3-marcel.apfelbaum@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

hw/rdma/vmw/pvrdma_qp_ops.c

diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c
index 750ade6..99bb511 100644
--- a/hw/rdma/vmw/pvrdma_qp_ops.c
+++ b/hw/rdma/vmw/pvrdma_qp_ops.c
@@ -216,6 +216,7 @@
     cq = rdma_rm_get_cq(dev_res, cq_handle);
     if (!cq) {
         pr_dbg("Invalid CQ# %d\n", cq_handle);
+        return;
     }
 
     rdma_backend_poll_cq(dev_res, &cq->backend_cq);