Google Git
Sign in
qemu / qemu / ae990e6cd77a4e6004b7abc6d293598910abca63
commitae990e6cd77a4e6004b7abc6d293598910abca63[log] [tgz]
authorDavid Hildenbrand <david@redhat.com>Mon Oct 16 16:42:56 2017 +0200
committerPaolo Bonzini <pbonzini@redhat.com>Wed Oct 18 09:49:48 2017 +0200
tree85659c1c063e5f03978b3d27173c3e2f91b9b193
parentb066c5375737ad0d630196dab2a2b329515a1d00 [diff]
memory: call log_start after region_add

It might be confusing for some listener implementations that implement
both, region_add and log_start (e.g. KVM) if we call log_start before an
actual region was added using region_add.

This makes current KVM code trigger an assertion
("kvm_section_update_flags: error finding slot"). So let's just reverse
the order instead of tolerating log_start on yet unknown regions.

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20171016144302.24284-2-david@redhat.com>
Tested-by: Joe Clifford <joeclifford@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 file changed
tree: 85659c1c063e5f03978b3d27173c3e2f91b9b193
  1. accel/
  2. audio/
  3. backends/
  4. block/
  5. bsd-user/
  6. chardev/
  7. contrib/
  8. crypto/
  9. default-configs/
  10. disas/
  11. docs/
  12. fpu/
  13. fsdev/
  14. gdb-xml/
  15. hw/
  16. include/
  17. io/
  18. libdecnumber/
  19. linux-headers/
  20. linux-user/
  21. migration/
  22. nbd/
  23. net/
  24. pc-bios/
  25. po/
  26. qapi/
  27. qga/
  28. qobject/
  29. qom/
  30. replay/
  31. roms/
  32. scripts/
  33. scsi/
  34. slirp/
  35. stubs/
  36. target/
  37. tcg/
  38. tests/
  39. trace/
  40. ui/
  41. util/
  42. dtc
  43. .dir-locals.el
  44. .editorconfig
  45. .exrc
  46. .gdbinit
  47. .gitignore
  48. .gitmodules
  49. .mailmap
  50. .shippable.yml
  51. .travis.yml
  52. arch_init.c
  53. balloon.c
  54. block.c
  55. blockdev-nbd.c
  56. blockdev.c
  57. blockjob.c
  58. bootdevice.c
  59. bt-host.c
  60. bt-vhci.c
  61. Changelog
  62. CODING_STYLE
  63. configure
  64. COPYING
  65. COPYING.LIB
  66. COPYING.PYTHON
  67. cpus-common.c
  68. cpus.c
  69. device-hotplug.c
  70. device_tree.c
  71. disas.c
  72. dma-helpers.c
  73. dump.c
  74. exec.c
  75. gdbstub.c
  76. HACKING
  77. hmp-commands-info.hx
  78. hmp-commands.hx
  79. hmp.c
  80. hmp.h
  81. ioport.c
  82. iothread.c
  83. LICENSE
  84. MAINTAINERS
  85. Makefile
  86. Makefile.objs
  87. Makefile.target
  88. memory.c
  89. memory_ldst.inc.c
  90. memory_mapping.c
  91. module-common.c
  92. monitor.c
  93. numa.c
  94. os-posix.c
  95. os-win32.c
  96. qapi-schema.json
  97. qdev-monitor.c
  98. qdict-test-data.txt
  99. qemu-bridge-helper.c
  100. qemu-doc.texi
  101. qemu-ga.texi
  102. qemu-img-cmds.hx
  103. qemu-img.c
  104. qemu-img.texi
  105. qemu-io-cmds.c
  106. qemu-io.c
  107. qemu-nbd.c
  108. qemu-nbd.texi
  109. qemu-option-trace.texi
  110. qemu-options-wrapper.h
  111. qemu-options.h
  112. qemu-options.hx
  113. qemu-seccomp.c
  114. qemu-tech.texi
  115. qemu.nsi
  116. qemu.sasl
  117. qmp.c
  118. qtest.c
  119. README
  120. replication.c
  121. replication.h
  122. rules.mak
  123. thunk.c
  124. tpm.c
  125. trace-events
  126. VERSION
  127. version.rc
  128. vl.c