commit ae5475e82fd1ebb24f4f77cf28f59ca6548c6136
author Kevin Wolf <kwolf@redhat.com> Tue Jun 26 13:22:45 2018 +0200
committer Kevin Wolf <kwolf@redhat.com> Fri Jun 29 14:20:56 2018 +0200
tree 961e73eb68a76836836b95ed180153345e54e6d2
parent 7c8952697e9c44931090251e142c1d3108c22be4

qcow2: Fix qcow2_truncate() error return value

If qcow2_alloc_clusters_at() returns an error, we do need to negate it
to get back the positive errno code for error_setg_errno(), but we still
need to return the negative error code.

Fixes: 772d1f973f87269f6a4a4ea4b880680f3779bbdf
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

block/qcow2.c

diff --git a/block/qcow2.c b/block/qcow2.c
index a3a3aa2..6b2e1e1 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -3597,7 +3597,7 @@
         if (clusters_allocated < 0) {
             error_setg_errno(errp, -clusters_allocated,
                              "Failed to allocate data clusters");
-            return -clusters_allocated;
+            return clusters_allocated;
         }
 
         assert(clusters_allocated == nb_new_data_clusters);