commit aca9fcd28e8a40f2555f8d6d113e4988335aa629
author Blue Swirl <blauwirbel@gmail.com> Sun Mar 07 13:13:05 2010 +0000
committer Blue Swirl <blauwirbel@gmail.com> Sun Mar 07 13:13:05 2010 +0000
tree d6650bd1c4fcf82840176590ef2969f1a73a3d70
parent a990f58feda5d6b547af30a7cd281936300e13ff

slirp: remove dead assignments, spotted by clang

Value stored is never read.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>

slirp/tcp_input.c

diff --git a/slirp/tcp_input.c b/slirp/tcp_input.c
index 47cf0ad..2808e3e 100644
--- a/slirp/tcp_input.c
+++ b/slirp/tcp_input.c
@@ -597,7 +597,7 @@
 	      *ip=save_ip;
 	      icmp_error(m, ICMP_UNREACH,code, 0,strerror(errno));
 	    }
-	    tp = tcp_close(tp);
+            tcp_close(tp);
 	    m_free(m);
 	  } else {
 	    /*
@@ -660,8 +660,9 @@
 			goto dropwithreset;
 
 		if (tiflags & TH_RST) {
-			if (tiflags & TH_ACK)
-				tp = tcp_drop(tp,0); /* XXX Check t_softerror! */
+                        if (tiflags & TH_ACK) {
+                                tcp_drop(tp, 0); /* XXX Check t_softerror! */
+                        }
 			goto drop;
 		}
 
@@ -821,13 +822,13 @@
 	case TCPS_FIN_WAIT_2:
 	case TCPS_CLOSE_WAIT:
 		tp->t_state = TCPS_CLOSED;
-		tp = tcp_close(tp);
+                tcp_close(tp);
 		goto drop;
 
 	case TCPS_CLOSING:
 	case TCPS_LAST_ACK:
 	case TCPS_TIME_WAIT:
-		tp = tcp_close(tp);
+                tcp_close(tp);
 		goto drop;
 	}
 
@@ -1074,7 +1075,7 @@
 		 */
 		case TCPS_LAST_ACK:
 			if (ourfinisacked) {
-				tp = tcp_close(tp);
+                                tcp_close(tp);
 				goto drop;
 			}
 			break;
@@ -1165,12 +1166,6 @@
 	if ((ti->ti_len || (tiflags&TH_FIN)) &&
 	    TCPS_HAVERCVDFIN(tp->t_state) == 0) {
 		TCP_REASS(tp, ti, m, so, tiflags);
-		/*
-		 * Note the amount of data that peer has sent into
-		 * our window, in order to estimate the sender's
-		 * buffer size.
-		 */
-		len = so->so_rcv.sb_datalen - (tp->rcv_adv - tp->rcv_nxt);
 	} else {
 		m_free(m);
 		tiflags &= ~TH_FIN;

slirp/tftp.c

diff --git a/slirp/tftp.c b/slirp/tftp.c
index 96c0e0c..67e9f2b9 100644
--- a/slirp/tftp.c
+++ b/slirp/tftp.c
@@ -161,7 +161,6 @@
   struct sockaddr_in saddr, daddr;
   struct mbuf *m;
   struct tftp_t *tp;
-  int nobytes;
 
   m = m_get(spt->slirp);
 
@@ -185,8 +184,6 @@
   daddr.sin_addr = spt->client_ip;
   daddr.sin_port = spt->client_port;
 
-  nobytes = 2;
-
   m->m_len = sizeof(struct tftp_t) - 514 + 3 + strlen(msg) -
         sizeof(struct ip) - sizeof(struct udphdr);