commit a5f9b9df252d0dfb407178ef4c3769f78a64b2ff
author Markus Armbruster <armbru@redhat.com> Tue Jul 07 18:06:05 2020 +0200
committer Markus Armbruster <armbru@redhat.com> Fri Jul 10 15:18:08 2020 +0200
tree 3332a93b91cc71e15b74b9cb566451397c1ff387
parent 992861fb1e4cf410f30ec8f05bd2dc2a14a5a027

error: Reduce unnecessary error propagation

When all we do with an Error we receive into a local variable is
propagating to somewhere else, we can just as well receive it there
right away, even when we need to keep error_propagate() for other
error paths.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-38-armbru@redhat.com>

block/quorum.c

diff --git a/block/quorum.c b/block/quorum.c
index 5d52e60..6df9449 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -921,7 +921,7 @@
     }
 
     opts = qemu_opts_create(&quorum_runtime_opts, NULL, 0, &error_abort);
-    if (!qemu_opts_absorb_qdict(opts, options, &local_err)) {
+    if (!qemu_opts_absorb_qdict(opts, options, errp)) {
         ret = -EINVAL;
         goto exit;
     }